You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Right now, this check only detects calls to Fragment#setTargetFragment. We could also extend it to detect calls to Fragment#getTargetFragment and Fragment#getTargetRequestCode, as those methods belong to the same category. What do you think?
The long term goal for strict mode is to remove any APIs that cause violations. So if you have strict mode on and your app has no problems, then when you upgrade to say Fragment 2.0 where all the APIs that cause violations have been removed, it should be like a no-op. So although, calling the getters without the setter is not very useful, we should make sure we are actually catching those calls and reporting them as violations.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed Changes
Fragment#setTargetFragment
Testing
Test: See
FragmentStrictModeTest#detectSetTargetFragment
Issues Fixed
Fixes: 153737745