| CARVIEW |
Select Language
HTTP/2 200
date: Sat, 11 Oct 2025 19:52:14 GMT
content-type: text/html; charset=utf-8
cache-control: no-cache
content-security-policy: default-src 'none'; base-uri 'self'; child-src github.githubassets.com github.com/assets-cdn/worker/ github.com/assets/ gist.github.com/assets-cdn/worker/; connect-src 'self' uploads.github.com www.githubstatus.com collector.github.com raw.githubusercontent.com api.github.com github-cloud.s3.amazonaws.com github-production-repository-file-5c1aeb.s3.amazonaws.com github-production-upload-manifest-file-7fdce7.s3.amazonaws.com github-production-user-asset-6210df.s3.amazonaws.com *.rel.tunnels.api.visualstudio.com wss://*.rel.tunnels.api.visualstudio.com github.githubassets.com objects-origin.githubusercontent.com copilot-proxy.githubusercontent.com proxy.individual.githubcopilot.com proxy.business.githubcopilot.com proxy.enterprise.githubcopilot.com *.actions.githubusercontent.com wss://*.actions.githubusercontent.com productionresultssa0.blob.core.windows.net/ productionresultssa1.blob.core.windows.net/ productionresultssa2.blob.core.windows.net/ productionresultssa3.blob.core.windows.net/ productionresultssa4.blob.core.windows.net/ productionresultssa5.blob.core.windows.net/ productionresultssa6.blob.core.windows.net/ productionresultssa7.blob.core.windows.net/ productionresultssa8.blob.core.windows.net/ productionresultssa9.blob.core.windows.net/ productionresultssa10.blob.core.windows.net/ productionresultssa11.blob.core.windows.net/ productionresultssa12.blob.core.windows.net/ productionresultssa13.blob.core.windows.net/ productionresultssa14.blob.core.windows.net/ productionresultssa15.blob.core.windows.net/ productionresultssa16.blob.core.windows.net/ productionresultssa17.blob.core.windows.net/ productionresultssa18.blob.core.windows.net/ productionresultssa19.blob.core.windows.net/ github-production-repository-image-32fea6.s3.amazonaws.com github-production-release-asset-2e65be.s3.amazonaws.com insights.github.com wss://alive.github.com wss://alive-staging.github.com api.githubcopilot.com api.individual.githubcopilot.com api.business.githubcopilot.com api.enterprise.githubcopilot.com; font-src github.githubassets.com; form-action 'self' github.com gist.github.com copilot-workspace.githubnext.com objects-origin.githubusercontent.com; frame-ancestors 'none'; frame-src viewscreen.githubusercontent.com notebooks.githubusercontent.com; img-src 'self' data: blob: github.githubassets.com media.githubusercontent.com camo.githubusercontent.com identicons.github.com avatars.githubusercontent.com private-avatars.githubusercontent.com github-cloud.s3.amazonaws.com objects.githubusercontent.com release-assets.githubusercontent.com secured-user-images.githubusercontent.com/ user-images.githubusercontent.com/ private-user-images.githubusercontent.com opengraph.githubassets.com marketplace-screenshots.githubusercontent.com/ copilotprodattachments.blob.core.windows.net/github-production-copilot-attachments/ github-production-user-asset-6210df.s3.amazonaws.com customer-stories-feed.github.com spotlights-feed.github.com objects-origin.githubusercontent.com *.githubusercontent.com; manifest-src 'self'; media-src github.com user-images.githubusercontent.com/ secured-user-images.githubusercontent.com/ private-user-images.githubusercontent.com github-production-user-asset-6210df.s3.amazonaws.com gist.github.com; script-src github.githubassets.com; style-src 'unsafe-inline' github.githubassets.com; upgrade-insecure-requests; worker-src github.githubassets.com github.com/assets-cdn/worker/ github.com/assets/ gist.github.com/assets-cdn/worker/
referrer-policy: no-referrer-when-downgrade
server-timing: pull_request_layout-fragment;desc="pull_request_layout fragment";dur=404.661512,conversation_content-fragment;desc="conversation_content fragment";dur=1004.316958,conversation_sidebar-fragment;desc="conversation_sidebar fragment";dur=507.867509,nginx;desc="NGINX";dur=0.985707,glb;desc="GLB";dur=137.221743
strict-transport-security: max-age=31536000; includeSubdomains; preload
vary: X-PJAX, X-PJAX-Container, Turbo-Visit, Turbo-Frame, X-Requested-With,Accept-Encoding, Accept, X-Requested-With
x-content-type-options: nosniff
x-frame-options: deny
x-voltron-version: aab62e3
x-xss-protection: 0
server: github.com
content-encoding: gzip
accept-ranges: bytes
set-cookie: _gh_sess=jUb9cOcwr9xcvmOC5I5XfCGscEGHbe8SFiNjSLHr1KzyHalNi8BT1QsB9UxwrJN1BOnDcuS78lG%2BCauSEIHnSAM677lcbWB24pTd8S%2BjqRxtAZVL0WBaAd38VsgB9pxwKtH9CBN5Lq7FByP3JsKwepVRM9ljqY8GpbY3UyYaikcQY0gvUFantP8DsHUayTraeU260uoa2KInPSGgmKFwsMEk7WfnKiYZZ1kaUr%2FHPj1bwsMn7gD0wCn%2FC9m2jX15KDUtMYBvj43DTEAU92uEhg%3D%3D--VERM0vLVaItkmiOK--K0D1KC7yoGaiInZNclQAog%3D%3D; Path=/; HttpOnly; Secure; SameSite=Lax
set-cookie: _octo=GH1.1.1019930015.1760212333; Path=/; Domain=github.com; Expires=Sun, 11 Oct 2026 19:52:13 GMT; Secure; SameSite=Lax
set-cookie: logged_in=no; Path=/; Domain=github.com; Expires=Sun, 11 Oct 2026 19:52:13 GMT; HttpOnly; Secure; SameSite=Lax
x-github-request-id: B856:2994BB:9BBD20:CCA5CA:68EAB56D
Avoid exception when calling Activity.reportFullyDrawn() by simonschiller · Pull Request #103 · androidx/androidx · GitHub
simonschiller
changed the base branch from
androidx-master-dev
to
androidx-main
December 8, 2020 11:19
simonschiller
changed the base branch from
androidx-main
to
androidx-master-dev
December 8, 2020 19:12
Skip to content
Navigation Menu
{{ message }}
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
Avoid exception when calling Activity.reportFullyDrawn() #103
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
simonschiller
wants to merge
3
commits into
androidx:androidx-master-dev
from
simonschiller:bugfix/report-fully-drawn
Closed
Avoid exception when calling Activity.reportFullyDrawn() #103
simonschiller
wants to merge
3
commits into
androidx:androidx-master-dev
from
simonschiller:bugfix/report-fully-drawn
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Just a heads up that we are in the middle of transitioning to |
|
(But if this gets in in the next few days you won't run into any issues) |
ianhanniballake
requested changes
Dec 8, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please move this code to androidx.activity.ComponentActivity and write a test for this (at the very least, our internal CI runs on API 19 devices and will help serve as a regression test that this method doesn't crash).
| != PackageManager.PERMISSION_GRANTED) { | ||
| return; | ||
| } | ||
| super.reportFullyDrawn(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Note that this should be guarded with a Build.VERSION.SDK_INT >= 19 so that reportFullyDrawn() can be called on all API levels.
That means it may be more appropriate to re-arrange this method to be something more like:
if (Build.VERSION.SDK_INT >= 20) {
super.reportFullyDrawn();
} else if (Build.VERSION.SDK_INT == 19 && ContextCompat...) {
// Your current code and comment re: the specific behavior of API 19
}
| // On KitKat (API 19) the Activity.reportFullyDrawn() method requires the | ||
| // UPDATE_DEVICE_STATS permission, otherwise it throws an exception. Instead of throwing, | ||
| // we fall back to a no-op call here. | ||
| if (Build.VERSION.SDK_INT == Build.VERSION_CODES.KITKAT && ContextCompat |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The general convention in AndroidX code is to use the numbers themselves, rather than Build.VERSION_CODES values. Please use 19 here.
simonschiller
changed the base branch from
androidx-master-dev
to
androidx-main
ianhanniballake
approved these changes
Dec 8, 2020
|
Sorry for the churn - do you mind actually basing your PR on top of |
simonschiller
changed the base branch from
androidx-main
to
androidx-master-dev
|
Sure, no problem ✔️ |
dlam
approved these changes
Dec 8, 2020
ianhanniballake
approved these changes
Dec 8, 2020
dlam
approved these changes
Dec 8, 2020
|
jcenter 502'ing :| |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
You can’t perform that action at this time.
Proposed Changes
Activity.reportFullyDrawn()I'm not quite sure if this class is the right place for this workaround, the code could also live in other places, e.g.:
androidx.core.app.ComponentActivityandroidx.activity.ComponentActivityandroidx.appcompat.app.AppCompatActivityTesting
Test: Manually tested. If your test harness is also executed on devices with API 19, I could write an automated test for this change if you want.
Issues Fixed
Fixes: 163239764