Fix bug 3312807 - Fix child margin measurement in FrameLayout

adamp · adamp · commit 2b6be701a90a · 2011-01-08T16:44:07.000-08:00
Change-Id: I5166d7b2d283c577d5f95a15b1626b068cfa6bc6
diff --git a/core/java/android/widget/FrameLayout.java b/core/java/android/widget/FrameLayout.java
@@ -265,11 +265,13 @@ protected void onMeasure(int widthMeasureSpec, int heightMeasureSpec) {
             final View child = getChildAt(i);
             if (mMeasureAllChildren || child.getVisibility() != GONE) {
                 measureChildWithMargins(child, widthMeasureSpec, 0, heightMeasureSpec, 0);
-                maxWidth = Math.max(maxWidth, child.getMeasuredWidth());
-                maxHeight = Math.max(maxHeight, child.getMeasuredHeight());
+                final LayoutParams lp = (LayoutParams) child.getLayoutParams();
+                maxWidth = Math.max(maxWidth,
+                        child.getMeasuredWidth() + lp.leftMargin + lp.rightMargin);
+                maxHeight = Math.max(maxHeight,
+                        child.getMeasuredHeight() + lp.topMargin + lp.bottomMargin);
                 childState = combineMeasuredStates(childState, child.getMeasuredState());
                 if (measureMatchParentChildren) {
-                    final ViewGroup.LayoutParams lp = child.getLayoutParams();
                     if (lp.width == LayoutParams.MATCH_PARENT ||
                             lp.height == LayoutParams.MATCH_PARENT) {
                         mMatchParentChildren.add(child);
