| CARVIEW |
Select Language
HTTP/2 200
date: Sat, 26 Jul 2025 23:50:23 GMT
content-type: text/html; charset=utf-8
cache-control: no-cache
content-security-policy: default-src 'none'; base-uri 'self'; child-src github.githubassets.com github.com/assets-cdn/worker/ github.com/assets/ gist.github.com/assets-cdn/worker/; connect-src 'self' uploads.github.com www.githubstatus.com collector.github.com raw.githubusercontent.com api.github.com github-cloud.s3.amazonaws.com github-production-repository-file-5c1aeb.s3.amazonaws.com github-production-upload-manifest-file-7fdce7.s3.amazonaws.com github-production-user-asset-6210df.s3.amazonaws.com *.rel.tunnels.api.visualstudio.com wss://*.rel.tunnels.api.visualstudio.com objects-origin.githubusercontent.com copilot-proxy.githubusercontent.com proxy.individual.githubcopilot.com proxy.business.githubcopilot.com proxy.enterprise.githubcopilot.com *.actions.githubusercontent.com wss://*.actions.githubusercontent.com productionresultssa0.blob.core.windows.net/ productionresultssa1.blob.core.windows.net/ productionresultssa2.blob.core.windows.net/ productionresultssa3.blob.core.windows.net/ productionresultssa4.blob.core.windows.net/ productionresultssa5.blob.core.windows.net/ productionresultssa6.blob.core.windows.net/ productionresultssa7.blob.core.windows.net/ productionresultssa8.blob.core.windows.net/ productionresultssa9.blob.core.windows.net/ productionresultssa10.blob.core.windows.net/ productionresultssa11.blob.core.windows.net/ productionresultssa12.blob.core.windows.net/ productionresultssa13.blob.core.windows.net/ productionresultssa14.blob.core.windows.net/ productionresultssa15.blob.core.windows.net/ productionresultssa16.blob.core.windows.net/ productionresultssa17.blob.core.windows.net/ productionresultssa18.blob.core.windows.net/ productionresultssa19.blob.core.windows.net/ github-production-repository-image-32fea6.s3.amazonaws.com github-production-release-asset-2e65be.s3.amazonaws.com insights.github.com wss://alive.github.com api.githubcopilot.com api.individual.githubcopilot.com api.business.githubcopilot.com api.enterprise.githubcopilot.com; font-src github.githubassets.com; form-action 'self' github.com gist.github.com copilot-workspace.githubnext.com objects-origin.githubusercontent.com; frame-ancestors 'none'; frame-src viewscreen.githubusercontent.com notebooks.githubusercontent.com; img-src 'self' data: blob: github.githubassets.com media.githubusercontent.com camo.githubusercontent.com identicons.github.com avatars.githubusercontent.com private-avatars.githubusercontent.com github-cloud.s3.amazonaws.com objects.githubusercontent.com release-assets.githubusercontent.com secured-user-images.githubusercontent.com/ user-images.githubusercontent.com/ private-user-images.githubusercontent.com opengraph.githubassets.com copilotprodattachments.blob.core.windows.net/github-production-copilot-attachments/ github-production-user-asset-6210df.s3.amazonaws.com customer-stories-feed.github.com spotlights-feed.github.com objects-origin.githubusercontent.com *.githubusercontent.com; manifest-src 'self'; media-src github.com user-images.githubusercontent.com/ secured-user-images.githubusercontent.com/ private-user-images.githubusercontent.com github-production-user-asset-6210df.s3.amazonaws.com gist.github.com; script-src github.githubassets.com; style-src 'unsafe-inline' github.githubassets.com; upgrade-insecure-requests; worker-src github.githubassets.com github.com/assets-cdn/worker/ github.com/assets/ gist.github.com/assets-cdn/worker/
referrer-policy: no-referrer-when-downgrade
server-timing: pull_request_layout-fragment;desc="pull_request_layout fragment";dur=322.548062,conversation_content-fragment;desc="conversation_content fragment";dur=705.112045,conversation_sidebar-fragment;desc="conversation_sidebar fragment";dur=265.429792,nginx;desc="NGINX";dur=0.569511,glb;desc="GLB";dur=102.227419
strict-transport-security: max-age=31536000; includeSubdomains; preload
vary: X-PJAX, X-PJAX-Container, Turbo-Visit, Turbo-Frame, X-Requested-With,Accept-Encoding, Accept, X-Requested-With
x-content-type-options: nosniff
x-frame-options: deny
x-voltron-version: a2eb102
x-xss-protection: 0
server: github.com
content-encoding: gzip
accept-ranges: bytes
set-cookie: _gh_sess=8U2RWOHlU9%2F2la4VeDVVLZGVf7SSB3ZzwjsiasomzRfwnNj3kC7AdWrCcMf5aMwlggT8MCro2OYAXcDAR8BFsUp3ZhosCOuhDdIMN%2BmIxjIxbwV44Nd34tiFhzJyJssyHxXdLkcKuqVR3zaW9Y3dLS2BDIQP7SgGkDs%2BNlPQ0I9qrwPPITHasJgfn8q7wk0IrQ6qjHp5pNpXfUi7KQtaupJ43IMlqQHtONAEWDQ%2FNqm0chKtmInt6RtZtK9uGAWx6V9EArNrHrqpZ40qS8l0eQ%3D%3D--2JtmnEyqGNdSzMPo--DlHSjYtQ7iZBGKOQX6eMMw%3D%3D; Path=/; HttpOnly; Secure; SameSite=Lax
set-cookie: _octo=GH1.1.1051705302.1753573823; Path=/; Domain=github.com; Expires=Sun, 26 Jul 2026 23:50:23 GMT; Secure; SameSite=Lax
set-cookie: logged_in=no; Path=/; Domain=github.com; Expires=Sun, 26 Jul 2026 23:50:23 GMT; HttpOnly; Secure; SameSite=Lax
x-github-request-id: CE38:3ED739:97184E:C6DEB3:688569BF
Add tracer and polish related code by louyuting · Pull Request #65 · alibaba/sentinel-golang · GitHub
louyuting
force-pushed
the
add_tracer
branch
from
February 25, 2020 15:58
louyuting
force-pushed
the
add_tracer
branch
2 times, most recently
from
February 26, 2020 13:00
sczyh30
added
kind/feature
Category issues or PRs related to feature request
and removed
to-review
PRs to review
labels
Feb 26, 2020
Skip to content
Navigation Menu
{{ message }}
-
Notifications
You must be signed in to change notification settings - Fork 445
Add tracer and polish related code #65
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sczyh30
reviewed
Feb 25, 2020
api/tracer.go
Outdated
| } | ||
| } | ||
|
|
||
| func Trace(ctx *base.EntryContext, opts ...TracerOption) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some suggestions:
- The name
Traceseems too generic. How aboutTraceError? - Actually it's more common to pass the
Entryitself instead of theEntryContext, so maybe we could provide two functions here:TraceError(entry, err, opts...)andTraceErrorToCtx(ctx, err, opts...). Note that theerris required (though not used yet).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's great.
I would polish related code.
|
|
|
Great. Could you please also add simple test cases for |
louyuting
force-pushed
the
add_tracer
branch
from
c357de8 to
ae5d5dd
Compare
Ok |
louyuting
force-pushed
the
add_tracer
branch
2 times, most recently
from
0564cd3 to
ef191aa
Compare
polish related code
sczyh30
approved these changes
Feb 26, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
sczyh30
added
kind/feature
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
You can’t perform that action at this time.
Describe what this PR does / why we need it
Add tracer
Does this pull request fix one issue?
Describe how you did it
Describe how to verify it
Special notes for reviews