CARVIEW |
Select Language
HTTP/2 200
date: Sun, 27 Jul 2025 10:35:23 GMT
content-type: text/html; charset=utf-8
cache-control: no-cache
content-security-policy: default-src 'none'; base-uri 'self'; child-src github.githubassets.com github.com/assets-cdn/worker/ github.com/assets/ gist.github.com/assets-cdn/worker/; connect-src 'self' uploads.github.com www.githubstatus.com collector.github.com raw.githubusercontent.com api.github.com github-cloud.s3.amazonaws.com github-production-repository-file-5c1aeb.s3.amazonaws.com github-production-upload-manifest-file-7fdce7.s3.amazonaws.com github-production-user-asset-6210df.s3.amazonaws.com *.rel.tunnels.api.visualstudio.com wss://*.rel.tunnels.api.visualstudio.com objects-origin.githubusercontent.com copilot-proxy.githubusercontent.com proxy.individual.githubcopilot.com proxy.business.githubcopilot.com proxy.enterprise.githubcopilot.com *.actions.githubusercontent.com wss://*.actions.githubusercontent.com productionresultssa0.blob.core.windows.net/ productionresultssa1.blob.core.windows.net/ productionresultssa2.blob.core.windows.net/ productionresultssa3.blob.core.windows.net/ productionresultssa4.blob.core.windows.net/ productionresultssa5.blob.core.windows.net/ productionresultssa6.blob.core.windows.net/ productionresultssa7.blob.core.windows.net/ productionresultssa8.blob.core.windows.net/ productionresultssa9.blob.core.windows.net/ productionresultssa10.blob.core.windows.net/ productionresultssa11.blob.core.windows.net/ productionresultssa12.blob.core.windows.net/ productionresultssa13.blob.core.windows.net/ productionresultssa14.blob.core.windows.net/ productionresultssa15.blob.core.windows.net/ productionresultssa16.blob.core.windows.net/ productionresultssa17.blob.core.windows.net/ productionresultssa18.blob.core.windows.net/ productionresultssa19.blob.core.windows.net/ github-production-repository-image-32fea6.s3.amazonaws.com github-production-release-asset-2e65be.s3.amazonaws.com insights.github.com wss://alive.github.com api.githubcopilot.com api.individual.githubcopilot.com api.business.githubcopilot.com api.enterprise.githubcopilot.com; font-src github.githubassets.com; form-action 'self' github.com gist.github.com copilot-workspace.githubnext.com objects-origin.githubusercontent.com; frame-ancestors 'none'; frame-src viewscreen.githubusercontent.com notebooks.githubusercontent.com; img-src 'self' data: blob: github.githubassets.com media.githubusercontent.com camo.githubusercontent.com identicons.github.com avatars.githubusercontent.com private-avatars.githubusercontent.com github-cloud.s3.amazonaws.com objects.githubusercontent.com release-assets.githubusercontent.com secured-user-images.githubusercontent.com/ user-images.githubusercontent.com/ private-user-images.githubusercontent.com opengraph.githubassets.com copilotprodattachments.blob.core.windows.net/github-production-copilot-attachments/ github-production-user-asset-6210df.s3.amazonaws.com customer-stories-feed.github.com spotlights-feed.github.com objects-origin.githubusercontent.com *.githubusercontent.com; manifest-src 'self'; media-src github.com user-images.githubusercontent.com/ secured-user-images.githubusercontent.com/ private-user-images.githubusercontent.com github-production-user-asset-6210df.s3.amazonaws.com gist.github.com; script-src github.githubassets.com; style-src 'unsafe-inline' github.githubassets.com; upgrade-insecure-requests; worker-src github.githubassets.com github.com/assets-cdn/worker/ github.com/assets/ gist.github.com/assets-cdn/worker/
referrer-policy: no-referrer-when-downgrade
server-timing: pull_request_layout-fragment;desc="pull_request_layout fragment";dur=287.879072,conversation_content-fragment;desc="conversation_content fragment";dur=654.414954,conversation_sidebar-fragment;desc="conversation_sidebar fragment";dur=305.617432,nginx;desc="NGINX";dur=0.562919,glb;desc="GLB";dur=101.293833
strict-transport-security: max-age=31536000; includeSubdomains; preload
vary: X-PJAX, X-PJAX-Container, Turbo-Visit, Turbo-Frame, X-Requested-With,Accept-Encoding, Accept, X-Requested-With
x-content-type-options: nosniff
x-frame-options: deny
x-voltron-version: a2eb102
x-xss-protection: 0
server: github.com
content-encoding: gzip
accept-ranges: bytes
set-cookie: _gh_sess=AfGAsi6uT0CG5n6QyLu0Uvd973PcbnwuAwTSkohwAVNDH%2BvlI%2BZTfEdkpA4y3V074BpVVioZOxyKG5cmGeC0y2RT3AXqwAh8V32L8E96NcEVt69JIWfzRW9HWl0JF%2B3uZ9O896CcLi%2BgRVzxV%2FmUOuYM7lgmbHHvcxmiUJra4It86sh2XrgpCZ5vDY1oMAYhoh61VCvajxcN56qAAQ9DYTeWvvgJiKJ7fnTpg%2BCgv3X3qVKCWgTMx%2FMO6N%2FYmeTeOq0guO507WLxCCKqFo2q4A%3D%3D--Zu4SPMUmBAJJYZJt--CW1mgIDQwx2lgYIbpnMSQw%3D%3D; Path=/; HttpOnly; Secure; SameSite=Lax
set-cookie: _octo=GH1.1.1282091968.1753612522; Path=/; Domain=github.com; Expires=Mon, 27 Jul 2026 10:35:22 GMT; Secure; SameSite=Lax
set-cookie: logged_in=no; Path=/; Domain=github.com; Expires=Mon, 27 Jul 2026 10:35:22 GMT; HttpOnly; Secure; SameSite=Lax
x-github-request-id: BDF8:2F5ED7:D368A4:117ABCC:688600EA
Unify general configuration and logging configuration by louyuting · Pull Request #56 · alibaba/sentinel-golang · GitHub
louyuting
added
area/configuration
Issue related to configurations of Sentinel
to-review
PRs to review
labels
Feb 20, 2020
louyuting
force-pushed
the
unify_configuration
branch
2 times, most recently
from
February 24, 2020 15:04
louyuting
force-pushed
the
unify_configuration
branch
from
March 4, 2020 16:39
louyuting
force-pushed
the
unify_configuration
branch
from
March 8, 2020 06:15
louyuting
force-pushed
the
unify_configuration
branch
from
March 8, 2020 06:26
louyuting
force-pushed
the
unify_configuration
branch
from
March 9, 2020 14:16
sczyh30
changed the title
Unify configuration
Unify general configuration and logging configuration
Mar 10, 2020
Skip to content
Navigation Menu
{{ message }}
-
Notifications
You must be signed in to change notification settings - Fork 445
Unify general configuration and logging configuration #56
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
64106d0
to
ec700ed
Compare
ec700ed
to
66b7733
Compare
sczyh30
reviewed
Mar 7, 2020
66b7733
to
9ac2882
Compare
9ac2882
to
267b7d5
Compare
rearrange related code
267b7d5
to
6615673
Compare
sczyh30
approved these changes
Mar 10, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Nice work. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
You can’t perform that action at this time.
Describe what this PR does / why we need it
unify configuration
Describe how you did it
The priority is: env > yaml > default
That is say, yaml config will override default config and env config will override yaml config.
There is only one parameter "config path" for sentinel initialization. If user don't indicate config path, sentinel will use default config.
Unifying the constant to core/constant, including configuration、global constant variable.
FIX #42
Describe how to verify it
Special notes for reviews