| CARVIEW |
Select Language
HTTP/2 200
date: Sun, 27 Jul 2025 10:35:26 GMT
content-type: text/html; charset=utf-8
cache-control: no-cache
content-security-policy: default-src 'none'; base-uri 'self'; child-src github.githubassets.com github.com/assets-cdn/worker/ github.com/assets/ gist.github.com/assets-cdn/worker/; connect-src 'self' uploads.github.com www.githubstatus.com collector.github.com raw.githubusercontent.com api.github.com github-cloud.s3.amazonaws.com github-production-repository-file-5c1aeb.s3.amazonaws.com github-production-upload-manifest-file-7fdce7.s3.amazonaws.com github-production-user-asset-6210df.s3.amazonaws.com *.rel.tunnels.api.visualstudio.com wss://*.rel.tunnels.api.visualstudio.com objects-origin.githubusercontent.com copilot-proxy.githubusercontent.com proxy.individual.githubcopilot.com proxy.business.githubcopilot.com proxy.enterprise.githubcopilot.com *.actions.githubusercontent.com wss://*.actions.githubusercontent.com productionresultssa0.blob.core.windows.net/ productionresultssa1.blob.core.windows.net/ productionresultssa2.blob.core.windows.net/ productionresultssa3.blob.core.windows.net/ productionresultssa4.blob.core.windows.net/ productionresultssa5.blob.core.windows.net/ productionresultssa6.blob.core.windows.net/ productionresultssa7.blob.core.windows.net/ productionresultssa8.blob.core.windows.net/ productionresultssa9.blob.core.windows.net/ productionresultssa10.blob.core.windows.net/ productionresultssa11.blob.core.windows.net/ productionresultssa12.blob.core.windows.net/ productionresultssa13.blob.core.windows.net/ productionresultssa14.blob.core.windows.net/ productionresultssa15.blob.core.windows.net/ productionresultssa16.blob.core.windows.net/ productionresultssa17.blob.core.windows.net/ productionresultssa18.blob.core.windows.net/ productionresultssa19.blob.core.windows.net/ github-production-repository-image-32fea6.s3.amazonaws.com github-production-release-asset-2e65be.s3.amazonaws.com insights.github.com wss://alive.github.com api.githubcopilot.com api.individual.githubcopilot.com api.business.githubcopilot.com api.enterprise.githubcopilot.com; font-src github.githubassets.com; form-action 'self' github.com gist.github.com copilot-workspace.githubnext.com objects-origin.githubusercontent.com; frame-ancestors 'none'; frame-src viewscreen.githubusercontent.com notebooks.githubusercontent.com; img-src 'self' data: blob: github.githubassets.com media.githubusercontent.com camo.githubusercontent.com identicons.github.com avatars.githubusercontent.com private-avatars.githubusercontent.com github-cloud.s3.amazonaws.com objects.githubusercontent.com release-assets.githubusercontent.com secured-user-images.githubusercontent.com/ user-images.githubusercontent.com/ private-user-images.githubusercontent.com opengraph.githubassets.com copilotprodattachments.blob.core.windows.net/github-production-copilot-attachments/ github-production-user-asset-6210df.s3.amazonaws.com customer-stories-feed.github.com spotlights-feed.github.com objects-origin.githubusercontent.com *.githubusercontent.com; manifest-src 'self'; media-src github.com user-images.githubusercontent.com/ secured-user-images.githubusercontent.com/ private-user-images.githubusercontent.com github-production-user-asset-6210df.s3.amazonaws.com gist.github.com; script-src github.githubassets.com; style-src 'unsafe-inline' github.githubassets.com; upgrade-insecure-requests; worker-src github.githubassets.com github.com/assets-cdn/worker/ github.com/assets/ gist.github.com/assets-cdn/worker/
referrer-policy: no-referrer-when-downgrade
server-timing: pull_request_layout-fragment;desc="pull_request_layout fragment";dur=333.761057,conversation_content-fragment;desc="conversation_content fragment";dur=772.564538,conversation_sidebar-fragment;desc="conversation_sidebar fragment";dur=1001.198036,nginx;desc="NGINX";dur=0.800521,glb;desc="GLB";dur=100.927532
strict-transport-security: max-age=31536000; includeSubdomains; preload
vary: X-PJAX, X-PJAX-Container, Turbo-Visit, Turbo-Frame, X-Requested-With,Accept-Encoding, Accept, X-Requested-With
x-content-type-options: nosniff
x-frame-options: deny
x-voltron-version: a2eb102
x-xss-protection: 0
server: github.com
content-encoding: gzip
accept-ranges: bytes
set-cookie: _gh_sess=BimYzRaQFw82jw6Gp%2FBIQCEAnNVng24lfgrwsxqnohuToyxgIDG9TBJxNADO2xESSlUAhfnzQd4KfwY4ZZQ5yNsiDyybDLTuoACY9SyMQLebebJWTZwnu%2FM3ztTytnCjsIqxRJGquUYwuTo0c0IaCmF8ACVqxlsM3IfpfHQjFFi%2FS4nC6hy%2B11ZE5bsUij9f1ia5cCdJKitaZY0GMzNzKQ5fWyrw%2F0IOF6mDGyu8Io%2FNeMBrJkF%2BxJDCrrBXqo94WnQ07emg1oO1HyEVr5mjbA%3D%3D--dAw1UVITlplYNzLj--fH4VXHdi1Qo%2Bq34IMhyz%2FQ%3D%3D; Path=/; HttpOnly; Secure; SameSite=Lax
set-cookie: _octo=GH1.1.912108887.1753612525; Path=/; Domain=github.com; Expires=Mon, 27 Jul 2026 10:35:25 GMT; Secure; SameSite=Lax
set-cookie: logged_in=no; Path=/; Domain=github.com; Expires=Mon, 27 Jul 2026 10:35:25 GMT; HttpOnly; Secure; SameSite=Lax
x-github-request-id: BE2C:5FFA9:D5829C:119C4B4:688600ED
Improve Config API by louyuting · Pull Request #238 · alibaba/sentinel-golang · GitHub
louyuting
added
area/configuration
Issue related to configurations of Sentinel
to-review
PRs to review
labels
Sep 12, 2020
louyuting
force-pushed
the
20200911-refine-api
branch
from
September 15, 2020 15:32
Skip to content
Navigation Menu
{{ message }}
-
Notifications
You must be signed in to change notification settings - Fork 445
Improve Config API #238
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Improve Config API #238
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
louyuting
added
area/configuration
Codecov Report
@@ Coverage Diff @@
## master #238 +/- ##
==========================================
- Coverage 42.93% 42.53% -0.40%
==========================================
Files 74 74
Lines 4316 4356 +40
==========================================
Hits 1853 1853
- Misses 2230 2271 +41
+ Partials 233 232 -1
Continue to review full report at Codecov.
|
sczyh30
reviewed
Sep 14, 2020
sczyh30
reviewed
Sep 14, 2020
logging/logging.go
Outdated
| func init() { | ||
| defaultFileLogger, err := NewSimpleFileLogger(GetDefaultLogDir()+RecordLogFileName, DefaultNamespace, 0) | ||
| if err != nil { | ||
| globalLogger.Error("fail to init global file logger") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Carry with error message?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sure, updated
sczyh30
previously approved these changes
Sep 15, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
louyuting
force-pushed
the
20200911-refine-api
branch
from
0692b30 to
16ad305
Compare
sczyh30
approved these changes
Sep 16, 2020
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
You can’t perform that action at this time.
Describe what this PR does / why we need it
Improve sentinel initialization mechanism
Does this pull request fix one issue?
None
Describe how you did it
Describe how to verify it
UT
Special notes for reviews
@sczyh30