| CARVIEW |
Select Language
HTTP/2 200
date: Sat, 26 Jul 2025 23:50:15 GMT
content-type: text/html; charset=utf-8
cache-control: no-cache
content-security-policy: default-src 'none'; base-uri 'self'; child-src github.githubassets.com github.com/assets-cdn/worker/ github.com/assets/ gist.github.com/assets-cdn/worker/; connect-src 'self' uploads.github.com www.githubstatus.com collector.github.com raw.githubusercontent.com api.github.com github-cloud.s3.amazonaws.com github-production-repository-file-5c1aeb.s3.amazonaws.com github-production-upload-manifest-file-7fdce7.s3.amazonaws.com github-production-user-asset-6210df.s3.amazonaws.com *.rel.tunnels.api.visualstudio.com wss://*.rel.tunnels.api.visualstudio.com objects-origin.githubusercontent.com copilot-proxy.githubusercontent.com proxy.individual.githubcopilot.com proxy.business.githubcopilot.com proxy.enterprise.githubcopilot.com *.actions.githubusercontent.com wss://*.actions.githubusercontent.com productionresultssa0.blob.core.windows.net/ productionresultssa1.blob.core.windows.net/ productionresultssa2.blob.core.windows.net/ productionresultssa3.blob.core.windows.net/ productionresultssa4.blob.core.windows.net/ productionresultssa5.blob.core.windows.net/ productionresultssa6.blob.core.windows.net/ productionresultssa7.blob.core.windows.net/ productionresultssa8.blob.core.windows.net/ productionresultssa9.blob.core.windows.net/ productionresultssa10.blob.core.windows.net/ productionresultssa11.blob.core.windows.net/ productionresultssa12.blob.core.windows.net/ productionresultssa13.blob.core.windows.net/ productionresultssa14.blob.core.windows.net/ productionresultssa15.blob.core.windows.net/ productionresultssa16.blob.core.windows.net/ productionresultssa17.blob.core.windows.net/ productionresultssa18.blob.core.windows.net/ productionresultssa19.blob.core.windows.net/ github-production-repository-image-32fea6.s3.amazonaws.com github-production-release-asset-2e65be.s3.amazonaws.com insights.github.com wss://alive.github.com api.githubcopilot.com api.individual.githubcopilot.com api.business.githubcopilot.com api.enterprise.githubcopilot.com; font-src github.githubassets.com; form-action 'self' github.com gist.github.com copilot-workspace.githubnext.com objects-origin.githubusercontent.com; frame-ancestors 'none'; frame-src viewscreen.githubusercontent.com notebooks.githubusercontent.com; img-src 'self' data: blob: github.githubassets.com media.githubusercontent.com camo.githubusercontent.com identicons.github.com avatars.githubusercontent.com private-avatars.githubusercontent.com github-cloud.s3.amazonaws.com objects.githubusercontent.com release-assets.githubusercontent.com secured-user-images.githubusercontent.com/ user-images.githubusercontent.com/ private-user-images.githubusercontent.com opengraph.githubassets.com copilotprodattachments.blob.core.windows.net/github-production-copilot-attachments/ github-production-user-asset-6210df.s3.amazonaws.com customer-stories-feed.github.com spotlights-feed.github.com objects-origin.githubusercontent.com *.githubusercontent.com; manifest-src 'self'; media-src github.com user-images.githubusercontent.com/ secured-user-images.githubusercontent.com/ private-user-images.githubusercontent.com github-production-user-asset-6210df.s3.amazonaws.com gist.github.com; script-src github.githubassets.com; style-src 'unsafe-inline' github.githubassets.com; upgrade-insecure-requests; worker-src github.githubassets.com github.com/assets-cdn/worker/ github.com/assets/ gist.github.com/assets-cdn/worker/
referrer-policy: no-referrer-when-downgrade
server-timing: pull_request_layout-fragment;desc="pull_request_layout fragment";dur=384.99591,conversation_content-fragment;desc="conversation_content fragment";dur=1147.225437,conversation_sidebar-fragment;desc="conversation_sidebar fragment";dur=313.389096,nginx;desc="NGINX";dur=1.323861,glb;desc="GLB";dur=100.570748
strict-transport-security: max-age=31536000; includeSubdomains; preload
vary: X-PJAX, X-PJAX-Container, Turbo-Visit, Turbo-Frame, X-Requested-With,Accept-Encoding, Accept, X-Requested-With
x-content-type-options: nosniff
x-frame-options: deny
x-voltron-version: a2eb102
x-xss-protection: 0
server: github.com
content-encoding: gzip
accept-ranges: bytes
set-cookie: _gh_sess=L%2BH3NAMGiiIas0LtfaOStYfv3pLF7EB81pgDaIBmHKgJ%2F4WpZS10dX6My0nDlveH0MwEeYQXexS64PqRlLGno5%2BHX5jcRs2%2FxMVFM4I%2FjrHIJ6r6Mm%2FfyRdCMcgv6EEQAj%2BteBIm03AkcLskVJwI2TwAiloBs7vf5NjQVOs2Z7eG%2BCZTR5BF67g0yEtCBXbln7RsR%2FP3cIhjite%2Feql2sFSaWRDe5u218nKb5S7fIICISauwHfjffGAvLOJiVayGh6ZboCMylGSgYW60flSYzA%3D%3D--tM3Cpa3ravYtf5sf--eRDDwh4ZDnAvUBgxj%2FfqXw%3D%3D; Path=/; HttpOnly; Secure; SameSite=Lax
set-cookie: _octo=GH1.1.1595379453.1753573814; Path=/; Domain=github.com; Expires=Sun, 26 Jul 2026 23:50:14 GMT; Secure; SameSite=Lax
set-cookie: logged_in=no; Path=/; Domain=github.com; Expires=Sun, 26 Jul 2026 23:50:14 GMT; HttpOnly; Secure; SameSite=Lax
x-github-request-id: A0EE:93466:1D4FA:2FF0E:688569B6
Support arbitrary statistic interval for flow control && stat parameters configurable by louyuting · Pull Request #200 · alibaba/sentinel-golang · GitHub
louyuting
force-pushed
the
20200801-statistci-configurable
branch
from
August 4, 2020 16:39
sczyh30
added
area/flow-control
Issues or PRs related to flow control
kind/feature
Category issues or PRs related to feature request
size/XXL
Indicate a PR that changes 1000+ lines.
labels
Aug 5, 2020
louyuting
force-pushed
the
20200801-statistci-configurable
branch
2 times, most recently
from
August 6, 2020 14:29
louyuting
force-pushed
the
20200801-statistci-configurable
branch
from
August 12, 2020 15:47
louyuting
force-pushed
the
20200801-statistci-configurable
branch
4 times, most recently
from
August 23, 2020 04:44
louyuting
force-pushed
the
20200801-statistci-configurable
branch
from
August 25, 2020 12:19
louyuting
changed the title
Support arbitrary statistic interval for normal flow rule/stat parameters configurable/break down ControlBehavior
Support arbitrary statistic interval for flow control && stat parameters configurable
Sep 8, 2020
louyuting
force-pushed
the
20200801-statistci-configurable
branch
from
September 8, 2020 16:21
louyuting
force-pushed
the
20200801-statistci-configurable
branch
from
September 8, 2020 16:30
louyuting
force-pushed
the
20200801-statistci-configurable
branch
from
September 9, 2020 16:14
louyuting
force-pushed
the
20200801-statistci-configurable
branch
from
September 20, 2020 09:38
louyuting
force-pushed
the
20200801-statistci-configurable
branch
2 times, most recently
from
September 22, 2020 14:50
louyuting
force-pushed
the
20200801-statistci-configurable
branch
from
September 23, 2020 14:44
Skip to content
Navigation Menu
{{ message }}
-
Notifications
You must be signed in to change notification settings - Fork 445
Support arbitrary statistic interval for flow control && stat parameters configurable #200
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
sczyh30
merged 4 commits into
alibaba:master
from
louyuting:20200801-statistci-configurable
Sep 25, 2020
Merged
Support arbitrary statistic interval for flow control && stat parameters configurable #200
sczyh30
merged 4 commits into
alibaba:master
from
louyuting:20200801-statistci-configurable
Sep 25, 2020
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #200 +/- ##
==========================================
+ Coverage 41.89% 43.06% +1.17%
==========================================
Files 77 79 +2
Lines 3817 3994 +177
==========================================
+ Hits 1599 1720 +121
- Misses 1977 2009 +32
- Partials 241 265 +24
Continue to review full report at Codecov.
|
louyuting
force-pushed
the
20200801-statistci-configurable
branch
from
f28d2b9 to
bd7baec
Compare
sczyh30
added
area/flow-control
louyuting
force-pushed
the
20200801-statistci-configurable
branch
2 times, most recently
from
e9f2d77 to
77c9ad4
Compare
This was
linked to
issues
Aug 10, 2020
louyuting
force-pushed
the
20200801-statistci-configurable
branch
from
77c9ad4 to
5205051
Compare
|
@sczyh30 Could you please review this large PR? |
louyuting
force-pushed
the
20200801-statistci-configurable
branch
4 times, most recently
from
85dc2ce to
875060e
Compare
louyuting
force-pushed
the
20200801-statistci-configurable
branch
from
875060e to
444dfe2
Compare
binbin0325
reviewed
Aug 30, 2020
louyuting
changed the title
louyuting
force-pushed
the
20200801-statistci-configurable
branch
from
ede8121 to
2d2bf98
Compare
louyuting
force-pushed
the
20200801-statistci-configurable
branch
from
2d2bf98 to
854ed30
Compare
louyuting
commented
Sep 8, 2020
louyuting
force-pushed
the
20200801-statistci-configurable
branch
from
854ed30 to
05e9d1f
Compare
louyuting
force-pushed
the
20200801-statistci-configurable
branch
from
05e9d1f to
00ebf30
Compare
louyuting
force-pushed
the
20200801-statistci-configurable
branch
2 times, most recently
from
0b57285 to
cc1d73c
Compare
sczyh30
reviewed
Sep 22, 2020
|
And we may need to support the scenario when only one of sampleCount or intervalMs is provided (use the default value for another). |
louyuting
force-pushed
the
20200801-statistci-configurable
branch
from
fcb4269 to
79a18bf
Compare
sczyh30
requested changes
Sep 23, 2020
sczyh30
approved these changes
Sep 25, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
|
Awesome. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
area/flow-control
Issues or PRs related to flow control
kind/feature
Category issues or PRs related to feature request
size/XXL
Indicate a PR that changes 1000+ lines.
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
You can’t perform that action at this time.
Describe what this PR does / why we need it
Support arbitrary statistic interval for normal flow rule
stat parameters configurable
Does this pull request fix one issue?
Resolve
#129
#167
Describe how you did it
Support arbitrary statistic interval for normal flow rule
2.If user specifies StatisticConfig and meets the compliance of CheckValidityForReuseStatistic,
will build readonly metric statistic based on resource's global statistic.
3.If user specifies StatisticConfig and doesn't meet the compliance of CheckValidityForReuseStatistic,
will generate independent token bucket statistic for this rule.
Describe how to verify it
TODO
Special notes for reviews