| CARVIEW |
Select Language
HTTP/2 200
date: Sun, 27 Jul 2025 07:15:18 GMT
content-type: text/html; charset=utf-8
cache-control: no-cache
content-security-policy: default-src 'none'; base-uri 'self'; child-src github.githubassets.com github.com/assets-cdn/worker/ github.com/assets/ gist.github.com/assets-cdn/worker/; connect-src 'self' uploads.github.com www.githubstatus.com collector.github.com raw.githubusercontent.com api.github.com github-cloud.s3.amazonaws.com github-production-repository-file-5c1aeb.s3.amazonaws.com github-production-upload-manifest-file-7fdce7.s3.amazonaws.com github-production-user-asset-6210df.s3.amazonaws.com *.rel.tunnels.api.visualstudio.com wss://*.rel.tunnels.api.visualstudio.com objects-origin.githubusercontent.com copilot-proxy.githubusercontent.com proxy.individual.githubcopilot.com proxy.business.githubcopilot.com proxy.enterprise.githubcopilot.com *.actions.githubusercontent.com wss://*.actions.githubusercontent.com productionresultssa0.blob.core.windows.net/ productionresultssa1.blob.core.windows.net/ productionresultssa2.blob.core.windows.net/ productionresultssa3.blob.core.windows.net/ productionresultssa4.blob.core.windows.net/ productionresultssa5.blob.core.windows.net/ productionresultssa6.blob.core.windows.net/ productionresultssa7.blob.core.windows.net/ productionresultssa8.blob.core.windows.net/ productionresultssa9.blob.core.windows.net/ productionresultssa10.blob.core.windows.net/ productionresultssa11.blob.core.windows.net/ productionresultssa12.blob.core.windows.net/ productionresultssa13.blob.core.windows.net/ productionresultssa14.blob.core.windows.net/ productionresultssa15.blob.core.windows.net/ productionresultssa16.blob.core.windows.net/ productionresultssa17.blob.core.windows.net/ productionresultssa18.blob.core.windows.net/ productionresultssa19.blob.core.windows.net/ github-production-repository-image-32fea6.s3.amazonaws.com github-production-release-asset-2e65be.s3.amazonaws.com insights.github.com wss://alive.github.com api.githubcopilot.com api.individual.githubcopilot.com api.business.githubcopilot.com api.enterprise.githubcopilot.com; font-src github.githubassets.com; form-action 'self' github.com gist.github.com copilot-workspace.githubnext.com objects-origin.githubusercontent.com; frame-ancestors 'none'; frame-src viewscreen.githubusercontent.com notebooks.githubusercontent.com; img-src 'self' data: blob: github.githubassets.com media.githubusercontent.com camo.githubusercontent.com identicons.github.com avatars.githubusercontent.com private-avatars.githubusercontent.com github-cloud.s3.amazonaws.com objects.githubusercontent.com release-assets.githubusercontent.com secured-user-images.githubusercontent.com/ user-images.githubusercontent.com/ private-user-images.githubusercontent.com opengraph.githubassets.com copilotprodattachments.blob.core.windows.net/github-production-copilot-attachments/ github-production-user-asset-6210df.s3.amazonaws.com customer-stories-feed.github.com spotlights-feed.github.com objects-origin.githubusercontent.com *.githubusercontent.com; manifest-src 'self'; media-src github.com user-images.githubusercontent.com/ secured-user-images.githubusercontent.com/ private-user-images.githubusercontent.com github-production-user-asset-6210df.s3.amazonaws.com gist.github.com; script-src github.githubassets.com; style-src 'unsafe-inline' github.githubassets.com; upgrade-insecure-requests; worker-src github.githubassets.com github.com/assets-cdn/worker/ github.com/assets/ gist.github.com/assets-cdn/worker/
referrer-policy: no-referrer-when-downgrade
server-timing: pull_request_layout-fragment;desc="pull_request_layout fragment";dur=412.345365,conversation_content-fragment;desc="conversation_content fragment";dur=823.011728,conversation_sidebar-fragment;desc="conversation_sidebar fragment";dur=315.434187,nginx;desc="NGINX";dur=1.075761,glb;desc="GLB";dur=101.851839
strict-transport-security: max-age=31536000; includeSubdomains; preload
vary: X-PJAX, X-PJAX-Container, Turbo-Visit, Turbo-Frame, X-Requested-With,Accept-Encoding, Accept, X-Requested-With
x-content-type-options: nosniff
x-frame-options: deny
x-voltron-version: a2eb102
x-xss-protection: 0
server: github.com
content-encoding: gzip
accept-ranges: bytes
set-cookie: _gh_sess=%2BlNdbNMv7jHbrMpBHw3Geg4D2gblPseuRDZB8Y5XH1NX9CJIqRCCPKNkCZe91feH9dzhikzTucq0cm%2FJd%2FMF3%2F1KhgIxpgsl0qo%2BNCGAyx7TUtThx3RbnWUEXqyafV0Q9d0hEzwblptPBfZR1QFyYA3x90l4kPY6zgZ%2FcwdgsqC3j4g7kS5%2F%2B95PpCNWmwX%2Bhss4n6mAzHVhriFOLrdRucmNOCRaJld9H7mpEjVzjVzJ6ang80U25qib51mBi38mNYG8uwAyO%2FoOzS309HRl8A%3D%3D--tEt7WCp8tY%2F4mUSl--%2BY8cQUF7xi7bnSuexubGqQ%3D%3D; Path=/; HttpOnly; Secure; SameSite=Lax
set-cookie: _octo=GH1.1.869243050.1753600517; Path=/; Domain=github.com; Expires=Mon, 27 Jul 2026 07:15:17 GMT; Secure; SameSite=Lax
set-cookie: logged_in=no; Path=/; Domain=github.com; Expires=Mon, 27 Jul 2026 07:15:17 GMT; HttpOnly; Secure; SameSite=Lax
x-github-request-id: DFB0:3B05D7:BB7AF8:F9697C:6885D205
Improve all rule checking slots with standard BlockError representation by sczyh30 · Pull Request #187 · alibaba/sentinel-golang · GitHub
Skip to content
Navigation Menu
{{ message }}
-
Notifications
You must be signed in to change notification settings - Fork 445
Improve all rule checking slots with standard BlockError representation #187
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Eric Zhao <sczyh16@gmail.com>
Codecov Report
@@ Coverage Diff @@
## master #187 +/- ##
==========================================
- Coverage 44.81% 44.70% -0.11%
==========================================
Files 80 80
Lines 4432 4438 +6
==========================================
- Hits 1986 1984 -2
- Misses 2219 2227 +8
Partials 227 227
Continue to review full report at Codecov.
|
louyuting
reviewed
Jul 27, 2020
louyuting
reviewed
Jul 27, 2020
| @@ -34,7 +34,7 @@ func (c *ThrottlingChecker) DoCheck(_ base.StatNode, acquireCount uint32, thresh | |||
| return nil | |||
| } | |||
| if threshold <= 0 { | |||
| return base.NewTokenResultBlocked(base.BlockTypeFlow, "Flow") | |||
| return base.NewTokenResultBlocked(base.BlockTypeFlow) | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe we need to carry the triggered rule?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, the design regarding tc_throttling.go should be improved.
Signed-off-by: Eric Zhao <sczyh16@gmail.com>
louyuting
approved these changes
Jul 28, 2020
louyuting
approved these changes
Jul 28, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
You can’t perform that action at this time.
Signed-off-by: Eric Zhao sczyh16@gmail.com
Describe what this PR does / why we need it
Improve all rule checking slots with standard
BlockErrorrepresentation.Does this pull request fix one issue?
NONE
Describe how you did it
This PR follows a simple BlockError specification:
Error()SHOULD start withSentinelBlockError: ${blockType}. If block message is provided, append it to theError()value. TheblockMsgis not required.BlockError.This PR improves all rule checking slots with more standard
BlockErrorrepresentation.Describe how to verify it
Run the test cases.
Special notes for reviews
NONE