| CARVIEW |
Select Language
HTTP/2 200
date: Sat, 26 Jul 2025 23:50:27 GMT
content-type: text/html; charset=utf-8
cache-control: no-cache
content-security-policy: default-src 'none'; base-uri 'self'; child-src github.githubassets.com github.com/assets-cdn/worker/ github.com/assets/ gist.github.com/assets-cdn/worker/; connect-src 'self' uploads.github.com www.githubstatus.com collector.github.com raw.githubusercontent.com api.github.com github-cloud.s3.amazonaws.com github-production-repository-file-5c1aeb.s3.amazonaws.com github-production-upload-manifest-file-7fdce7.s3.amazonaws.com github-production-user-asset-6210df.s3.amazonaws.com *.rel.tunnels.api.visualstudio.com wss://*.rel.tunnels.api.visualstudio.com objects-origin.githubusercontent.com copilot-proxy.githubusercontent.com proxy.individual.githubcopilot.com proxy.business.githubcopilot.com proxy.enterprise.githubcopilot.com *.actions.githubusercontent.com wss://*.actions.githubusercontent.com productionresultssa0.blob.core.windows.net/ productionresultssa1.blob.core.windows.net/ productionresultssa2.blob.core.windows.net/ productionresultssa3.blob.core.windows.net/ productionresultssa4.blob.core.windows.net/ productionresultssa5.blob.core.windows.net/ productionresultssa6.blob.core.windows.net/ productionresultssa7.blob.core.windows.net/ productionresultssa8.blob.core.windows.net/ productionresultssa9.blob.core.windows.net/ productionresultssa10.blob.core.windows.net/ productionresultssa11.blob.core.windows.net/ productionresultssa12.blob.core.windows.net/ productionresultssa13.blob.core.windows.net/ productionresultssa14.blob.core.windows.net/ productionresultssa15.blob.core.windows.net/ productionresultssa16.blob.core.windows.net/ productionresultssa17.blob.core.windows.net/ productionresultssa18.blob.core.windows.net/ productionresultssa19.blob.core.windows.net/ github-production-repository-image-32fea6.s3.amazonaws.com github-production-release-asset-2e65be.s3.amazonaws.com insights.github.com wss://alive.github.com api.githubcopilot.com api.individual.githubcopilot.com api.business.githubcopilot.com api.enterprise.githubcopilot.com; font-src github.githubassets.com; form-action 'self' github.com gist.github.com copilot-workspace.githubnext.com objects-origin.githubusercontent.com; frame-ancestors 'none'; frame-src viewscreen.githubusercontent.com notebooks.githubusercontent.com; img-src 'self' data: blob: github.githubassets.com media.githubusercontent.com camo.githubusercontent.com identicons.github.com avatars.githubusercontent.com private-avatars.githubusercontent.com github-cloud.s3.amazonaws.com objects.githubusercontent.com release-assets.githubusercontent.com secured-user-images.githubusercontent.com/ user-images.githubusercontent.com/ private-user-images.githubusercontent.com opengraph.githubassets.com copilotprodattachments.blob.core.windows.net/github-production-copilot-attachments/ github-production-user-asset-6210df.s3.amazonaws.com customer-stories-feed.github.com spotlights-feed.github.com objects-origin.githubusercontent.com *.githubusercontent.com; manifest-src 'self'; media-src github.com user-images.githubusercontent.com/ secured-user-images.githubusercontent.com/ private-user-images.githubusercontent.com github-production-user-asset-6210df.s3.amazonaws.com gist.github.com; script-src github.githubassets.com; style-src 'unsafe-inline' github.githubassets.com; upgrade-insecure-requests; worker-src github.githubassets.com github.com/assets-cdn/worker/ github.com/assets/ gist.github.com/assets-cdn/worker/
referrer-policy: no-referrer-when-downgrade
server-timing: pull_request_layout-fragment;desc="pull_request_layout fragment";dur=242.033737,conversation_content-fragment;desc="conversation_content fragment";dur=878.327324,conversation_sidebar-fragment;desc="conversation_sidebar fragment";dur=233.253685,nginx;desc="NGINX";dur=1.277325,glb;desc="GLB";dur=101.797334
strict-transport-security: max-age=31536000; includeSubdomains; preload
vary: X-PJAX, X-PJAX-Container, Turbo-Visit, Turbo-Frame, X-Requested-With,Accept-Encoding, Accept, X-Requested-With
x-content-type-options: nosniff
x-frame-options: deny
x-voltron-version: a2eb102
x-xss-protection: 0
server: github.com
content-encoding: gzip
accept-ranges: bytes
set-cookie: _gh_sess=%2FwLGaw%2FP0yt2%2BwQGPGU%2Bzzv7Srd0ckBHeCOmCXgC83gotbChuWUy%2FZ%2BPZuXstOlMSldwXYipTefHg%2FDPEpNebPyECyDj5UtlBSKuiBJrJjgVu4HwL7aUavvY2iVH1QqfD1lyqSNWmNJ6nL%2FrRkMjyhFnnBT4rDPMOcCvSUjsadSfwwXaZ8xYP6qUF7OIIZaYCAcCYY%2BKBn%2BXbOy3MXNz3w04p3YJOg%2FwPHfGbXOlLh7bfkfiW1I3lvpzYU%2BcGv%2BvlnelVzqbrBUyo7Z6gL4Ysw%3D%3D--vIJPyXQze35m4YJA--Zkyc%2B68OVgdNyvdlP%2B8%2FAw%3D%3D; Path=/; HttpOnly; Secure; SameSite=Lax
set-cookie: _octo=GH1.1.2108108779.1753573827; Path=/; Domain=github.com; Expires=Sun, 26 Jul 2026 23:50:27 GMT; Secure; SameSite=Lax
set-cookie: logged_in=no; Path=/; Domain=github.com; Expires=Sun, 26 Jul 2026 23:50:27 GMT; HttpOnly; Secure; SameSite=Lax
x-github-request-id: 8FC6:29FD1F:9794D0:C75B00:688569C2
Nacos datasource by binbin0325 · Pull Request #184 · alibaba/sentinel-golang · GitHub
sczyh30
added
the
area/data-source
Issues or PRs related to data-source extension
label
Jul 13, 2020
Skip to content
Navigation Menu
{{ message }}
-
Notifications
You must be signed in to change notification settings - Fork 445
Nacos datasource #184
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Nacos datasource #184
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
sczyh30
added
the
area/data-source
Codecov Report
@@ Coverage Diff @@
## master #184 +/- ##
==========================================
+ Coverage 44.47% 44.81% +0.33%
==========================================
Files 76 80 +4
Lines 4209 4432 +223
==========================================
+ Hits 1872 1986 +114
- Misses 2132 2219 +87
- Partials 205 227 +22
Continue to review full report at Codecov.
|
louyuting
requested changes
Jul 15, 2020
louyuting
reviewed
Jul 20, 2020
louyuting
reviewed
Jul 20, 2020
louyuting
reviewed
Jul 20, 2020
louyuting
reviewed
Jul 20, 2020
louyuting
reviewed
Jul 20, 2020
|
Hi @sanxun0325 |
|
@louyuting I understand your idea, and I will modify it according to your suggestion.thank you. |
louyuting
previously approved these changes
Jul 21, 2020
sczyh30
reviewed
Jul 22, 2020
ext/datasource/nacos/nacos.go
Outdated
| closeChan chan struct{} | ||
| } | ||
|
|
||
| func NewNacosDataSource(client config_client.IConfigClient, propertyConfig vo.ConfigParam, handlers ...datasource.PropertyHandler) (*NacosDataSource, error) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe we could just replace vo.ConfigParam with dataId and groupId here? Using vo.ConfigParam might be confusing (e.g. the listener function inside the config is not actually used).
…NacosDataSource()
sczyh30
approved these changes
Jul 22, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
|
Thanks for contributing! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
You can’t perform that action at this time.
Describe what this PR does / why we need it
Add nacos datasource.
Does this pull request fix one issue?
Fixes #62
Describe how you did it
Implement dataSource interface.Get the remote configuration using https://github.com/nacos-group/nacos-sdk-go
Describe how to verify it
Execute unit tests.
Special notes for reviews