Fix fixed pointer size problem in AtomicBucketWrapArray to support 32-bit OS (#429)

binbin0325 · web-flow · commit ace810bc3806 · 2021-09-22T10:09:54.000+08:00
diff --git a/core/stat/base/leap_array.go b/core/stat/base/leap_array.go
@@ -26,10 +26,6 @@ import (
 	"github.com/pkg/errors"
 )
 
-const (
-	PtrSize = int(8)
-)
-
 // BucketWrap represent a slot to record metrics
 // In order to reduce the usage of memory, BucketWrap don't hold length of BucketWrap
 // The length of BucketWrap could be seen in LeapArray.
@@ -115,7 +111,7 @@ func (aa *AtomicBucketWrapArray) elementOffset(idx int) (unsafe.Pointer, bool) {
 		return nil, false
 	}
 	basePtr := aa.base
-	return unsafe.Pointer(uintptr(basePtr) + uintptr(idx*PtrSize)), true
+	return unsafe.Pointer(uintptr(basePtr) + uintptr(idx)*unsafe.Sizeof(basePtr)), true
 }
 
 func (aa *AtomicBucketWrapArray) get(idx int) *BucketWrap {

Original file line number	Diff line number	Diff line change
`@@ -26,10 +26,6 @@ import (`
`26`	`26`	`"github.com/pkg/errors"`
`27`	`27`	`)`
`28`	`28`
`29`		`-const (`
`30`		`- PtrSize = int(8)`
`31`		`-)`
`32`		`-`
`33`	`29`	`// BucketWrap represent a slot to record metrics`
`34`	`30`	`// In order to reduce the usage of memory, BucketWrap don't hold length of BucketWrap`
`35`	`31`	`// The length of BucketWrap could be seen in LeapArray.`
`@@ -115,7 +111,7 @@ func (aa *AtomicBucketWrapArray) elementOffset(idx int) (unsafe.Pointer, bool) {`
`115`	`111`	`return nil, false`
`116`	`112`	`}`
`117`	`113`	`basePtr := aa.base`
`118`		`- return unsafe.Pointer(uintptr(basePtr) + uintptr(idx*PtrSize)), true`
	`114`	`+ return unsafe.Pointer(uintptr(basePtr) + uintptr(idx)*unsafe.Sizeof(basePtr)), true`
`119`	`115`	`}`
`120`	`116`
`121`	`117`	`func (aa AtomicBucketWrapArray) get(idx int) BucketWrap {`