CARVIEW |
Select Language
HTTP/2 200
date: Sat, 19 Jul 2025 11:31:55 GMT
content-type: text/html; charset=utf-8
vary: X-PJAX, X-PJAX-Container, Turbo-Visit, Turbo-Frame, X-Requested-With,Accept-Encoding, Accept, X-Requested-With
x-repository-download: git clone https://github.com/aeron-io/simple-binary-encoding.git
etag: W/"55c9c85099a332b45da4e572a2dd75be"
cache-control: max-age=0, private, must-revalidate
strict-transport-security: max-age=31536000; includeSubdomains; preload
x-frame-options: deny
x-content-type-options: nosniff
x-xss-protection: 0
referrer-policy: no-referrer-when-downgrade
content-security-policy: default-src 'none'; base-uri 'self'; child-src github.githubassets.com github.com/assets-cdn/worker/ github.com/assets/ gist.github.com/assets-cdn/worker/; connect-src 'self' uploads.github.com www.githubstatus.com collector.github.com raw.githubusercontent.com api.github.com github-cloud.s3.amazonaws.com github-production-repository-file-5c1aeb.s3.amazonaws.com github-production-upload-manifest-file-7fdce7.s3.amazonaws.com github-production-user-asset-6210df.s3.amazonaws.com *.rel.tunnels.api.visualstudio.com wss://*.rel.tunnels.api.visualstudio.com objects-origin.githubusercontent.com copilot-proxy.githubusercontent.com proxy.individual.githubcopilot.com proxy.business.githubcopilot.com proxy.enterprise.githubcopilot.com *.actions.githubusercontent.com wss://*.actions.githubusercontent.com productionresultssa0.blob.core.windows.net/ productionresultssa1.blob.core.windows.net/ productionresultssa2.blob.core.windows.net/ productionresultssa3.blob.core.windows.net/ productionresultssa4.blob.core.windows.net/ productionresultssa5.blob.core.windows.net/ productionresultssa6.blob.core.windows.net/ productionresultssa7.blob.core.windows.net/ productionresultssa8.blob.core.windows.net/ productionresultssa9.blob.core.windows.net/ productionresultssa10.blob.core.windows.net/ productionresultssa11.blob.core.windows.net/ productionresultssa12.blob.core.windows.net/ productionresultssa13.blob.core.windows.net/ productionresultssa14.blob.core.windows.net/ productionresultssa15.blob.core.windows.net/ productionresultssa16.blob.core.windows.net/ productionresultssa17.blob.core.windows.net/ productionresultssa18.blob.core.windows.net/ productionresultssa19.blob.core.windows.net/ github-production-repository-image-32fea6.s3.amazonaws.com github-production-release-asset-2e65be.s3.amazonaws.com insights.github.com wss://alive.github.com api.githubcopilot.com api.individual.githubcopilot.com api.business.githubcopilot.com api.enterprise.githubcopilot.com; font-src github.githubassets.com; form-action 'self' github.com gist.github.com copilot-workspace.githubnext.com objects-origin.githubusercontent.com; frame-ancestors 'none'; frame-src viewscreen.githubusercontent.com notebooks.githubusercontent.com; img-src 'self' data: blob: github.githubassets.com media.githubusercontent.com camo.githubusercontent.com identicons.github.com avatars.githubusercontent.com private-avatars.githubusercontent.com github-cloud.s3.amazonaws.com objects.githubusercontent.com release-assets.githubusercontent.com secured-user-images.githubusercontent.com/ user-images.githubusercontent.com/ private-user-images.githubusercontent.com opengraph.githubassets.com copilotprodattachments.blob.core.windows.net/github-production-copilot-attachments/ github-production-user-asset-6210df.s3.amazonaws.com customer-stories-feed.github.com spotlights-feed.github.com objects-origin.githubusercontent.com *.githubusercontent.com; manifest-src 'self'; media-src github.com user-images.githubusercontent.com/ secured-user-images.githubusercontent.com/ private-user-images.githubusercontent.com github-production-user-asset-6210df.s3.amazonaws.com gist.github.com; script-src github.githubassets.com; style-src 'unsafe-inline' github.githubassets.com; upgrade-insecure-requests; worker-src github.githubassets.com github.com/assets-cdn/worker/ github.com/assets/ gist.github.com/assets-cdn/worker/
server: github.com
content-encoding: gzip
accept-ranges: bytes
set-cookie: _gh_sess=1m9qxz34ODuZHq5%2FRnVkJikKiaCPIM6a1JG7K%2BKv6NOwpxGmwxWhMh%2FNzIIC7FDcsUP9A0kMh%2B0vlmO2cNKTqrKalAwz1m6iAK1K1I1UBcvKXSWgywtVVBZBembg%2F9Cj30HDUPZ9dcmrobkYGp%2F6KkUI9PWBhM1%2F3IY5fFbg720tuE1wOI79EIk1UzBQ7SVNOUPyVVWB3EqC2ZrJgZpVzZPIEKPvt8mCMK3IFXfU8gz%2FSlWXAzL5PVUfh5elJ37pr%2FnDRuxcjzZpjsJOvXJbjQ%3D%3D--xy98TN6U07j6WcfG--BYZTrz6jR5ChXexlZ%2B9Pww%3D%3D; Path=/; HttpOnly; Secure; SameSite=Lax
set-cookie: _octo=GH1.1.931250733.1752924714; Path=/; Domain=github.com; Expires=Sun, 19 Jul 2026 11:31:54 GMT; Secure; SameSite=Lax
set-cookie: logged_in=no; Path=/; Domain=github.com; Expires=Sun, 19 Jul 2026 11:31:54 GMT; HttpOnly; Secure; SameSite=Lax
x-github-request-id: AE50:20F01E:42A2A1:53C70B:687B822A
[C#] Fix repeated group buffer overflow (#823) · aeron-io/simple-binary-encoding@4437ae5 · GitHub
Copy file name to clipboardExpand all lines: sbe-tool/src/main/java/uk/co/real_logic/sbe/generation/csharp/CSharpGenerator.java
Skip to content
Navigation Menu
{{ message }}
-
Notifications
You must be signed in to change notification settings - Fork 542
Commit 4437ae5
authored
[C#] Fix repeated group buffer overflow (#823)
On a repeated group in the WrapForEncode, the parentMessage.Limit has two purposes:
1. It is used as a buffer offset for the _dimensions helper Wrap method
2. The assignment to it has a side effect of checking that we do not exceed the underlying DirectBuffer's capacity
However notice that currently this assignment happens after writing to the _dimensions helper properties BlockLength and NumInGroup,
i.e. the writes are done *before* we check for buffer overflow.
Underneath these are direct writes to the byte* managed by the DirectBuffer, resulting in an unchecked, unsafe buffer overflow.
To fix this the Limit has to be increased right after the call to the _dimensions.Wrap, before writes to BlockLength and NumInGroup
The same occurs in the Decode method, only reading unsafe, invalid memory instead of writing to it.
Also fixed _actingVersion was being used before it's assigned in the Encode1 parent 627b450 commit 4437ae5Copy full SHA for 4437ae5
File tree
Expand file treeCollapse file tree
1 file changed
+3
-3
lines changedFilter options
- sbe-tool/src/main/java/uk/co/real_logic/sbe/generation/csharp
Expand file treeCollapse file tree
1 file changed
+3
-3
lines changedsbe-tool/src/main/java/uk/co/real_logic/sbe/generation/csharp/CSharpGenerator.java
Copy file name to clipboardExpand all lines: sbe-tool/src/main/java/uk/co/real_logic/sbe/generation/csharp/CSharpGenerator.java+3-3Lines changed: 3 additions & 3 deletions
Original file line number | Diff line number | Diff line change | |
---|---|---|---|
| |||
207 | 207 |
| |
208 | 208 |
| |
209 | 209 |
| |
| 210 | + | |
210 | 211 |
| |
211 | 212 |
| |
212 | 213 |
| |
213 | 214 |
| |
214 |
| - | |
215 | 215 |
| |
216 | 216 |
| |
217 | 217 |
| |
| |||
232 | 232 |
| |
233 | 233 |
| |
234 | 234 |
| |
235 |
| - | |
| 235 | + | |
| 236 | + | |
236 | 237 |
| |
237 | 238 |
| |
238 | 239 |
| |
239 | 240 |
| |
240 | 241 |
| |
241 | 242 |
| |
242 |
| - | |
243 | 243 |
| |
244 | 244 |
| |
245 | 245 |
| |
|
You can’t perform that action at this time.
0 commit comments