You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository was archived by the owner on Sep 2, 2021. It is now read-only.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Similar work to the one in Brackets.
I've added a .bracket.json file so I could change the prefered linter. (And remove the inline jslint declarations)
I've added an .eslint.json file under tasks/ because Grunt isn't compatible with the rule no-invalid-this.
There should not be any change in behaviour.
Yep, but even requiring them can have side-effects, like parts of the module being executed, event listeners attached and so on. Are you sure not requiring them won't break anything? Instead of server = require("./Server") you can do just require("./Server"); to be sure nothing breaks.
@ficristo I tried playing with this branch. There is one side effect because of this change. After building brackets-shell with this branch and opening brackets-shell source folder, with the built shell, JS hints don't appear anymore.
The below snapshot is with the shell built from the release branch.
Also I have observed that if I open any file under node-core with any other project, JSHints kick in.
I cannot replicate the issue on the node-core side.
As of now there is a newer version of ESLint which will rise some more warnings and would like to update to it.
But before can we get a consensus on what to do with these: adobe/brackets#11984 adobe/brackets#11988
(For not seeing JSLint anymore: we need the ESLint extension in core or I need to reenable JSLint like I did on Brackets side)
I've reintroduced JSLint so we can merge this.
I removed the IIFE and so deindented the code, that's why you see a lot of changes.
You can look at this link https://github.com/adobe/brackets-shell/pull/542/files?w=1 to see code changes only.
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
None yet
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Similar work to the one in Brackets.
I've added a
.bracket.json
file so I could change the prefered linter. (And remove the inline jslint declarations)I've added an
.eslint.json
file undertasks/
because Grunt isn't compatible with the ruleno-invalid-this
.There should not be any change in behaviour.