You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository was archived by the owner on Sep 2, 2021. It is now read-only.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently when Brackets launches live preview (for the first time), it uses a new profile. Chrome then proceeds to install the default Chrome apps (Youtube, Gmail, Google Search, Web Store, Google Docs...) for the said user. This can create situations like described in adobe/brackets#11617.
This PR adds --disable-default-apps-flag for remote debugging arguments, which disables that said behaviour. (Plus it could/should make the first live preview experience a tad bit faster 🔥)
@petetnt Thanks for investigating this issue and fixing it as well! Did you get a chance to run unit tests with this PR. If all the tests are passing, then we are good to go with this PR 👍
@nethip, successfully ran all the LivePreview related tests.
However some instability because I am building the binary with Visual Studio 2013... GetVersionEx is deprecated -> it won't compile even with turning Treat Warnings as Errors (/WX) off (/WX-) so I had to hack around those which might be the cause (running the tests against brackets#master + brackets-shell#master randomly fails tests too). 😔
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
None yet
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes adobe/brackets#11617.
Currently when Brackets launches live preview (for the first time), it uses a new profile. Chrome then proceeds to install the default Chrome apps (Youtube, Gmail, Google Search, Web Store, Google Docs...) for the said user. This can create situations like described in adobe/brackets#11617.
This PR adds
--disable-default-apps
-flag for remote debugging arguments, which disables that said behaviour. (Plus it could/should make the first live preview experience a tad bit faster 🔥)