You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository was archived by the owner on Sep 2, 2021. It is now read-only.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I was able to compile and run this on my 14.10 VM (32 Bit). Looks good so far.
Please try to delete the out folder and rebuild with grunt build. That helped on my machine.
We can use the fileTypes parameter and set the filter with https://www.geany.org/manual/gtk/gtk/GtkFileChooser.html#gtk-file-chooser-set-filter. This sounds like a good use of it.
I still wasn't able to compile this on my 14.10 VM (32 Bit), even though I ran git clean and started the setup from ground up.
I'm also not too experienced with native code and that's why I honestly don't know how to implement fileTypes. It looks like right now, it's not even implemented on Windows, so the param is quite useless anyway. Also, I don't know how an array on the JavaScript site can be converted to an ExtensionString on the native site.
@ingorichter As you managed building it, could you just make sure that running showOpenDialog with an undefined title still shows some default title?
@marcelgerber let me check tomorrow if we have any occurrences where we pass fileTypes to this function. Otherwise we can omit the implementation. But if this isn't implemented on Windows, I guess that we are not using it anywhere. I think we shouldn't change the function signature, but add a comment to the functions to make clear, that there is currently no need to support this feature. I assume, that the original plan to implement this feature was driven by the observations what the open/save dialogs provide for each platform. Since you can have this file filter functionality on all supported platforms, the engineer who implemented this was preparing for a possible use of it.
I'm going to check the behavior with an undefined title argument.
Passing undefined or null for the title results in the default title Open. This is totally fine to move forward. Let's get the one comment resolved and then we can merge it.
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
None yet
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For adobe/brackets#10297
I weren't able to build this due to various errors (in a Ubuntu 14.10 VM), not even on top of the
linux-1547
branch.I also don't know what to do with
fileTypes
- it currently doesn't work either.