You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository was archived by the owner on Sep 2, 2021. It is now read-only.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This should be checked on Multiple Monitors as a fair amount of work went in to finding the right solution for multiple monitors.
Make sure the Maximized size on a monitor without a task bar is the whole monitor
Make sure the Maximized size on a monitor with a task bar that is not auto-hide works (top/left/bottom/right)
Make sure that the Maximized size on both monitors is respected if the task bar is shown on all monitors (left/top/bottom/right)
Make sure that the window adjusts itself when the app bar position or auto-hide flag changes while the app is running.
Make sure that the size placement accommodates for a hidden Windows task bar if its state was not hidden when brackets saved the window placement data and is restarted with a hidden windows taskbar
Make sure the app adjusts itself when changing the placement of the taskbar
Make sure the app adjusts itself when changing the auto-hide state
You will notice a 1px area between the app and the taskbar. This is the taskbar and typical of all apps to give the taskbar an edge to grab. It IS more apparent with a dark border which gives the 1px line a little more contrast and makes it more visible.
The reason will be displayed to describe this comment to others. Learn more.
I'm still seeing this line indented with spaces and the rest of the function is indented with Tabs. I know there's a mix of spaces vs tabs in code base, and even in some files, but I think it should at least be consistent in each function/method.
Sorry, for already saying it was ok to squash, but I realized that I didn't try all of the testing recommendations and I now notice a nasty bug:
Set taskbar on primary monitor (either show or auto-hide)
Drag Brackets window to secondary monitor and Maxmize
Results
Window is not correctly sized. Top and left are correct, but height is really short (~100px) and width is too wide. Upper-right buttons are off the screen -- need to double-click on header to Restore window.
UPDATE: This seems to be related to my secondary monitor setup (it's above primary). If I move secondary monitor to the right of primary and problem goes away. See screen shot for my setup:
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
None yet
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is for: adobe/brackets#7555
This replaces: #471
Place the task bar on:
Test with both auto hide and always visible.
This should be checked on Multiple Monitors as a fair amount of work went in to finding the right solution for multiple monitors.
You will notice a 1px area between the app and the taskbar. This is the taskbar and typical of all apps to give the taskbar an edge to grab. It IS more apparent with a dark border which gives the 1px line a little more contrast and makes it more visible.