You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository was archived by the owner on Sep 2, 2021. It is now read-only.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This started as an innovation week project to fix some of the issues with the Dark Shell by using the Desktop Window Manager to extend the client area the full size of the window.
This fixes a number of non-client area drawing since the system is no longer drawing the non-client area at all but front and center is the fix that extends the window frame onto secondary monitors.
The issues marked UTR on XP just means that I did nothing to fix this expressly for XP -- Likely reasons why:
The problem is intermittent and my tests didn't reveal a reproducible case
The problem occurs when system settings are changed which are affect how the system wants Brackets to draw itself like Large Fonts or Thicker borders, etc...
The problem does not happen on an XP VM on a Mac
Or, hopefully, fixed with the other changes to make Dark Aero Glass work
For those issues we just need to record that in the bug notes so that the filer can test and let us know if it's truly fixed or not so we can move to the next level of trying to better understand why or convince Jonathon to drop support for XP.
Special thanks to @bchintx for helping implement the DLL wrapper for the Windows Desktop Window Manager and with Testing.
I've also reviewed the above-listed bugs on both my Win7 and WinXP (VM) and all issues appear to be fixed: 5323 - no border bleed on 2nd monitor in Win7. I don't have a native WinXP machine to confirm the same there. 5243 - I'm not seeing a problem on Win7 5288 - I was able to reproduce this prior to @JeffryBooher's last commit. However, it's fixed now. 5480 - not seeing the tooltip with the latest build 5727 and 6185 - icon fits maximized caption bar in both XP and Win7
Ready to merge pending confirmation from @peterflynn who's also testing on a native WinXP machine.
@bchintx@peterflynn Just to be clear -- the border bleed onto a secondary monitor is not fixed for Windows XP. The solution was to use Aero Glass which is not available on XP.
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
None yet
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This started as an innovation week project to fix some of the issues with the Dark Shell by using the Desktop Window Manager to extend the client area the full size of the window.
This fixes a number of non-client area drawing since the system is no longer drawing the non-client area at all but front and center is the fix that extends the window frame onto secondary monitors.
The following issues are fixed with this:
adobe/brackets#5323
adobe/brackets#6185
adobe/brackets#5727 (NOTE: I was UTR on XP)
adobe/brackets#5480 (NOTE: This still occurs on XP but no longer on Vista, 7 and 8)
adobe/brackets#5288 (NOTE: I was UTR on XP)
adobe/brackets#5243 (NOTE: I was UTR on XP)
The issues marked UTR on XP just means that I did nothing to fix this expressly for XP -- Likely reasons why:
For those issues we just need to record that in the bug notes so that the filer can test and let us know if it's truly fixed or not so we can move to the next level of trying to better understand why or convince Jonathon to drop support for XP.
Special thanks to @bchintx for helping implement the DLL wrapper for the Windows Desktop Window Manager and with Testing.