You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository was archived by the owner on Sep 2, 2021. It is now read-only.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixed the linux getMenuParent to return the correct parent of the menu
Fixed AddMenu and AddMenuItem to show the added menu/item
Menus now render natively when Global.js allows, however commands are not yet attached and the API is still not implemented properly. All this includes so far is fixes to make it work at the most basic level.
Note: I'm learning GTK and C especially for this, so I might need a little bit of hand holding with the NativeMenuModel integration. I'll try to look into that soonish, but let me know if anyone else is working on it already :)
@MattSturgeon F.Y.I.: I did a lot of work related to the native menues in this branch irichter/native-menues-linux. There is some cleanup required to make this production ready, but I basically integrated the NativeMenuModel already.
I did some work on native menus as well (including the integration of NativeMenuModel). Is there somewhere a list of who is working on what because I find this duplication of work quite frustrating.
Thank you to all contributors on getting the native menus working on Linux. I'm sorry to hear, that there was duplicated effort to get this implemented.
I posted a proposal to the forum to resolve this kind of situations.
@JeffryBooher let me check this PR. My branch had some merge issues with master and I had no time this week to resolve them. Since we released Brackets, I will have a look again and get the conflicts resolved.
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
None yet
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
getMenuParent
to return the correct parent of the menuAddMenu
andAddMenuItem
to show the added menu/itemMenus now render natively when
Global.js
allows, however commands are not yet attached and the API is still not implemented properly. All this includes so far is fixes to make it work at the most basic level.Note: I'm learning GTK and C especially for this, so I might need a little bit of hand holding with the NativeMenuModel integration. I'll try to look into that soonish, but let me know if anyone else is working on it already :)