You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository was archived by the owner on Sep 2, 2021. It is now read-only.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I like the idea of using g_file_trash(). I've submitted some code for the same function in another PR but it's much more lower level C code and will only work with the Ubuntu trash. Using g_file_trash() there is more likely a chance that it will work with trash on other distros. If someone could test on a non-Ubuntu flavor that would be great.
Looks good and tested on Ubuntu 13 64-bit after merging with master locally.
If I understand my libraries right...GIO is part of GLib. Since we require this in our debian package control file as a dependency, and presumably will require it for other distributions (Fedora is probably next), this should work across distributions right?
@eyelash it doesn't matter much currently since we don't have support for other distros yet. If you happen to know if this works on Fedora, just leave a note here.
GTK+ depends on GLib so every distribution that has GTK+ also has GLib. I don't use fedora but I'm quite sure this solution works for most of the distributions.
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
None yet
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I tested (on Ubuntu 13.10):
both worked