Fix Issue 14149 - Fixes Dns rebinding attack in CEF (#651)

sabanaya · swmitra · commit 1f398cca5009 · 2018-05-28T16:03:39.000+05:30
* Update cef_version for windows only

* Mac CEF distribution with DNS Rebinding attack fix

* Upgrade CEF to 2704 on mac with DNS rebinding fix

* Fix compilation issues on mac after upgrading CEF

* Linux changes for DNS issue

* Cef version update
diff --git a/Gruntfile.js b/Gruntfile.js
@@ -27,7 +27,7 @@ module.exports = function (grunt) {
     var common  = require("./tasks/common")(grunt),
         platform = common.platform(),
         staging,
-        cef_version = "3.2623.1397";
+        cef_version = "3.2623.1402";
 
     if (platform === "mac") {
         staging = "installer/mac/staging/<%= build.name %>.app/Contents";
@@ -37,8 +37,10 @@ module.exports = function (grunt) {
         staging = "installer/linux/debian/package-root/opt/brackets";
     }
 
-    if (platform === "linux") {
-        cef_version = "3.2785.1486";
+    if (platform === "mac") {
+        cef_version = "3.2704.1434";
+    } else if (platform === "linux") {
+        cef_version = "3.2785.1487";
     }
 
     grunt.initConfig({
@@ -346,4 +348,4 @@ module.exports = function (grunt) {
     grunt.loadNpmTasks("grunt-curl");
 
     grunt.registerTask("default", ["setup", "build"]);
-};
+};
diff --git a/appshell/cefclient_mac.mm b/appshell/cefclient_mac.mm
@@ -13,7 +13,6 @@
 #import "include/cef_application_mac.h"
 #include "include/cef_browser.h"
 #include "include/cef_frame.h"
-#include "include/cef_runnable.h"
 #include "client_handler.h"
 #include "appshell/browser/resource_util.h"
 #include "config.h"
