You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository was archived by the owner on Sep 6, 2021. It is now read-only.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As I mentioned on IRC, I think it would be much simpler but equally correct to just filter on $target.is("input") overall -- no need to check the type. On platforms where clicking e.g. a checkbox shouldn't give it focus, Chromium should already be behaving that way by default anyway, so it shouldn't matter if we don't call preventDefault() for it.
It seems this code doesn't really do much anyway. It only applies to elements with no-focus class (i.e. doesn't apply to elements inside a no-focus element), and it only prevents mousedown (i.e. you can still Tab to element). This is all the more reason to simplify this code.
@redmunds It definitely does apply to elements inside a no-focus parent, because mousedown events bubble. We rely on that in many places, including the toolbars, status bar, and Find in Files results panel.
You're right that it does not affect tabbing, though. A better name for it might be .no-mousedown-focus -- although if we eventually implement global focus management to control tabbing, it could presumably look at the same CSS class, so maybe the more generic name is actually good for future-proofing.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull-request contains the patch to fix the issue #9476.
Making possible to the user give focus on input fields inside elements with
no-focus
class.