| CARVIEW |
Select Language
HTTP/2 200
date: Fri, 18 Jul 2025 14:04:37 GMT
content-type: text/html; charset=utf-8
cache-control: no-cache
content-security-policy: default-src 'none'; base-uri 'self'; child-src github.githubassets.com github.com/assets-cdn/worker/ github.com/assets/ gist.github.com/assets-cdn/worker/; connect-src 'self' uploads.github.com www.githubstatus.com collector.github.com raw.githubusercontent.com api.github.com github-cloud.s3.amazonaws.com github-production-repository-file-5c1aeb.s3.amazonaws.com github-production-upload-manifest-file-7fdce7.s3.amazonaws.com github-production-user-asset-6210df.s3.amazonaws.com *.rel.tunnels.api.visualstudio.com wss://*.rel.tunnels.api.visualstudio.com objects-origin.githubusercontent.com copilot-proxy.githubusercontent.com proxy.individual.githubcopilot.com proxy.business.githubcopilot.com proxy.enterprise.githubcopilot.com *.actions.githubusercontent.com wss://*.actions.githubusercontent.com productionresultssa0.blob.core.windows.net/ productionresultssa1.blob.core.windows.net/ productionresultssa2.blob.core.windows.net/ productionresultssa3.blob.core.windows.net/ productionresultssa4.blob.core.windows.net/ productionresultssa5.blob.core.windows.net/ productionresultssa6.blob.core.windows.net/ productionresultssa7.blob.core.windows.net/ productionresultssa8.blob.core.windows.net/ productionresultssa9.blob.core.windows.net/ productionresultssa10.blob.core.windows.net/ productionresultssa11.blob.core.windows.net/ productionresultssa12.blob.core.windows.net/ productionresultssa13.blob.core.windows.net/ productionresultssa14.blob.core.windows.net/ productionresultssa15.blob.core.windows.net/ productionresultssa16.blob.core.windows.net/ productionresultssa17.blob.core.windows.net/ productionresultssa18.blob.core.windows.net/ productionresultssa19.blob.core.windows.net/ github-production-repository-image-32fea6.s3.amazonaws.com github-production-release-asset-2e65be.s3.amazonaws.com insights.github.com wss://alive.github.com api.githubcopilot.com api.individual.githubcopilot.com api.business.githubcopilot.com api.enterprise.githubcopilot.com; font-src github.githubassets.com; form-action 'self' github.com gist.github.com copilot-workspace.githubnext.com objects-origin.githubusercontent.com; frame-ancestors 'none'; frame-src viewscreen.githubusercontent.com notebooks.githubusercontent.com; img-src 'self' data: blob: github.githubassets.com media.githubusercontent.com camo.githubusercontent.com identicons.github.com avatars.githubusercontent.com private-avatars.githubusercontent.com github-cloud.s3.amazonaws.com objects.githubusercontent.com release-assets.githubusercontent.com secured-user-images.githubusercontent.com/ user-images.githubusercontent.com/ private-user-images.githubusercontent.com opengraph.githubassets.com copilotprodattachments.blob.core.windows.net/github-production-copilot-attachments/ github-production-user-asset-6210df.s3.amazonaws.com customer-stories-feed.github.com spotlights-feed.github.com objects-origin.githubusercontent.com *.githubusercontent.com; manifest-src 'self'; media-src github.com user-images.githubusercontent.com/ secured-user-images.githubusercontent.com/ private-user-images.githubusercontent.com github-production-user-asset-6210df.s3.amazonaws.com gist.github.com; script-src github.githubassets.com; style-src 'unsafe-inline' github.githubassets.com; upgrade-insecure-requests; worker-src github.githubassets.com github.com/assets-cdn/worker/ github.com/assets/ gist.github.com/assets-cdn/worker/
referrer-policy: no-referrer-when-downgrade
server-timing: pull_request_layout-fragment;desc="pull_request_layout fragment";dur=290.74217,conversation_content-fragment;desc="conversation_content fragment";dur=865.092608,conversation_sidebar-fragment;desc="conversation_sidebar fragment";dur=211.948555,nginx;desc="NGINX";dur=1.292549,glb;desc="GLB";dur=94.701638
strict-transport-security: max-age=31536000; includeSubdomains; preload
vary: X-PJAX, X-PJAX-Container, Turbo-Visit, Turbo-Frame, X-Requested-With,Accept-Encoding, Accept, X-Requested-With
x-content-type-options: nosniff
x-frame-options: deny
x-voltron-version: fd8fbbc
x-xss-protection: 0
server: github.com
content-encoding: gzip
accept-ranges: bytes
set-cookie: _gh_sess=tonoNMc4WRuf9EDSoCWDg%2BKiJSqGObDQf2lnR69cuccn3tAuvq94fEQ6yvVD0P7p3DlAscpsX4S6%2F6kKZGNT2bpLvhWYJjXBfdt%2FCqo0Bkq5eBgq0oruoltR7gDtqCvH%2F2z%2FtCssKa9eHmrKeOHXWKSfpJbo73dTbgp4JjUP2JCnuzaDQfAXAEAWP2NH1Y15dfiuTp9sbtrOQk5Bl3hnE1ypSMbzxzbsvT%2BJkqMVl9YKgtTboVwoiHo2a5WMiCQpCsn%2F%2BvNRbekCx8y8vA01LQ%3D%3D--RyjCqc%2BvIldYtzVt--UXE%2FBuIZlL%2Fn9IJZbP9yXQ%3D%3D; Path=/; HttpOnly; Secure; SameSite=Lax
set-cookie: _octo=GH1.1.448436210.1752847476; Path=/; Domain=github.com; Expires=Sat, 18 Jul 2026 14:04:36 GMT; Secure; SameSite=Lax
set-cookie: logged_in=no; Path=/; Domain=github.com; Expires=Sat, 18 Jul 2026 14:04:36 GMT; HttpOnly; Secure; SameSite=Lax
x-github-request-id: B514:2D7078:FF15ED:12F9802:687A5474
Add GitHub Flavored Markdown mode, Add some more Markdown fileExtensions by marcelgerber · Pull Request #9780 · adobe/brackets · GitHub
Skip to content
Navigation Menu
{{ message }}
This repository was archived by the owner on Sep 6, 2021. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 7.6k
Add GitHub Flavored Markdown mode, Add some more Markdown fileExtensions #9780
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Note you can only ever get into GFM mode using the Language Switcher. fileExtensions source: https://github.com/github/markup#markups
|
Looks good to me. |
|
Comment to test gfm comment (edit comment to see) |
|
@redmunds An interesting part about your comment is that it displays the hidden portion in the email sent: |
|
@Mark-Simulacrum inline comments don't seem to work -- only block-level comments. |
|
|
||
| "gfm": { | ||
| "name": "GitHub Flavored Markdown", | ||
| "mode": "gfm", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Shouldn't there be at least 1 file extension?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since GitHub Flavored Markdown is a subset of markdown, I'm not sure if we can/should list any extensions: if we do, they would have to be the same as the (regular) markdown extensions, but that could create conflicts inside Brackets. I'm not sure, but perhaps just leaving it to the user to switch to GitHub Flavored Markdown mode is the best option.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
AFAIK GFM has the exact same file extensions Markdown has, and I'm not sure what happens if two modes use the same file extensions.
You can still use GFM using the Language Switcher, where you can define it as default mode as well.
|
Done with code review. |
|
Code review comments adressed. |
|
Right, you can't have two languages with the same set of extensions. One will just overwrite the other. So as I said above, I don't think this is ideal in terms of discoverability... but I think it's fair to merge it since it's still better than nothing. |
|
Merging. |
redmunds
added a commit
that referenced
this pull request
Nov 14, 2014
Add GitHub Flavored Markdown mode, Add some more Markdown fileExtensions
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
You can’t perform that action at this time.
Note you can only ever get into GFM mode using the Language Switcher.
Also added some more
fileExtensionsfor Markdown. Source: https://github.com/github/markup#markups