| CARVIEW |
Select Language
HTTP/2 200
date: Mon, 14 Jul 2025 21:32:20 GMT
content-type: text/html; charset=utf-8
cache-control: no-cache
content-security-policy: default-src 'none'; base-uri 'self'; child-src github.githubassets.com github.com/assets-cdn/worker/ github.com/assets/ gist.github.com/assets-cdn/worker/; connect-src 'self' uploads.github.com www.githubstatus.com collector.github.com raw.githubusercontent.com api.github.com github-cloud.s3.amazonaws.com github-production-repository-file-5c1aeb.s3.amazonaws.com github-production-upload-manifest-file-7fdce7.s3.amazonaws.com github-production-user-asset-6210df.s3.amazonaws.com *.rel.tunnels.api.visualstudio.com wss://*.rel.tunnels.api.visualstudio.com objects-origin.githubusercontent.com copilot-proxy.githubusercontent.com proxy.individual.githubcopilot.com proxy.business.githubcopilot.com proxy.enterprise.githubcopilot.com *.actions.githubusercontent.com wss://*.actions.githubusercontent.com productionresultssa0.blob.core.windows.net/ productionresultssa1.blob.core.windows.net/ productionresultssa2.blob.core.windows.net/ productionresultssa3.blob.core.windows.net/ productionresultssa4.blob.core.windows.net/ productionresultssa5.blob.core.windows.net/ productionresultssa6.blob.core.windows.net/ productionresultssa7.blob.core.windows.net/ productionresultssa8.blob.core.windows.net/ productionresultssa9.blob.core.windows.net/ productionresultssa10.blob.core.windows.net/ productionresultssa11.blob.core.windows.net/ productionresultssa12.blob.core.windows.net/ productionresultssa13.blob.core.windows.net/ productionresultssa14.blob.core.windows.net/ productionresultssa15.blob.core.windows.net/ productionresultssa16.blob.core.windows.net/ productionresultssa17.blob.core.windows.net/ productionresultssa18.blob.core.windows.net/ productionresultssa19.blob.core.windows.net/ github-production-repository-image-32fea6.s3.amazonaws.com github-production-release-asset-2e65be.s3.amazonaws.com insights.github.com wss://alive.github.com api.githubcopilot.com api.individual.githubcopilot.com api.business.githubcopilot.com api.enterprise.githubcopilot.com; font-src github.githubassets.com; form-action 'self' github.com gist.github.com copilot-workspace.githubnext.com objects-origin.githubusercontent.com; frame-ancestors 'none'; frame-src viewscreen.githubusercontent.com notebooks.githubusercontent.com; img-src 'self' data: blob: github.githubassets.com media.githubusercontent.com camo.githubusercontent.com identicons.github.com avatars.githubusercontent.com private-avatars.githubusercontent.com github-cloud.s3.amazonaws.com objects.githubusercontent.com release-assets.githubusercontent.com secured-user-images.githubusercontent.com/ user-images.githubusercontent.com/ private-user-images.githubusercontent.com opengraph.githubassets.com copilotprodattachments.blob.core.windows.net/github-production-copilot-attachments/ github-production-user-asset-6210df.s3.amazonaws.com customer-stories-feed.github.com spotlights-feed.github.com objects-origin.githubusercontent.com *.githubusercontent.com; manifest-src 'self'; media-src github.com user-images.githubusercontent.com/ secured-user-images.githubusercontent.com/ private-user-images.githubusercontent.com github-production-user-asset-6210df.s3.amazonaws.com gist.github.com; script-src github.githubassets.com; style-src 'unsafe-inline' github.githubassets.com; upgrade-insecure-requests; worker-src github.githubassets.com github.com/assets-cdn/worker/ github.com/assets/ gist.github.com/assets-cdn/worker/
referrer-policy: no-referrer-when-downgrade
server-timing: pull_request_layout-fragment;desc="pull_request_layout fragment";dur=403.778661,conversation_content-fragment;desc="conversation_content fragment";dur=567.162849,conversation_sidebar-fragment;desc="conversation_sidebar fragment";dur=212.555844,nginx;desc="NGINX";dur=0.986659,glb;desc="GLB";dur=96.190563
strict-transport-security: max-age=31536000; includeSubdomains; preload
vary: X-PJAX, X-PJAX-Container, Turbo-Visit, Turbo-Frame, X-Requested-With,Accept-Encoding, Accept, X-Requested-With
x-content-type-options: nosniff
x-frame-options: deny
x-voltron-version: 6a3bf42
x-xss-protection: 0
server: github.com
content-encoding: gzip
accept-ranges: bytes
set-cookie: _gh_sess=gYJjlL6aSKLc5HsH1Jl2yxZd9X0uGy3IGFw5oQFNr79OAHz1zZZjt2KeEDekuP2rgFgbzlk4ofnGaVL4Urxwi6dBzHiqSyj%2FJXLOtRPTyBSrcp2GO2FAuMuS9%2BOkd5NzEWTA3SOQH%2F2DGLeIY0udKLDWKdJ3FGJmr1%2BYzJct2iRGmqRvWyt14j86UBxujWWaSuz5FmPKeryjB7Y1YMYJeCIjo35HrGgjl1lIVszdMVo6LKxLnkVSkjqcjT1YXHkD98WgdJaq7oeRziIIjg%2Fqcw%3D%3D--dAZDKlzPN80uC121--UQjDPyMX0fKOpmEEChBmXw%3D%3D; Path=/; HttpOnly; Secure; SameSite=Lax
set-cookie: _octo=GH1.1.113118821.1752528740; Path=/; Domain=github.com; Expires=Tue, 14 Jul 2026 21:32:20 GMT; Secure; SameSite=Lax
set-cookie: logged_in=no; Path=/; Domain=github.com; Expires=Tue, 14 Jul 2026 21:32:20 GMT; HttpOnly; Secure; SameSite=Lax
x-github-request-id: DE80:3A8C35:7D6DF:B1C3A:68757764
Remove even more deprecated code by le717 · Pull Request #9640 · adobe/brackets · GitHub
Skip to content
Navigation Menu
{{ message }}
This repository was archived by the owner on Sep 6, 2021. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 7.6k
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adobe/brackets@/1ec5c8f8c70dc4aed5e98e3254904a2e8a55ae48
57d2628 While these exports were technically never deprecated, they were never documented either, so it's probably not know they still exist.
ingorichter
added a commit
that referenced
this pull request
Oct 23, 2014
Remove even more deprecated code
|
Even after @dangoor's PR #9747, it looks like the removals here will break about 20 different extensions. I think we may want to revert some of these changes for 1.0, since some of the removed items (e.g. @ingorichter remember when reviewing stuff like this that it's always easy to search across all extensions using Kevin's Extension Grabber utility. The search results come back pretty fast, especially if you exclude 'node_modules' folders from the search... |
|
I also strongly recommend The Silver Searcher because it's startlingly fast. Just a few seconds to search through all of the extension code. |
|
It looks like it's just the keyEvent change that needs to be brought back. We should do that in a PR against the release branch. |
|
I goofed again. sigh Sorry guys. facepalm For notes, I have been using the Extension Grabber (and updating the downloads before making changes) and AstroGrep (it's on SourceForge), but it must be missing stuff. I'll try the Silver Searcher on the other PRs once more. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
None yet
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
You can’t perform that action at this time.
Even more for #8751.
I did a through scrub of the code base, looking for any pre-0.41 deprecated. I found what I was looking for.
The following is removed with this PR, listed along side the commit they were deprecated with and the release that deprecation went into effect.
command/Commands.jsandcommand/Menus.js: Old export redirects (56ab3e9, Sprint 39)editor/Editor.js: jQuerytriggerHandlerfor"keyEvent"(21bea9d, Sprint 38)search/QuickOpen.js: Backwards compatibility foraddQuickOpenPlugin()(1ec5c8f, Sprint 23)search/QuickOpen.js: Old export redirects (7d262804728, Sprint 19!) These were technically never deprecated, but they are also not documented either.Few notes:
672c7e(utils/StringMatch.js), which landed in Sprint 25. I did not remove it for fear of breaking it because I do not know how that code works. Again, never deprecated, but it seems it was planned to be. @dangoor Since you made this commit, can you provide some insight here on what should be done?