You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository was archived by the owner on Sep 6, 2021. It is now read-only.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Removes APIs listed in #6127. As you can see in that issue, there are a number of extensions that access it, but it's nearly a year since they were deprecated. It's time to remove them.
The reason will be displayed to describe this comment to others. Learn more.
This was a part of the auto-install extensions PR, but was reverted during review. Since I was editing this file, I thought I would go ahead and restore it.
@peterflynn I've contacted the rest of the extension authors. A few of them already had been filed (as denoted by the link to it), and I followed up on the report.
brackets-typescript-code-intel I personally submitted PRs to fix any deprecated code, but they have not been pushed to the registry because of another broken part.
brackets-minify-more is a fork of https://github.com/wylst/brackets-minifier. The upstream version has long been updated, but as the fork has issues I cannot directly file a report. @Fornace Would you mind looking into this pending removal and updating your extension appropriately? * cfbrackets.org Appears to have already been fixed from Deprecated filesystem APIs raeberli/cfbrackets#1. @raeberli Can you confirm this deprecation will not effect your extensions?
@peterflynn Do you still want to get this into 1.1? I want to avoid a repeat of the 1.0 issues as much as you do, and if 1.1 is supposed to be released near December 9, the sooner this lands the better chance we have of less extension breakage.
cfbrackets has no reference to NativeFileSystem anymore since 7th jun
From: Triangle717 [mailto:notifications@github.com]
Sent: Samstag, 15. November 2014 18:03
To: adobe/brackets
Cc: raeberli
Subject: Re: [brackets] Remove deprecated file system APIs (#9622)
@peterflynnhttps://github.com/peterflynn I've contacted the rest of the extension authors. A few of them already had been filed (as denoted by the link to it), and I followed up on the report.
brackets-typescript-code-intel I personally submitted PRs to fix any deprecated code, but they have not been pushed to the registry because of another broken part.
brackets-minify-more is a fork of https://github.com/wylst/brackets-minifier. The upstream version has long been updated, but as the fork has issues I cannot directly file a report. @Fornacehttps://github.com/Fornace Would you mind looking into this pending removal and updating your extension appropriately?
This PR has been coming up on a year open and two years since the old file system was deprecated. Any extensions that are not updated by now will probably never be updated. Could someone perhaps look at this and see about getting it merged?
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
None yet
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Towards #8751.
Removes APIs listed in #6127. As you can see in that issue, there are a number of extensions that access it, but it's nearly a year since they were deprecated. It's time to remove them.