You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository was archived by the owner on Sep 6, 2021. It is now read-only.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I've listed them all in the description.
About #3376: While it's still not completely fixed, imho the behaviour in the PR branch is better as it doesn't cause persistent UI glitches. It's still a weird bug...
Fwiw, it looks like the position: relative originally came in with 65c9864, and 04848ee was really just a selector rename. That initial commit was part of the original implementation of the "selection triangle" (#702), so we should test the positioning of that to make sure this doesn't break anything. (I wouldn't expect relative->absolute to cause any trouble there, but just in case...)
@marcelgerber Great job tracking down the cause of this!
The "selection triangle" is now gone. Aren't we also getting rid of "selection rectangle over the scrollbar"? If so, then we should be able to removeposition: relative (as opposed to changing it to position: absolute).
The remaining selection "rectangle" works fine, too. @redmunds Yeah, simply removing position: relative works, too. I'm not sure what's better though as setting it explicitly may prevent future changes that re-introduce that bug.
@redmunds@marcelgerber Just to clarify: the "selection triangle" is still present and isn't going away -- it's just shaped like a square now instead of a triangle. But it still needs to get positioned correctly.
I think removing position: relative works only because that also sets it to position: absolute -- by falling back to the redundant CSS style in the .main-view .sidebar rule. If you remove both of those such that the computed style really is position: static, I wouldn't be surprised if it breaks the positioning of the selection triangle/square.
@peterflynn The "selection triangle/rectangle" in working set has a positioning base ancestor of ".open-files-container", so it's not affected by this change.
The "selection triangle/rectangle" in project tree has a positioning base ancestor of "#project-files-container", so it's also not affected by this change. Note this is currently broken and being tracked in #9203.
@marcelgerber I think the fix is to explicitly set it to position: static. I've played around with that and it seems to work the same as position: absolute.
@marcelgerberposition: static is the default and simplest positioning. I don't see any reason for using position: absolute unless element needs to be repositioned or used as a positioning base.
@redmunds Instead of doing that, why don't we just remove the two position attributes from the #sidebar and .sidebar selectors? It has the same effect, plus the benefit of removing dead code from our CSS.
@peterflynn I'm fine with that after verifying that they're not used by any other elements. I don't like the idea of having an idand a class with the same name, so that would be nice to clean up.
@redmunds Actually, position: static doesn't work for me as it doesn't fix the bug and places the sidebar icons (Configure Working Set, Split View) oddly.
I still refactored the CSS, though.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This seems to fix #9248, but I'm not quite sure what that code was for (FWIW, it was introduced in 04848ee) and if anything relies on it.
I've tested an verified these scenarios are still working:
Ctrl-Alt-H
) works fineNot (completely) working: