You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository was archived by the owner on Sep 6, 2021. It is now read-only.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The entire utils/CollectionUtils module and StringUtils.htmlEscape() function was deprecated by Add Lo-Dash #5539, which was implemented in Sprint 34. The newest reference to CollectionUtils was in src/brackets.js back in January (471a8c1), which was Sprint 36, but I find nothing on the wiki explaining how long a deprecation cycle is. There are also no tests for nor core usage of CollectionUtils.
StringUtils.htmlEscape() has no usage in Brackets core at all.
There is some overlap between this and #8954. It might be best for that to be merged first, unless @marcelgerber wants to make these same changes in that PR.
@ingorichter I thought about that already. I thought there was an extension by someone on the core team that helped figuring that out, but I can't seem to find it anymore.
EDIT 2: Initial pass of all the uploaded extensions (as gathered by the aforementioned tool) reports no usage of utils/CollectionsUtils, only small usage of StringUtils.htmlEscape() in four extensions:
Sounds good. If none of the Extensions is using utils/CollectionUtils, then we can assume that this is safe to get rid off.
It would be a good idea to file an issue with all 4 extension authors and tell them that StringUtils.htmlEscape has been removed after a long deprecation phase. This will put the ball in their court and we can move on. Sounds good?
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Working toward #8751's ultimate goal.
utils/CollectionUtils
module andStringUtils.htmlEscape()
function was deprecated by Add Lo-Dash #5539, which was implemented in Sprint 34. The newest reference to CollectionUtils was in src/brackets.js back in January (471a8c1), which was Sprint 36, but I find nothing on the wiki explaining how long a deprecation cycle is. There are also no tests for nor core usage of CollectionUtils.StringUtils.htmlEscape()
has no usage in Brackets core at all.There is some overlap between this and #8954. It might be best for that to be merged first, unless @marcelgerber wants to make these same changes in that PR.