| CARVIEW |
Select Language
HTTP/2 200
date: Mon, 14 Jul 2025 21:35:09 GMT
content-type: text/html; charset=utf-8
cache-control: no-cache
content-security-policy: default-src 'none'; base-uri 'self'; child-src github.githubassets.com github.com/assets-cdn/worker/ github.com/assets/ gist.github.com/assets-cdn/worker/; connect-src 'self' uploads.github.com www.githubstatus.com collector.github.com raw.githubusercontent.com api.github.com github-cloud.s3.amazonaws.com github-production-repository-file-5c1aeb.s3.amazonaws.com github-production-upload-manifest-file-7fdce7.s3.amazonaws.com github-production-user-asset-6210df.s3.amazonaws.com *.rel.tunnels.api.visualstudio.com wss://*.rel.tunnels.api.visualstudio.com objects-origin.githubusercontent.com copilot-proxy.githubusercontent.com proxy.individual.githubcopilot.com proxy.business.githubcopilot.com proxy.enterprise.githubcopilot.com *.actions.githubusercontent.com wss://*.actions.githubusercontent.com productionresultssa0.blob.core.windows.net/ productionresultssa1.blob.core.windows.net/ productionresultssa2.blob.core.windows.net/ productionresultssa3.blob.core.windows.net/ productionresultssa4.blob.core.windows.net/ productionresultssa5.blob.core.windows.net/ productionresultssa6.blob.core.windows.net/ productionresultssa7.blob.core.windows.net/ productionresultssa8.blob.core.windows.net/ productionresultssa9.blob.core.windows.net/ productionresultssa10.blob.core.windows.net/ productionresultssa11.blob.core.windows.net/ productionresultssa12.blob.core.windows.net/ productionresultssa13.blob.core.windows.net/ productionresultssa14.blob.core.windows.net/ productionresultssa15.blob.core.windows.net/ productionresultssa16.blob.core.windows.net/ productionresultssa17.blob.core.windows.net/ productionresultssa18.blob.core.windows.net/ productionresultssa19.blob.core.windows.net/ github-production-repository-image-32fea6.s3.amazonaws.com github-production-release-asset-2e65be.s3.amazonaws.com insights.github.com wss://alive.github.com api.githubcopilot.com api.individual.githubcopilot.com api.business.githubcopilot.com api.enterprise.githubcopilot.com; font-src github.githubassets.com; form-action 'self' github.com gist.github.com copilot-workspace.githubnext.com objects-origin.githubusercontent.com; frame-ancestors 'none'; frame-src viewscreen.githubusercontent.com notebooks.githubusercontent.com; img-src 'self' data: blob: github.githubassets.com media.githubusercontent.com camo.githubusercontent.com identicons.github.com avatars.githubusercontent.com private-avatars.githubusercontent.com github-cloud.s3.amazonaws.com objects.githubusercontent.com release-assets.githubusercontent.com secured-user-images.githubusercontent.com/ user-images.githubusercontent.com/ private-user-images.githubusercontent.com opengraph.githubassets.com copilotprodattachments.blob.core.windows.net/github-production-copilot-attachments/ github-production-user-asset-6210df.s3.amazonaws.com customer-stories-feed.github.com spotlights-feed.github.com objects-origin.githubusercontent.com *.githubusercontent.com; manifest-src 'self'; media-src github.com user-images.githubusercontent.com/ secured-user-images.githubusercontent.com/ private-user-images.githubusercontent.com github-production-user-asset-6210df.s3.amazonaws.com gist.github.com; script-src github.githubassets.com; style-src 'unsafe-inline' github.githubassets.com; upgrade-insecure-requests; worker-src github.githubassets.com github.com/assets-cdn/worker/ github.com/assets/ gist.github.com/assets-cdn/worker/
referrer-policy: no-referrer-when-downgrade
server-timing: pull_request_layout-fragment;desc="pull_request_layout fragment";dur=389.303974,conversation_content-fragment;desc="conversation_content fragment";dur=679.106785,conversation_sidebar-fragment;desc="conversation_sidebar fragment";dur=278.19795,nginx;desc="NGINX";dur=1.44081,glb;desc="GLB";dur=96.620823
strict-transport-security: max-age=31536000; includeSubdomains; preload
vary: X-PJAX, X-PJAX-Container, Turbo-Visit, Turbo-Frame, X-Requested-With,Accept-Encoding, Accept, X-Requested-With
x-content-type-options: nosniff
x-frame-options: deny
x-voltron-version: 6a3bf42
x-xss-protection: 0
server: github.com
content-encoding: gzip
accept-ranges: bytes
set-cookie: _gh_sess=D9yXaE52mW%2Fy%2BZh9%2FlnlUgMOkx2waz%2Bs2Yi%2FAOEkd7%2FkrYMtGkkhXGa20ozysVLe8VjoNof9KYIFp2JO1%2Fv8RPPoRPxckRZiM6wESD%2Buoo3%2FAjLh3MgkMq2juVNcVZG%2BpdPjmqcdAxDV49BBdvnRrzbEsaMjhHfHLNL%2FxNuFlcUfybSt90Dbfkt9cIU1PBw767AfTrUc3T63JTjTTZpezhVMvZ1SwfIG4BBLvWPm5dDcKZ0FwUJa3CYC71jns3osK1EL1yUOSv%2BDuTmyE0TtPg%3D%3D--x1a27MLbLoWJXusj--FW3KBWIuYJdmaKtCZnIKww%3D%3D; Path=/; HttpOnly; Secure; SameSite=Lax
set-cookie: _octo=GH1.1.137439488.1752528908; Path=/; Domain=github.com; Expires=Tue, 14 Jul 2026 21:35:08 GMT; Secure; SameSite=Lax
set-cookie: logged_in=no; Path=/; Domain=github.com; Expires=Tue, 14 Jul 2026 21:35:08 GMT; HttpOnly; Secure; SameSite=Lax
x-github-request-id: D728:31C83F:7CD2C:B2830:6875780C
Fix live dev highlight being out of place in edge cases by marcelgerber · Pull Request #8922 · adobe/brackets · GitHub
marcelgerber
force-pushed
the
ld-hightlight-position
branch
from
October 15, 2014 19:39
Skip to content
Navigation Menu
{{ message }}
This repository was archived by the owner on Sep 6, 2021. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 7.6k
Fix live dev highlight being out of place in edge cases #8922
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm testing the root Getting Started page. It looks good when page is less than max width:
But wider than max width does not offset highlight correctly:
|
|
Wow, that one was tough! The issue was that, as soon as |
|
This fixes the Getting started page, but the brackets.io/contribute.html page used in the recipe of #7921 is broken when scrolling. It's weird that element highlights in the |
|
Somehow works now. Fingers crossed. |
|
I want to consider taking this for Brackets 1.0. Need to make sure all problems are fixed and we test it enough to be assured that risk is low. |
|
One note about testing: |
|
@marcelgerber This looks great. Squash to a single commit and I'll merge it. |
|
|
marcelgerber
force-pushed
the
ld-hightlight-position
branch
from
d8443d6 to
fc096cf
Compare
|
@redmunds Ready. |
|
Looks good. Merging. |
redmunds
added a commit
that referenced
this pull request
Oct 15, 2014
Fix live dev highlight being out of place in edge cases
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
You can’t perform that action at this time.
For #7921, where Live Preview highlight is out of place when using with brackets.io site.
Tested with brackets.io/index.html, brackets.io/contribute.html, and the (German) Getting Started page.