| CARVIEW |
Select Language
HTTP/2 200
date: Tue, 15 Jul 2025 03:45:11 GMT
content-type: text/html; charset=utf-8
cache-control: no-cache
content-security-policy: default-src 'none'; base-uri 'self'; child-src github.githubassets.com github.com/assets-cdn/worker/ github.com/assets/ gist.github.com/assets-cdn/worker/; connect-src 'self' uploads.github.com www.githubstatus.com collector.github.com raw.githubusercontent.com api.github.com github-cloud.s3.amazonaws.com github-production-repository-file-5c1aeb.s3.amazonaws.com github-production-upload-manifest-file-7fdce7.s3.amazonaws.com github-production-user-asset-6210df.s3.amazonaws.com *.rel.tunnels.api.visualstudio.com wss://*.rel.tunnels.api.visualstudio.com objects-origin.githubusercontent.com copilot-proxy.githubusercontent.com proxy.individual.githubcopilot.com proxy.business.githubcopilot.com proxy.enterprise.githubcopilot.com *.actions.githubusercontent.com wss://*.actions.githubusercontent.com productionresultssa0.blob.core.windows.net/ productionresultssa1.blob.core.windows.net/ productionresultssa2.blob.core.windows.net/ productionresultssa3.blob.core.windows.net/ productionresultssa4.blob.core.windows.net/ productionresultssa5.blob.core.windows.net/ productionresultssa6.blob.core.windows.net/ productionresultssa7.blob.core.windows.net/ productionresultssa8.blob.core.windows.net/ productionresultssa9.blob.core.windows.net/ productionresultssa10.blob.core.windows.net/ productionresultssa11.blob.core.windows.net/ productionresultssa12.blob.core.windows.net/ productionresultssa13.blob.core.windows.net/ productionresultssa14.blob.core.windows.net/ productionresultssa15.blob.core.windows.net/ productionresultssa16.blob.core.windows.net/ productionresultssa17.blob.core.windows.net/ productionresultssa18.blob.core.windows.net/ productionresultssa19.blob.core.windows.net/ github-production-repository-image-32fea6.s3.amazonaws.com github-production-release-asset-2e65be.s3.amazonaws.com insights.github.com wss://alive.github.com api.githubcopilot.com api.individual.githubcopilot.com api.business.githubcopilot.com api.enterprise.githubcopilot.com; font-src github.githubassets.com; form-action 'self' github.com gist.github.com copilot-workspace.githubnext.com objects-origin.githubusercontent.com; frame-ancestors 'none'; frame-src viewscreen.githubusercontent.com notebooks.githubusercontent.com; img-src 'self' data: blob: github.githubassets.com media.githubusercontent.com camo.githubusercontent.com identicons.github.com avatars.githubusercontent.com private-avatars.githubusercontent.com github-cloud.s3.amazonaws.com objects.githubusercontent.com release-assets.githubusercontent.com secured-user-images.githubusercontent.com/ user-images.githubusercontent.com/ private-user-images.githubusercontent.com opengraph.githubassets.com copilotprodattachments.blob.core.windows.net/github-production-copilot-attachments/ github-production-user-asset-6210df.s3.amazonaws.com customer-stories-feed.github.com spotlights-feed.github.com objects-origin.githubusercontent.com *.githubusercontent.com; manifest-src 'self'; media-src github.com user-images.githubusercontent.com/ secured-user-images.githubusercontent.com/ private-user-images.githubusercontent.com github-production-user-asset-6210df.s3.amazonaws.com gist.github.com; script-src github.githubassets.com; style-src 'unsafe-inline' github.githubassets.com; upgrade-insecure-requests; worker-src github.githubassets.com github.com/assets-cdn/worker/ github.com/assets/ gist.github.com/assets-cdn/worker/
referrer-policy: no-referrer-when-downgrade
server-timing: pull_request_layout-fragment;desc="pull_request_layout fragment";dur=284.4097,conversation_content-fragment;desc="conversation_content fragment";dur=648.11786,conversation_sidebar-fragment;desc="conversation_sidebar fragment";dur=184.771393,nginx;desc="NGINX";dur=1.070256,glb;desc="GLB";dur=97.307158
strict-transport-security: max-age=31536000; includeSubdomains; preload
vary: X-PJAX, X-PJAX-Container, Turbo-Visit, Turbo-Frame, X-Requested-With,Accept-Encoding, Accept, X-Requested-With
x-content-type-options: nosniff
x-frame-options: deny
x-voltron-version: 6a3bf42
x-xss-protection: 0
server: github.com
content-encoding: gzip
accept-ranges: bytes
set-cookie: _gh_sess=FB3eBnW88vSPxuSEEnUwA0P0Cw7sJrOkxoxjvYNjPQ0QOeeReiE4FkjNUIQpgvRxuJHiVBc%2FdGlIYzTGQO%2BdS3JY8S%2Bsq2j%2FYPA5lv7eQg5y5bdQDBfGQqS4GCDqk4fPkApHkTp6%2FiQQ%2FtHdEFEYySQ1frK1AZHClT%2BoRpMDiaNJuNkGQM9oCDGjW9qXA0KK4eEEMmoXQQh%2FAPPbT1LUiYzOBz%2F1a73nhbSVqeAX7xdZrLCRL35bskKsEWm0i%2BBTgk6wHJwbkMWw5rcKbKae3w%3D%3D--bKPBLSMeGSGcWWL3--1CG3Qg8u3Akqm%2FNEjI5o8Q%3D%3D; Path=/; HttpOnly; Secure; SameSite=Lax
set-cookie: _octo=GH1.1.811649738.1752551110; Path=/; Domain=github.com; Expires=Wed, 15 Jul 2026 03:45:10 GMT; Secure; SameSite=Lax
set-cookie: logged_in=no; Path=/; Domain=github.com; Expires=Wed, 15 Jul 2026 03:45:10 GMT; HttpOnly; Secure; SameSite=Lax
x-github-request-id: 91FC:37FF58:2D4BD:3A3E2:6875CEC6
Fixed the border around the languages button and the scrollbar fillers by TomMalbran · Pull Request #8521 · adobe/brackets · GitHub
Skip to content
Navigation Menu
{{ message }}
This repository was archived by the owner on Sep 6, 2021. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 7.6k
Fixed the border around the languages button and the scrollbar fillers #8521
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I verified that this fixes problem on Windows and doesn't break scrollbar or gutter fillers on Mac. Did not test Linux. All tests pass (except for known issue 8519)). Style changes look good, but this may conflict with changes @dangoor is working on, so I'm going to hold off merging. Kevin? |
| @@ -196,6 +197,10 @@ | |||
| } | |||
|
|
|||
| &.platform-linux { | |||
| .CodeMirror-scrollbar-filler, | |||
| .CodeMirror-gutter-filler { | |||
| background-color: #1d1f21; | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is it intentional that the linux and windows colors are different?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes. The color for linux is the same as the background color. Without it, it is displayed using the light bg. It works in the same way in the light theme.
To test it in windows I just replace platform-linux with platform-win and comment the windows styles.
|
I was away for the past few hours and it turned out that I haven't had a chance to make any changes yet... which means I have no conflicts to worry about, so I can merge this and work from here. |
|
@dangoor I added another fix. The line highlight was white before the code when the line-numbers are off. |
|
Good catch. I tried the line number fix and it works fine. Randy tested the other fixes. Merging. |
dangoor
added a commit
that referenced
this pull request
Jul 23, 2014
Fixed the border around the languages button and the scrollbar fillers
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
None yet
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
You can’t perform that action at this time.
This should fix #8389 and an issue I saw with the corner scrollbars filler in windows and both scrollbar fillers in Linux.