You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository was archived by the owner on Sep 6, 2021. It is now read-only.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@MiguelCastillo If the font preferences are no longer under the theme prefix, which preferences are left under it? Do we really need to have a themes prefix or we can just remove it since is a core feature?
@TomMalbran I left themes in there because there was no real objection one way or the other from @dangoor when we had a short discussion here #8461.
But if we all think is better to remove the prefix, then let's do it! My preference has always been to scope things in a namespace type of way... Kinda makes it clearer to see what code is doing what.
Fonts settings are still going under that, but the fonts api will have its own "fonts" prefix. Unless of course we don't want that there either.
@MiguelCastillo, this comment isn't directly related to this PR, but this looks as good of a place as any to bring this up. Do you need to change the license text at the beginning of these files to match the Adobe licensing text?
We still have two settings: the selected theme and customScrollbars, so I think putting those under a "themes" prefix is fine.
@lkcampbell The license blocks are fine, I think, since we don't explicitly require copyright assignment (nor is it really necessary with the MIT license).
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
None yet
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
...lict with the themes extension
#8461