| CARVIEW |
Select Language
HTTP/2 200
date: Mon, 14 Jul 2025 16:37:39 GMT
content-type: text/html; charset=utf-8
cache-control: no-cache
content-security-policy: default-src 'none'; base-uri 'self'; child-src github.githubassets.com github.com/assets-cdn/worker/ github.com/assets/ gist.github.com/assets-cdn/worker/; connect-src 'self' uploads.github.com www.githubstatus.com collector.github.com raw.githubusercontent.com api.github.com github-cloud.s3.amazonaws.com github-production-repository-file-5c1aeb.s3.amazonaws.com github-production-upload-manifest-file-7fdce7.s3.amazonaws.com github-production-user-asset-6210df.s3.amazonaws.com *.rel.tunnels.api.visualstudio.com wss://*.rel.tunnels.api.visualstudio.com objects-origin.githubusercontent.com copilot-proxy.githubusercontent.com proxy.individual.githubcopilot.com proxy.business.githubcopilot.com proxy.enterprise.githubcopilot.com *.actions.githubusercontent.com wss://*.actions.githubusercontent.com productionresultssa0.blob.core.windows.net/ productionresultssa1.blob.core.windows.net/ productionresultssa2.blob.core.windows.net/ productionresultssa3.blob.core.windows.net/ productionresultssa4.blob.core.windows.net/ productionresultssa5.blob.core.windows.net/ productionresultssa6.blob.core.windows.net/ productionresultssa7.blob.core.windows.net/ productionresultssa8.blob.core.windows.net/ productionresultssa9.blob.core.windows.net/ productionresultssa10.blob.core.windows.net/ productionresultssa11.blob.core.windows.net/ productionresultssa12.blob.core.windows.net/ productionresultssa13.blob.core.windows.net/ productionresultssa14.blob.core.windows.net/ productionresultssa15.blob.core.windows.net/ productionresultssa16.blob.core.windows.net/ productionresultssa17.blob.core.windows.net/ productionresultssa18.blob.core.windows.net/ productionresultssa19.blob.core.windows.net/ github-production-repository-image-32fea6.s3.amazonaws.com github-production-release-asset-2e65be.s3.amazonaws.com insights.github.com wss://alive.github.com api.githubcopilot.com api.individual.githubcopilot.com api.business.githubcopilot.com api.enterprise.githubcopilot.com; font-src github.githubassets.com; form-action 'self' github.com gist.github.com copilot-workspace.githubnext.com objects-origin.githubusercontent.com; frame-ancestors 'none'; frame-src viewscreen.githubusercontent.com notebooks.githubusercontent.com; img-src 'self' data: blob: github.githubassets.com media.githubusercontent.com camo.githubusercontent.com identicons.github.com avatars.githubusercontent.com private-avatars.githubusercontent.com github-cloud.s3.amazonaws.com objects.githubusercontent.com release-assets.githubusercontent.com secured-user-images.githubusercontent.com/ user-images.githubusercontent.com/ private-user-images.githubusercontent.com opengraph.githubassets.com copilotprodattachments.blob.core.windows.net/github-production-copilot-attachments/ github-production-user-asset-6210df.s3.amazonaws.com customer-stories-feed.github.com spotlights-feed.github.com objects-origin.githubusercontent.com *.githubusercontent.com; manifest-src 'self'; media-src github.com user-images.githubusercontent.com/ secured-user-images.githubusercontent.com/ private-user-images.githubusercontent.com github-production-user-asset-6210df.s3.amazonaws.com gist.github.com; script-src github.githubassets.com; style-src 'unsafe-inline' github.githubassets.com; upgrade-insecure-requests; worker-src github.githubassets.com github.com/assets-cdn/worker/ github.com/assets/ gist.github.com/assets-cdn/worker/
referrer-policy: no-referrer-when-downgrade
server-timing: pull_request_layout-fragment;desc="pull_request_layout fragment";dur=372.781951,conversation_content-fragment;desc="conversation_content fragment";dur=917.581266,conversation_sidebar-fragment;desc="conversation_sidebar fragment";dur=293.577306,nginx;desc="NGINX";dur=0.73894,glb;desc="GLB";dur=95.967924
strict-transport-security: max-age=31536000; includeSubdomains; preload
vary: X-PJAX, X-PJAX-Container, Turbo-Visit, Turbo-Frame, X-Requested-With,Accept-Encoding, Accept, X-Requested-With
x-content-type-options: nosniff
x-frame-options: deny
x-voltron-version: 6a3bf42
x-xss-protection: 0
server: github.com
content-encoding: gzip
accept-ranges: bytes
set-cookie: _gh_sess=RdqzGjP7zOVQ4kTSUoiMHsHTj5xwVLEzVz1EeV513w1Nz4nu4IQ5CaxqLG8sYeIGpmxmMeuT9XHfdOgHjtXAQB2QK%2BfBIsj6ruYvlGTgQb9m3f5nUztpmKTQrMj1CRYdElgjikX8nLTRFnjabAaAdjXYMEeP0ZTr8vydeC9YF6cb3BUhkWuo4GffH3r%2FCDC4ZrQfYNjQyr6uLsKEB30bAAPMwa2WmGBv8z460HPAD1vRQctWbJWicGAHqnBaJNjFe1am6ojG3vppiJ%2BLR9fRtg%3D%3D--FjytXM4VtKOiYher--0cPFvEK8kOptNsnfz878%2Bw%3D%3D; Path=/; HttpOnly; Secure; SameSite=Lax
set-cookie: _octo=GH1.1.2090307109.1752511058; Path=/; Domain=github.com; Expires=Tue, 14 Jul 2026 16:37:38 GMT; Secure; SameSite=Lax
set-cookie: logged_in=no; Path=/; Domain=github.com; Expires=Tue, 14 Jul 2026 16:37:38 GMT; HttpOnly; Secure; SameSite=Lax
x-github-request-id: 9D92:22345C:14B152D:1992220:68753252
updated wording of UTF-8 file load error. by h1w4y · Pull Request #7932 · adobe/brackets · GitHub
h1w4y
changed the title
updated wording of UF-8 file load error. Issue #7850
updated wording of UF-8 file load error.
May 24, 2014
bchintx
changed the title
updated wording of UF-8 file load error.
updated wording of UTF-8 file load error.
May 27, 2014
Skip to content
Navigation Menu
{{ message }}
This repository was archived by the owner on Sep 6, 2021. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 7.6k
updated wording of UTF-8 file load error. #7932
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -37,7 +37,7 @@ define({ | |||
| "NO_MODIFICATION_ALLOWED_ERR" : "The target directory cannot be modified.", | |||
| "NO_MODIFICATION_ALLOWED_ERR_FILE" : "The permissions do not allow you to make modifications.", | |||
| "CONTENTS_MODIFIED_ERR" : "The file has been modified outside of {APP_NAME}.", | |||
| "UNSUPPORTED_ENCODING_ERR" : "The file is not UTF-8 encoded text.", | |||
| "UNSUPPORTED_ENCODING_ERR" : "Brackets currently only supports UTF-8 encoded text files.", | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should somehow make clear the opened file isn't UTF-8.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How's this?
"The file is not UTF-8 encoded text. Brackets currently only supports UTF-8 encoded text files."
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's easy, but ok with me.
h1w4y
changed the title
|
oops! Thanks. I better start reading the code ;) |
bchintx
changed the title
|
@njx I think this is a good idea, but can you give this string change a quick review? |
|
I think we wanted to just replace the second sentence instead of appending to it. It feels a bit redundant with both. (I guess that's what @HighwayChile had originally.) @SAplayer - it seems to me like saying "The file foo.js could not be opened. Brackets currently only supports UTF-8 encoded text files." makes it pretty clear that the reason the file couldn't be opened is that it's not a UTF-8 text file. Do you think the extra sentence is necessary? |
|
@njx Ah yes, I didn't think about the first sentence ("The file foo.js could not be opened."). I'm ok with it either way. |
|
Cool. @HighwayChile, sorry for the churn - if you could change it back to just the |
|
@njx I'll be happy to make that change. |
|
Thanks. Merging. |
redmunds
added a commit
that referenced
this pull request
May 30, 2014
updated wording of UTF-8 file load error.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
None yet
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
You can’t perform that action at this time.
addresses Issue #7850
When opening a non UTF-8 file, the second and third sentences of the error message will now read: "The file is not UTF-8 encoded text. Brackets currently only supports UTF-8 encoded text files."