You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository was archived by the owner on Sep 6, 2021. It is now read-only.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@FezVrasta I looked at your change and it seems safe, but I pasted the example from #7673 into a Brackets extension dialog and it doesn't seem to fix the problem. Let me know how I can test this out. Thanks.
Also, I just upgraded Brackets to LESS 1.7.0. That doesn't seem to affect this change, but be sure that you test any new changes against the latest code in master.
Explain to me what this fixes for you. It doesn't seem to have any effect in the example in #7673 (for me on Win7). I'm assuming that you are writing an extension that uses nested tables, is that correct? If so, can you provide a link to your extension so I can verify what this change does?
Can I see it in the latest version, or is this in an un-merged branch? If so, what's the branch? Also, please provide a recipe -- I am not familiar with that extension.
Yes you can see it in the production version, just try to commit something and a modal window with a code-viewer of the diff will be shown. It is made out with a table.
My point is that the table-striped class only applies to the table tag, so it should be removed from that div tag. Anyway, this change makes sense, so merging.
.table-striped "was" applied to any child table of the element with that class assigned.. not only to "table" elements with class "table-striped". (I think)
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is for #7673