| CARVIEW |
Select Language
HTTP/2 200
date: Tue, 15 Jul 2025 14:03:19 GMT
content-type: text/html; charset=utf-8
cache-control: no-cache
content-security-policy: default-src 'none'; base-uri 'self'; child-src github.githubassets.com github.com/assets-cdn/worker/ github.com/assets/ gist.github.com/assets-cdn/worker/; connect-src 'self' uploads.github.com www.githubstatus.com collector.github.com raw.githubusercontent.com api.github.com github-cloud.s3.amazonaws.com github-production-repository-file-5c1aeb.s3.amazonaws.com github-production-upload-manifest-file-7fdce7.s3.amazonaws.com github-production-user-asset-6210df.s3.amazonaws.com *.rel.tunnels.api.visualstudio.com wss://*.rel.tunnels.api.visualstudio.com objects-origin.githubusercontent.com copilot-proxy.githubusercontent.com proxy.individual.githubcopilot.com proxy.business.githubcopilot.com proxy.enterprise.githubcopilot.com *.actions.githubusercontent.com wss://*.actions.githubusercontent.com productionresultssa0.blob.core.windows.net/ productionresultssa1.blob.core.windows.net/ productionresultssa2.blob.core.windows.net/ productionresultssa3.blob.core.windows.net/ productionresultssa4.blob.core.windows.net/ productionresultssa5.blob.core.windows.net/ productionresultssa6.blob.core.windows.net/ productionresultssa7.blob.core.windows.net/ productionresultssa8.blob.core.windows.net/ productionresultssa9.blob.core.windows.net/ productionresultssa10.blob.core.windows.net/ productionresultssa11.blob.core.windows.net/ productionresultssa12.blob.core.windows.net/ productionresultssa13.blob.core.windows.net/ productionresultssa14.blob.core.windows.net/ productionresultssa15.blob.core.windows.net/ productionresultssa16.blob.core.windows.net/ productionresultssa17.blob.core.windows.net/ productionresultssa18.blob.core.windows.net/ productionresultssa19.blob.core.windows.net/ github-production-repository-image-32fea6.s3.amazonaws.com github-production-release-asset-2e65be.s3.amazonaws.com insights.github.com wss://alive.github.com api.githubcopilot.com api.individual.githubcopilot.com api.business.githubcopilot.com api.enterprise.githubcopilot.com; font-src github.githubassets.com; form-action 'self' github.com gist.github.com copilot-workspace.githubnext.com objects-origin.githubusercontent.com; frame-ancestors 'none'; frame-src viewscreen.githubusercontent.com notebooks.githubusercontent.com; img-src 'self' data: blob: github.githubassets.com media.githubusercontent.com camo.githubusercontent.com identicons.github.com avatars.githubusercontent.com private-avatars.githubusercontent.com github-cloud.s3.amazonaws.com objects.githubusercontent.com release-assets.githubusercontent.com secured-user-images.githubusercontent.com/ user-images.githubusercontent.com/ private-user-images.githubusercontent.com opengraph.githubassets.com copilotprodattachments.blob.core.windows.net/github-production-copilot-attachments/ github-production-user-asset-6210df.s3.amazonaws.com customer-stories-feed.github.com spotlights-feed.github.com objects-origin.githubusercontent.com *.githubusercontent.com; manifest-src 'self'; media-src github.com user-images.githubusercontent.com/ secured-user-images.githubusercontent.com/ private-user-images.githubusercontent.com github-production-user-asset-6210df.s3.amazonaws.com gist.github.com; script-src github.githubassets.com; style-src 'unsafe-inline' github.githubassets.com; upgrade-insecure-requests; worker-src github.githubassets.com github.com/assets-cdn/worker/ github.com/assets/ gist.github.com/assets-cdn/worker/
referrer-policy: no-referrer-when-downgrade
server-timing: pull_request_layout-fragment;desc="pull_request_layout fragment";dur=332.53916,conversation_content-fragment;desc="conversation_content fragment";dur=1842.6352,conversation_sidebar-fragment;desc="conversation_sidebar fragment";dur=248.359186,nginx;desc="NGINX";dur=1.375374,glb;desc="GLB";dur=95.291353
strict-transport-security: max-age=31536000; includeSubdomains; preload
vary: X-PJAX, X-PJAX-Container, Turbo-Visit, Turbo-Frame, X-Requested-With,Accept-Encoding, Accept, X-Requested-With
x-content-type-options: nosniff
x-frame-options: deny
x-voltron-version: 6a3bf42
x-xss-protection: 0
server: github.com
content-encoding: gzip
accept-ranges: bytes
set-cookie: _gh_sess=XZ80xsq4zfQxRTnRTpqmHc%2FEfF2Pwb56SEWQJHGIXU44eSx75Op2OoVz6GMYPTe0LnjSPNScVWZkpNxWJmxfKJ370sv%2FO7DeegosyifFK%2F2VhwE6bM5s0aVUwkcnY4U%2BPRo9izMsMfhhN9nl3EddhlWjUEi%2BkAvmFWgpT3HrsasSwuRJREhGlSaTmGaeWHNmCESNcCE%2Fp0pZZn1GE8Aj5%2BrSaQpoKyQiD2HIaiuo04p9MlFrhWKtNZIx0MKJl9uEUpVFdP2l7BBeNbsktW9MWg%3D%3D--j4VeWHx0psQhTpEk--3iAG1%2F9D8HW22DnH44Qe9w%3D%3D; Path=/; HttpOnly; Secure; SameSite=Lax
set-cookie: _octo=GH1.1.1206479362.1752588197; Path=/; Domain=github.com; Expires=Wed, 15 Jul 2026 14:03:17 GMT; Secure; SameSite=Lax
set-cookie: logged_in=no; Path=/; Domain=github.com; Expires=Wed, 15 Jul 2026 14:03:17 GMT; HttpOnly; Secure; SameSite=Lax
x-github-request-id: B9F8:27A670:9F2472:B2F601:68765FA5
Alternative fix for Replace ModalBar with 2 lines by TomMalbran · Pull Request #7743 · adobe/brackets · GitHub
Skip to content
Navigation Menu
{{ message }}
This repository was archived by the owner on Sep 6, 2021. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 7.6k
Alternative fix for Replace ModalBar with 2 lines #7743
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| // when there are html menus we need to adjust the top position | ||
| if (!brackets.nativeMenus) { | ||
| var top = $("#titlebar").outerHeight(); | ||
| this._$root.css("top", (top + 10) + "px"); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why is this adjustment only 10px? The adjustment you're replacing uses 37px.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It should be just top and top is the height of the html menus, which is 37px when it uses 1 line and more when it uses 2. I was doing some testing and forgot to remove the extra 10.
|
I'm seeing some quirks with this branch. I'm using Win7. Also need to test Mac. With HTML menus (and title bar a single line), it transitions down to a small amount (looks like 10px) and then closes the last amount. This happens both for a single line modal bar or a 2 line modal bar. The case with a HTML Menus and 2 line title bar is broken in all 3 branches (master, this branch, and my branch). I tested this branch with only the |
|
@TomMalbran I added a Testing Matrix in description of #7396. |
|
@redmunds I removed the extra 10px that was adding to the top position, which shouldn't be there in the first place. Hopefully that should fix the 10px error with the html menus, since it was placing the modal bars 10px under the menu leaving a gap between the menus and the bar. I did some testing in win8.1 and it works fine for me (with and without html menus, with 1 and 2 lines bars). |
|
Looks good! Merging. |
redmunds
added a commit
that referenced
this pull request
May 4, 2014
Alternative fix for Replace ModalBar with 2 lines
This was referenced May 4, 2014
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
None yet
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
You can’t perform that action at this time.
@redmunds This is the alternative fix for #7396.
I noticed that using 100% with translate worked fine, so we no longer need to worry about the height of the modal bar. It also fixes an issue when the html menus use 2 lines, or even more.