You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository was archived by the owner on Sep 6, 2021. It is now read-only.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Well, I'm not sure whether root should be changed to English (US) - it's used for other English speaking countries (Australia, Canada) as well (and of course it's the main fallback).
@zaggino Like the fix, thanks. Should have coded it myself, next time.
@SAplayer I think English (US) is OK, I would even go so far to suggest LOCALE_EN should be LOCALE_EN_US. When you see how other software and organisations deal with this, calling the it en-us is standard. I accept that other countries speak this variation of English, but most other software still calls it en-us.
See Firefox as an example: https://www.mozilla.org/en-US/firefox/all/
On that pages there is English (British), English (South African) and English (US). In the configs it is en-GB, en-ZA and en-US
Chrome is similar, they call it English (United States).
I think we are best to change Brackets to be inline with the conventions set by other software and to adhere as closely as possible to the ISO standards.
Australia & Canada (and a lot of former colonies) use British English so I don't think we need to add more than US & UK. Only question for me is if it should be US & UK or United States & British or whatever should be displayed for the end user. It seems every software uses different terms here (British in Firefox vs United Kingdom in Chrome)
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
None yet
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.