You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository was archived by the owner on Sep 6, 2021. It is now read-only.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@kvarel Thanks for making changes that I suggested in #7532. This is a new pull request because you're making changes in a new branch kvarel:patch-16 instead of kvarel:patch-15 branch. Can you switch back to kvarel:patch-15 and make a new commit in that branch? Then your changes will go into that pull request and we can close this one.
Before you make a new commit, you also need to make some other changes too. When you made changes that I mentioned in my comment, you need to adjust line numbers since all line numbers that I mentioned are based on the previous version of the file. If you insert a line, then all line numbers larger than that line need to add one.
The reason will be displayed to describe this comment to others. Learn more.
The block you're moving is two lines above the lines that I was referring to. So can you put back EXPERIMENTAL_BUILD and DEVELOPMENT_BUILD to where they were before, and then move the next two lines that should be here?
After that you move BUTTON_YES and BUTTON_NO to the end of this block. Once you're done, this block should look like below...
@RaymondLim I think in general @kvarel is just editing through the web interface, so we probably need to go ahead and do the fixups ourselves (that's what we've done in the past).
@njx@RaymondLim When working with the Croatian contribution, I learned how to do it through directly editing on github.com so I could instruct contributor what to do. I updated nls/README.md in pull request #7840 with the info, in case it helps here.
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
None yet
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.