| CARVIEW |
Select Language
HTTP/2 200
date: Mon, 14 Jul 2025 12:37:24 GMT
content-type: text/html; charset=utf-8
cache-control: no-cache
content-security-policy: default-src 'none'; base-uri 'self'; child-src github.githubassets.com github.com/assets-cdn/worker/ github.com/assets/ gist.github.com/assets-cdn/worker/; connect-src 'self' uploads.github.com www.githubstatus.com collector.github.com raw.githubusercontent.com api.github.com github-cloud.s3.amazonaws.com github-production-repository-file-5c1aeb.s3.amazonaws.com github-production-upload-manifest-file-7fdce7.s3.amazonaws.com github-production-user-asset-6210df.s3.amazonaws.com *.rel.tunnels.api.visualstudio.com wss://*.rel.tunnels.api.visualstudio.com objects-origin.githubusercontent.com copilot-proxy.githubusercontent.com proxy.individual.githubcopilot.com proxy.business.githubcopilot.com proxy.enterprise.githubcopilot.com *.actions.githubusercontent.com wss://*.actions.githubusercontent.com productionresultssa0.blob.core.windows.net/ productionresultssa1.blob.core.windows.net/ productionresultssa2.blob.core.windows.net/ productionresultssa3.blob.core.windows.net/ productionresultssa4.blob.core.windows.net/ productionresultssa5.blob.core.windows.net/ productionresultssa6.blob.core.windows.net/ productionresultssa7.blob.core.windows.net/ productionresultssa8.blob.core.windows.net/ productionresultssa9.blob.core.windows.net/ productionresultssa10.blob.core.windows.net/ productionresultssa11.blob.core.windows.net/ productionresultssa12.blob.core.windows.net/ productionresultssa13.blob.core.windows.net/ productionresultssa14.blob.core.windows.net/ productionresultssa15.blob.core.windows.net/ productionresultssa16.blob.core.windows.net/ productionresultssa17.blob.core.windows.net/ productionresultssa18.blob.core.windows.net/ productionresultssa19.blob.core.windows.net/ github-production-repository-image-32fea6.s3.amazonaws.com github-production-release-asset-2e65be.s3.amazonaws.com insights.github.com wss://alive.github.com api.githubcopilot.com api.individual.githubcopilot.com api.business.githubcopilot.com api.enterprise.githubcopilot.com; font-src github.githubassets.com; form-action 'self' github.com gist.github.com copilot-workspace.githubnext.com objects-origin.githubusercontent.com; frame-ancestors 'none'; frame-src viewscreen.githubusercontent.com notebooks.githubusercontent.com; img-src 'self' data: blob: github.githubassets.com media.githubusercontent.com camo.githubusercontent.com identicons.github.com avatars.githubusercontent.com private-avatars.githubusercontent.com github-cloud.s3.amazonaws.com objects.githubusercontent.com release-assets.githubusercontent.com secured-user-images.githubusercontent.com/ user-images.githubusercontent.com/ private-user-images.githubusercontent.com opengraph.githubassets.com copilotprodattachments.blob.core.windows.net/github-production-copilot-attachments/ github-production-user-asset-6210df.s3.amazonaws.com customer-stories-feed.github.com spotlights-feed.github.com objects-origin.githubusercontent.com *.githubusercontent.com; manifest-src 'self'; media-src github.com user-images.githubusercontent.com/ secured-user-images.githubusercontent.com/ private-user-images.githubusercontent.com github-production-user-asset-6210df.s3.amazonaws.com gist.github.com; script-src github.githubassets.com; style-src 'unsafe-inline' github.githubassets.com; upgrade-insecure-requests; worker-src github.githubassets.com github.com/assets-cdn/worker/ github.com/assets/ gist.github.com/assets-cdn/worker/
referrer-policy: no-referrer-when-downgrade
server-timing: pull_request_layout-fragment;desc="pull_request_layout fragment";dur=295.25828,conversation_content-fragment;desc="conversation_content fragment";dur=829.776394,conversation_sidebar-fragment;desc="conversation_sidebar fragment";dur=245.856799,nginx;desc="NGINX";dur=0.801459,glb;desc="GLB";dur=96.0095
strict-transport-security: max-age=31536000; includeSubdomains; preload
vary: X-PJAX, X-PJAX-Container, Turbo-Visit, Turbo-Frame, X-Requested-With,Accept-Encoding, Accept, X-Requested-With
x-content-type-options: nosniff
x-frame-options: deny
x-voltron-version: 6a3bf42
x-xss-protection: 0
server: github.com
content-encoding: gzip
accept-ranges: bytes
set-cookie: _gh_sess=MAe%2BagNCKWZlHpzOGjGo8bBIPsh1VbVs3%2FfvrORC2TrheyfZ3TgeXpHlSwdZCTwj6Ks0Chp6fGeosF4uklBCXJL54wKq8N1FTRO5npPwnGmu6TXDTMSU9dxEYwiDC0aJKiQZZnBl8%2FgvXikB5ISblmkeyCpJK%2FxuJ9XAscIX0pobyK5fmY7FDq%2FxD3Q6Ay65dJFrB6IgWaMQ80BLhGr6IpA%2FltWDDqMIZulMiYSO2HODPBEeY1NGo7ocU%2B8i2HSgWb3bp%2BdHjdO7sM9Br0WCRg%3D%3D--%2FFSq%2BJuU0y5xOVmI--XdoLwqpr4iH%2BM%2FhJMiik2g%3D%3D; Path=/; HttpOnly; Secure; SameSite=Lax
set-cookie: _octo=GH1.1.1406729414.1752496643; Path=/; Domain=github.com; Expires=Tue, 14 Jul 2026 12:37:23 GMT; Secure; SameSite=Lax
set-cookie: logged_in=no; Path=/; Domain=github.com; Expires=Tue, 14 Jul 2026 12:37:23 GMT; HttpOnly; Secure; SameSite=Lax
x-github-request-id: DD82:336CDE:11DD9FE:16465EE:6874FA03
Show pixel info under the mouse when previewing image. by RaymondLim · Pull Request #5944 · adobe/brackets · GitHub
Skip to content
Navigation Menu
{{ message }}
This repository was archived by the owner on Sep 6, 2021. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 7.6k
Show pixel info under the mouse when previewing image. #5944
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ent issue near top left corner of the image.
Make some improvements based on the review feedback.
Conflicts: src/editor/ImageViewer.js
Show crosshair cursor if the image is too narrow in width or height.
ghost
assigned
| // If the image size is too narrow in width or height, then | ||
| // show the crosshair cursor since guides are almost invisible | ||
| // in narrow images. | ||
| if (this.naturalWidth < 20 || this.naturalHeight < 20) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I suggest to factor in the scale, i.e. if you have an image that is 22px but you are only seeing it at 27 percent (as possible i.e. when viewing brackets/src/style/images/active_black.png - very wide and small) you'd still not see th crosshair, but it would be useful, the mous position is a bit difficult to see.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good suggestion! fixed.
|
Done with review for now. |
|
@couzteau Ready for re-review. |
|
Done with review. Works great. Preview Images much improved! Merging. |
couzteau
added a commit
that referenced
this pull request
Nov 11, 2013
Show pixel info under the mouse when previewing image.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
None yet
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
You can’t perform that action at this time.
Showing the image tip on the top right of the cursor until there is no room on the right. When no room on the right, then the image tip shows up on the top left of the cursor. We draw two crossing guides to indicate the cursor location. But for an image that is narrow than 20 pixels in width or height, we also show the crosshair cursor since the guides are pretty useless for small images.