| CARVIEW |
Select Language
HTTP/2 200
date: Mon, 14 Jul 2025 16:39:34 GMT
content-type: text/html; charset=utf-8
cache-control: no-cache
content-security-policy: default-src 'none'; base-uri 'self'; child-src github.githubassets.com github.com/assets-cdn/worker/ github.com/assets/ gist.github.com/assets-cdn/worker/; connect-src 'self' uploads.github.com www.githubstatus.com collector.github.com raw.githubusercontent.com api.github.com github-cloud.s3.amazonaws.com github-production-repository-file-5c1aeb.s3.amazonaws.com github-production-upload-manifest-file-7fdce7.s3.amazonaws.com github-production-user-asset-6210df.s3.amazonaws.com *.rel.tunnels.api.visualstudio.com wss://*.rel.tunnels.api.visualstudio.com objects-origin.githubusercontent.com copilot-proxy.githubusercontent.com proxy.individual.githubcopilot.com proxy.business.githubcopilot.com proxy.enterprise.githubcopilot.com *.actions.githubusercontent.com wss://*.actions.githubusercontent.com productionresultssa0.blob.core.windows.net/ productionresultssa1.blob.core.windows.net/ productionresultssa2.blob.core.windows.net/ productionresultssa3.blob.core.windows.net/ productionresultssa4.blob.core.windows.net/ productionresultssa5.blob.core.windows.net/ productionresultssa6.blob.core.windows.net/ productionresultssa7.blob.core.windows.net/ productionresultssa8.blob.core.windows.net/ productionresultssa9.blob.core.windows.net/ productionresultssa10.blob.core.windows.net/ productionresultssa11.blob.core.windows.net/ productionresultssa12.blob.core.windows.net/ productionresultssa13.blob.core.windows.net/ productionresultssa14.blob.core.windows.net/ productionresultssa15.blob.core.windows.net/ productionresultssa16.blob.core.windows.net/ productionresultssa17.blob.core.windows.net/ productionresultssa18.blob.core.windows.net/ productionresultssa19.blob.core.windows.net/ github-production-repository-image-32fea6.s3.amazonaws.com github-production-release-asset-2e65be.s3.amazonaws.com insights.github.com wss://alive.github.com api.githubcopilot.com api.individual.githubcopilot.com api.business.githubcopilot.com api.enterprise.githubcopilot.com; font-src github.githubassets.com; form-action 'self' github.com gist.github.com copilot-workspace.githubnext.com objects-origin.githubusercontent.com; frame-ancestors 'none'; frame-src viewscreen.githubusercontent.com notebooks.githubusercontent.com; img-src 'self' data: blob: github.githubassets.com media.githubusercontent.com camo.githubusercontent.com identicons.github.com avatars.githubusercontent.com private-avatars.githubusercontent.com github-cloud.s3.amazonaws.com objects.githubusercontent.com release-assets.githubusercontent.com secured-user-images.githubusercontent.com/ user-images.githubusercontent.com/ private-user-images.githubusercontent.com opengraph.githubassets.com copilotprodattachments.blob.core.windows.net/github-production-copilot-attachments/ github-production-user-asset-6210df.s3.amazonaws.com customer-stories-feed.github.com spotlights-feed.github.com objects-origin.githubusercontent.com *.githubusercontent.com; manifest-src 'self'; media-src github.com user-images.githubusercontent.com/ secured-user-images.githubusercontent.com/ private-user-images.githubusercontent.com github-production-user-asset-6210df.s3.amazonaws.com gist.github.com; script-src github.githubassets.com; style-src 'unsafe-inline' github.githubassets.com; upgrade-insecure-requests; worker-src github.githubassets.com github.com/assets-cdn/worker/ github.com/assets/ gist.github.com/assets-cdn/worker/
referrer-policy: no-referrer-when-downgrade
server-timing: pull_request_layout-fragment;desc="pull_request_layout fragment";dur=368.524748,conversation_content-fragment;desc="conversation_content fragment";dur=808.911948,conversation_sidebar-fragment;desc="conversation_sidebar fragment";dur=252.961526,nginx;desc="NGINX";dur=0.866588,glb;desc="GLB";dur=95.952534
strict-transport-security: max-age=31536000; includeSubdomains; preload
vary: X-PJAX, X-PJAX-Container, Turbo-Visit, Turbo-Frame, X-Requested-With,Accept-Encoding, Accept, X-Requested-With
x-content-type-options: nosniff
x-frame-options: deny
x-voltron-version: 6a3bf42
x-xss-protection: 0
server: github.com
content-encoding: gzip
accept-ranges: bytes
set-cookie: _gh_sess=iAB7VGsdz9w8TYsO6vHxI2UCtMlMTqQirjGslR%2BCwxQF1qZiPnyWPUiDVHQ%2F%2B9wT9CYED0SoO7B2qWBQvHNSVKvRAK97snxWIsb%2BXiO%2FtRrkShoWu%2Ftekn6qsvXxcrcN6ySnfvqoIJCaAyyfAxy%2BE%2BZdM8QjiL%2Fzgpfbt5dPt6ZK5zasTlB9cwqVX4PgkvNrd1UabmT54Lg8NS3YOr41rWaFmYNde%2BvK%2F%2FYS9RUHKYGiTe0dRPX5%2BhHZh71qOP4x54notm5jmDO9wBz6uCY3Wg%3D%3D--oy%2Fv6k3Z2noaZVFI--mso3Qux0YpAYgZEtZeaEQQ%3D%3D; Path=/; HttpOnly; Secure; SameSite=Lax
set-cookie: _octo=GH1.1.721234157.1752511173; Path=/; Domain=github.com; Expires=Tue, 14 Jul 2026 16:39:33 GMT; Secure; SameSite=Lax
set-cookie: logged_in=no; Path=/; Domain=github.com; Expires=Tue, 14 Jul 2026 16:39:33 GMT; HttpOnly; Secure; SameSite=Lax
x-github-request-id: 9F18:3AC6CB:D19C0F:F86D8F:687532C5
[fi] Replace quotes with correct ones by jukkah · Pull Request #5812 · adobe/brackets · GitHub
Skip to content
Navigation Menu
{{ message }}
This repository was archived by the owner on Sep 6, 2021. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 7.6k
[fi] Replace quotes with correct ones #5812
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@valtlait Could you review this? |
|
I´ve accepted this now. |
ghost
assigned
| @@ -125,7 +125,7 @@ define({ | |||
| "NO_UPDATE_TITLE" : "Olet ajantasalla!", | |||
| "NO_UPDATE_MESSAGE" : "Käytät uusinta versiota sovelluksesta {APP_NAME}.", | |||
|
|
|||
| "FIND_IN_FILES_TITLE" : "kohteelle \"{4}\" {5} - {0} {1} {2} {3}", | |||
| "FIND_IN_FILES_TITLE" : "kohteelle ”{4}” {5} - {0} {1} {2} {3}", | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This would make the finnish localization incosnistent with other languages. Doesn't seem good to merge to me. What's the benefit of the new quotes?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As I said earlier, " is not a quotation mark in Finnish language. The new quote is the most widely used in Finnish so I prefer to use it. Wikipedia, the source of all facts, says that different languages, in this case English and Finnish, have different quotation marks.
I understand that we are handling with quotations. If not, please tell me what they are so I can check Finnish equivalent.
|
Thank @jukkah . that makes sense. Merging. Thanks @valtlait for reviewing. |
|
@jukkah before I can merge this please merge master into this branch |
…-fix Conflicts: src/nls/fi/strings.js Fix also new CSS_QUICK_EDIT_NO_MATCHES key added in adobe#5798.
|
Good to merge now. Thanks @jukkah |
couzteau
added a commit
that referenced
this pull request
Nov 6, 2013
[fi] Replace quotes with correct ones
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
None yet
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
You can’t perform that action at this time.
In Finnish language
\u0022(") is not a valid quotation mark even if it has been used so widely.\u201D(”) is a valid one. [1][1] Section ”Lainausmerkkien nimiä ja muotoja” https://www.cs.tut.fi/~jkorpela/kielenopas/4.7.html#lain-nimet