You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository was archived by the owner on Sep 6, 2021. It is now read-only.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I think the problem was when image stats were asynchronously added to image viewer, so image viewer would render without stats, then render again with a different height (which made image appear to do a small "jump") once the stats were loaded. I noticed this too, but it seems to be fixed now.
I can see the jumping effect now if I set a break point in ImageViewer line 106. Size is still added asynchronously. However it does need the breakpoint. Yet we can show the image after the getMetadata call returns to avoid the potential jumping effect for good. I'd prefer that over static height fo image metadata
@couzteau Another option would be to fetch the metadata in parallel with loading the image, rather than waiting for the image to load, then asking for metadata, then waiting some more.
related #5686
Notably @RaymondLim suggests to rather clip than wrap path, thus we'd be ok with static height. I have no strong preference, but will run this by @larz0
bounced this off @larz0 - ok to go to static metadata height. I will try to add an ellipsis when clipping and add tool tip, so that hidden text can still be seen when hovering over clipped text
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
None yet
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This glitch was caused by images properties loading times and no reserved space for them while properties nodes are a part of centered content.