You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository was archived by the owner on Sep 6, 2021. It is now read-only.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hey, @TomMalbran, this overtakes #3238. I finally got around this long forgotten pull request. I've cherry-picked the old commits on top of master and added some tests. I may be a little bit rusty, so please, check if everything's in there or if I missed something.
@peterflynn@dangoor I've seen that the test gave some issues in the past, so you may want to check it out
And now, I am the one with no time. And I don't even remember much about the original PR. If someone else has time to check this PR, that would be great. If not I could try and check it in a few weeks. Sorry for the delay.
@jbalsas Sorry for the late reply. The tests look good and so does the code besides the comments I made before. But I wasn't able to test since Brackets fails to open. Could you merge with master? I can then do a final test and we can finally merge this :)
@jbalsas I just merged and tested it and it works great. Besides some minor nits, my only concern is if we should show an error when the user selects a column greater than the maximum columns in the line, since there is no visual indication in the editor as to what is happening. If you are busy I could fix the nits and merge it.
CC @larz0 to consider if we should show an error when the given column is greater than the columns in the line.
@TomMalbran I like the current behavior, i.e. cursor stays on the last column. It's obvious that it can't go beyond that and people that use this feature will know this.
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
None yet
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hey, @TomMalbran, this overtakes #3238. I finally got around this long forgotten pull request. I've cherry-picked the old commits on top of master and added some tests. I may be a little bit rusty, so please, check if everything's in there or if I missed something.
@peterflynn @dangoor I've seen that the test gave some issues in the past, so you may want to check it out