| CARVIEW |
Select Language
HTTP/2 200
date: Mon, 14 Jul 2025 21:36:00 GMT
content-type: text/html; charset=utf-8
cache-control: no-cache
content-security-policy: default-src 'none'; base-uri 'self'; child-src github.githubassets.com github.com/assets-cdn/worker/ github.com/assets/ gist.github.com/assets-cdn/worker/; connect-src 'self' uploads.github.com www.githubstatus.com collector.github.com raw.githubusercontent.com api.github.com github-cloud.s3.amazonaws.com github-production-repository-file-5c1aeb.s3.amazonaws.com github-production-upload-manifest-file-7fdce7.s3.amazonaws.com github-production-user-asset-6210df.s3.amazonaws.com *.rel.tunnels.api.visualstudio.com wss://*.rel.tunnels.api.visualstudio.com objects-origin.githubusercontent.com copilot-proxy.githubusercontent.com proxy.individual.githubcopilot.com proxy.business.githubcopilot.com proxy.enterprise.githubcopilot.com *.actions.githubusercontent.com wss://*.actions.githubusercontent.com productionresultssa0.blob.core.windows.net/ productionresultssa1.blob.core.windows.net/ productionresultssa2.blob.core.windows.net/ productionresultssa3.blob.core.windows.net/ productionresultssa4.blob.core.windows.net/ productionresultssa5.blob.core.windows.net/ productionresultssa6.blob.core.windows.net/ productionresultssa7.blob.core.windows.net/ productionresultssa8.blob.core.windows.net/ productionresultssa9.blob.core.windows.net/ productionresultssa10.blob.core.windows.net/ productionresultssa11.blob.core.windows.net/ productionresultssa12.blob.core.windows.net/ productionresultssa13.blob.core.windows.net/ productionresultssa14.blob.core.windows.net/ productionresultssa15.blob.core.windows.net/ productionresultssa16.blob.core.windows.net/ productionresultssa17.blob.core.windows.net/ productionresultssa18.blob.core.windows.net/ productionresultssa19.blob.core.windows.net/ github-production-repository-image-32fea6.s3.amazonaws.com github-production-release-asset-2e65be.s3.amazonaws.com insights.github.com wss://alive.github.com api.githubcopilot.com api.individual.githubcopilot.com api.business.githubcopilot.com api.enterprise.githubcopilot.com; font-src github.githubassets.com; form-action 'self' github.com gist.github.com copilot-workspace.githubnext.com objects-origin.githubusercontent.com; frame-ancestors 'none'; frame-src viewscreen.githubusercontent.com notebooks.githubusercontent.com; img-src 'self' data: blob: github.githubassets.com media.githubusercontent.com camo.githubusercontent.com identicons.github.com avatars.githubusercontent.com private-avatars.githubusercontent.com github-cloud.s3.amazonaws.com objects.githubusercontent.com release-assets.githubusercontent.com secured-user-images.githubusercontent.com/ user-images.githubusercontent.com/ private-user-images.githubusercontent.com opengraph.githubassets.com copilotprodattachments.blob.core.windows.net/github-production-copilot-attachments/ github-production-user-asset-6210df.s3.amazonaws.com customer-stories-feed.github.com spotlights-feed.github.com objects-origin.githubusercontent.com *.githubusercontent.com; manifest-src 'self'; media-src github.com user-images.githubusercontent.com/ secured-user-images.githubusercontent.com/ private-user-images.githubusercontent.com github-production-user-asset-6210df.s3.amazonaws.com gist.github.com; script-src github.githubassets.com; style-src 'unsafe-inline' github.githubassets.com; upgrade-insecure-requests; worker-src github.githubassets.com github.com/assets-cdn/worker/ github.com/assets/ gist.github.com/assets-cdn/worker/
referrer-policy: no-referrer-when-downgrade
server-timing: pull_request_layout-fragment;desc="pull_request_layout fragment";dur=296.738924,conversation_content-fragment;desc="conversation_content fragment";dur=982.288488,conversation_sidebar-fragment;desc="conversation_sidebar fragment";dur=300.266597,nginx;desc="NGINX";dur=1.535843,glb;desc="GLB";dur=95.741726
strict-transport-security: max-age=31536000; includeSubdomains; preload
vary: X-PJAX, X-PJAX-Container, Turbo-Visit, Turbo-Frame, X-Requested-With,Accept-Encoding, Accept, X-Requested-With
x-content-type-options: nosniff
x-frame-options: deny
x-voltron-version: 6a3bf42
x-xss-protection: 0
server: github.com
content-encoding: gzip
accept-ranges: bytes
set-cookie: _gh_sess=3qU2mnbewsx1PmBtl%2Bo%2FDtYoIUVHF4O9Fv2V9xMfWPuIVw1PUjZXyP%2FqR5NyChn%2FYUHFtkDVy%2FDf81QUMtpAWFEBosZb0zx1IHbJW0kXH4TqXU6E3YM2FTAcur3DFia5cABnJPbWyjbk6RK9nppcqFeNAFnZdtMNPYlPK3afcRvDdXN08tSV1HY%2FGK9HhsFnB1IfSG3NNafJLIfbqrsci1wxfrmUbFAWVsCko1D3UE6vZgzxCrKXcNFUh%2B4JrltXxudz%2Bg%2BhrK1QCT9uRl7QCQ%3D%3D--59llpPXaD9aJglVi--5mtfBJgwSk100NpI4ltRpQ%3D%3D; Path=/; HttpOnly; Secure; SameSite=Lax
set-cookie: _octo=GH1.1.877404481.1752528959; Path=/; Domain=github.com; Expires=Tue, 14 Jul 2026 21:35:59 GMT; Secure; SameSite=Lax
set-cookie: logged_in=no; Path=/; Domain=github.com; Expires=Tue, 14 Jul 2026 21:35:59 GMT; HttpOnly; Secure; SameSite=Lax
x-github-request-id: E872:1615CB:81453:B7757:6875783F
Fix for Issue 1617: Removed all references to CodeHintManager from Editor by WebsiteDeveloper · Pull Request #5421 · adobe/brackets · GitHub
Skip to content
Navigation Menu
{{ message }}
This repository was archived by the owner on Sep 6, 2021. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 7.6k
Fix for Issue 1617: Removed all references to CodeHintManager from Editor #5421
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Credits to @jbalsas for finding the fix i incorporated into this pull |
|
@WebsiteDeveloper |
|
@RaymondLim i reverted some of the whitespace changes but decided to stop because i would have to revert them each manually. |
|
Just a heads up, you can view the file changes and ignore any whitespace changes by adding ?w=1 to the end of the url, e.g. https://github.com/adobe/brackets/pull/5421/files?w=1 |
|
Good tip, @TuckerWhitehouse I have verified that #5412 is not re-introduced by this change. |
|
Thanks for checking. @RaymondLim time to review? |
ghost
assigned
| @@ -528,7 +528,7 @@ define(function (require, exports, module) { | |||
| * @param {Editor} editor | |||
| * @param {KeyboardEvent} event | |||
| */ | |||
| function handleKeyEvent(editor, event) { | |||
| function _handleKeyEvent(jqEvent, editor, event) { | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You need to update the JSDoc above by adding the first param jqEvent. Also, please change the function to _handleKeyEvents (plural) so that it has the same name as the one in Editor module.
|
@WebsiteDeveloper Done with initial review. I think you need to merge with master to resolve the conflict. |
|
@RaymondLim merged with master and fixed nits |
| * | ||
| * @param {Event} event | ||
| * @param {Editor} editor | ||
| * @param {{from: Pos, to: Pos, text: Array, origin: String}} changeList |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One more minor nit: String -> string.
|
@RaymondLim fixed. |
|
Looks good. Merging. |
RaymondLim
added a commit
that referenced
this pull request
Oct 12, 2013
Fix for Issue 1617: Removed all references to CodeHintManager from Editor
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
None yet
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
You can’t perform that action at this time.
@dangoor to verify that #5412 wasn't introduced.
@RaymondLim since you were the original reviewer