You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository was archived by the owner on Sep 6, 2021. It is now read-only.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@redmunds Nice job in finding the culprit and the solution. I think we may also improve the performance in js files as we have a couple of getTokenAt() calls with precise=true in extensions/default/JavaScriptCodeHints/Session.js.
@redmunds Can you rebase your changes to the latest master or create a new branch with the latest master and reapply your changes? The code changes look good, but when I run your branch, I didn't see text as I type. It took a while to show up a block of text and then to show JS hints. So it's not clear your changes fix the issue or not.
@RaymondLim There are only 2 commits that change different files, so there's nothing to rebase. I merged the latest code from master, but it was only 13 commits.
The main change should make the initial loading of JS faster, so first hint will display faster. After that it should have no effect. To test this, open 2 files (1 HTML with <script> block, and 1 JS file) and switch back and forth (hints get reloaded whenever you switch to different file). You may also see this improvement with Quick Open of both JS and CSS.
The second change I made for JS Code Hints is general parsing around cursor location. If you can't see a difference, then maybe it should be backed out to reduce risk.
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
None yet
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is for #4608 (please ignore branch name). See bug for details.
@njx @RaymondLim have been following this one.
Are there any other places where we can isolate calls to
getTokenAt()
and set precise=false?