| CARVIEW |
Select Language
HTTP/2 200
date: Mon, 14 Jul 2025 21:31:28 GMT
content-type: text/html; charset=utf-8
cache-control: no-cache
content-security-policy: default-src 'none'; base-uri 'self'; child-src github.githubassets.com github.com/assets-cdn/worker/ github.com/assets/ gist.github.com/assets-cdn/worker/; connect-src 'self' uploads.github.com www.githubstatus.com collector.github.com raw.githubusercontent.com api.github.com github-cloud.s3.amazonaws.com github-production-repository-file-5c1aeb.s3.amazonaws.com github-production-upload-manifest-file-7fdce7.s3.amazonaws.com github-production-user-asset-6210df.s3.amazonaws.com *.rel.tunnels.api.visualstudio.com wss://*.rel.tunnels.api.visualstudio.com objects-origin.githubusercontent.com copilot-proxy.githubusercontent.com proxy.individual.githubcopilot.com proxy.business.githubcopilot.com proxy.enterprise.githubcopilot.com *.actions.githubusercontent.com wss://*.actions.githubusercontent.com productionresultssa0.blob.core.windows.net/ productionresultssa1.blob.core.windows.net/ productionresultssa2.blob.core.windows.net/ productionresultssa3.blob.core.windows.net/ productionresultssa4.blob.core.windows.net/ productionresultssa5.blob.core.windows.net/ productionresultssa6.blob.core.windows.net/ productionresultssa7.blob.core.windows.net/ productionresultssa8.blob.core.windows.net/ productionresultssa9.blob.core.windows.net/ productionresultssa10.blob.core.windows.net/ productionresultssa11.blob.core.windows.net/ productionresultssa12.blob.core.windows.net/ productionresultssa13.blob.core.windows.net/ productionresultssa14.blob.core.windows.net/ productionresultssa15.blob.core.windows.net/ productionresultssa16.blob.core.windows.net/ productionresultssa17.blob.core.windows.net/ productionresultssa18.blob.core.windows.net/ productionresultssa19.blob.core.windows.net/ github-production-repository-image-32fea6.s3.amazonaws.com github-production-release-asset-2e65be.s3.amazonaws.com insights.github.com wss://alive.github.com api.githubcopilot.com api.individual.githubcopilot.com api.business.githubcopilot.com api.enterprise.githubcopilot.com; font-src github.githubassets.com; form-action 'self' github.com gist.github.com copilot-workspace.githubnext.com objects-origin.githubusercontent.com; frame-ancestors 'none'; frame-src viewscreen.githubusercontent.com notebooks.githubusercontent.com; img-src 'self' data: blob: github.githubassets.com media.githubusercontent.com camo.githubusercontent.com identicons.github.com avatars.githubusercontent.com private-avatars.githubusercontent.com github-cloud.s3.amazonaws.com objects.githubusercontent.com release-assets.githubusercontent.com secured-user-images.githubusercontent.com/ user-images.githubusercontent.com/ private-user-images.githubusercontent.com opengraph.githubassets.com copilotprodattachments.blob.core.windows.net/github-production-copilot-attachments/ github-production-user-asset-6210df.s3.amazonaws.com customer-stories-feed.github.com spotlights-feed.github.com objects-origin.githubusercontent.com *.githubusercontent.com; manifest-src 'self'; media-src github.com user-images.githubusercontent.com/ secured-user-images.githubusercontent.com/ private-user-images.githubusercontent.com github-production-user-asset-6210df.s3.amazonaws.com gist.github.com; script-src github.githubassets.com; style-src 'unsafe-inline' github.githubassets.com; upgrade-insecure-requests; worker-src github.githubassets.com github.com/assets-cdn/worker/ github.com/assets/ gist.github.com/assets-cdn/worker/
referrer-policy: no-referrer-when-downgrade
server-timing: pull_request_layout-fragment;desc="pull_request_layout fragment";dur=367.379232,conversation_content-fragment;desc="conversation_content fragment";dur=826.596313,conversation_sidebar-fragment;desc="conversation_sidebar fragment";dur=273.995239,nginx;desc="NGINX";dur=1.274868,glb;desc="GLB";dur=95.974869
strict-transport-security: max-age=31536000; includeSubdomains; preload
vary: X-PJAX, X-PJAX-Container, Turbo-Visit, Turbo-Frame, X-Requested-With,Accept-Encoding, Accept, X-Requested-With
x-content-type-options: nosniff
x-frame-options: deny
x-voltron-version: 6a3bf42
x-xss-protection: 0
server: github.com
content-encoding: gzip
accept-ranges: bytes
set-cookie: _gh_sess=RJ0Iy66nzFZ0V4SAjQZwsfnf8QwbnBuug9vrMLlXok7aeUEyAltynixUGT4J9DbGO%2FoPJsDdXD7zqye8kQfsqU6vARk8wRZy2J6ZnCwRtNEDrGJD8mfJHUv1BoDpmwTXVCuVLeD1JnleoxcDiKMtgmWZ9DFj2s7taQ9qTakTKnO7QxWQjfR2vDwBkKxssFwQ2J5Z2ykP0xjp9GTQTWjqkNRAIT0sBbXyKU%2B8gFZX2NVY9yEawR1RExI9Nv5%2B4eLNoO3qzrK9AtCb8cUqtIau3g%3D%3D--S0rirTiAZkHLynhF--yg%2Bq1LVJorCtfd66CAwiMg%3D%3D; Path=/; HttpOnly; Secure; SameSite=Lax
set-cookie: _octo=GH1.1.1201040939.1752528687; Path=/; Domain=github.com; Expires=Tue, 14 Jul 2026 21:31:27 GMT; Secure; SameSite=Lax
set-cookie: logged_in=no; Path=/; Domain=github.com; Expires=Tue, 14 Jul 2026 21:31:27 GMT; HttpOnly; Secure; SameSite=Lax
x-github-request-id: BFE2:B4F9F:7B037:AEE6E:6875772F
Menus.removeMenu cleanup: remove all menu items and dividers prior to removing menu by lkcampbell · Pull Request #5384 · adobe/brackets · GitHub
Skip to content
Navigation Menu
{{ message }}
This repository was archived by the owner on Sep 6, 2021. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 7.6k
Menus.removeMenu cleanup: remove all menu items and dividers prior to removing menu #5384
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This fix makes sure that none of the menu items and dividers on the menu being removed are orphaned. It is the final piece of functionality I need (hopefully) to implement a solution for issue #5078. |
ghost
assigned
|
@lkcampbell Thanks for taking care of all the necessary changes for issue #5078. Unfortunately, I won't be able to review and merge this for sprint 32. Will review it when sprint 33 starts on next week. |
|
@RaymondLim, if you get some time to commit this pull request this week or early next week, I have the time to submit the "Reload without user extension" pull request next week. That way, we might be able to get the feature in for Sprint 33. |
| @@ -877,6 +929,9 @@ define(function (require, exports, module) { | |||
| * Extensions should use the following format: "author.myextension.mymenuname". | |||
| */ | |||
| function removeMenu(id) { | |||
| var menu, | |||
| commandID = ""; | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor nit: Please remove those extra spaces before =.
|
@lkcampbell |
|
@RaymondLim, changes for code review done. |
RaymondLim
added a commit
that referenced
this pull request
Oct 21, 2013
Menus.removeMenu cleanup: remove all menu items and dividers prior to removing menu
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
None yet
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
You can’t perform that action at this time.
No description provided.