Remove the ability to switch language to the current language #5287

marcelgerber · 2013-09-21T20:28:13Z

The "Restart brackets" button will be disabled if you select the current
lang in the "Switch Language" dialog.

Tested on Windows 8 with Brackets 0.32 master c05cfd5

The "Restart brackets" button will be disabled if you select the current lang in the "Switch Language" dialog. Tested on Windows 8 with Brackets 0.32 master c05cfd5

WebsiteDeveloper · 2013-09-21T21:14:52Z

@SAplayer it this change really necessary?
I think its reasonable to leave the restart button deactivated while no change requiring an actual restart was made.

marcelgerber · 2013-09-21T21:24:29Z

Yes, and currently it isn't.
For example, if you currenty have the system setting, you can still change it to the system setting.
It's not important, but just a little improvement.

WebsiteDeveloper · 2013-09-21T21:35:01Z

ok i see i just didn't see it happen, but now i can reproduce it when i have for example system standard selected and then select English and then again system standard, then your change comes into action.
I never noticed this, but its good you fixed it.

marcelgerber · 2013-09-25T16:57:14Z

How about merging it?

WebsiteDeveloper · 2013-09-25T19:06:00Z

i'm not a committer. i assume @JeffryBooher will merge it once he has had time to do a short review.

JeffryBooher · 2013-09-25T20:19:11Z

src/extensions/default/DebugCommands/main.js

@@ -151,7 +151,7 @@ define(function (require, exports, module) {

                function setLanguage(event) {
                    locale = $select.val();
-                    $submit.prop("disabled", false);
+                    $submit.prop("disabled", locale === (curLocale === null ? "" : curLocale));


use the OR operator here instead of inline IF: locale === (currLocal || "")

Thanks for the tip ;)

marcelgerber · 2013-10-01T20:42:03Z

@JeffryBooher Have you reviewed it?

JeffryBooher · 2013-10-04T07:56:47Z

@SAplayer sorry been heads down on another story. This looks good. Merging

Remove the ability to switch language to the current language

SAplayer added 2 commits September 21, 2013 22:28

Remove the ability to switch language to the current language

21bd1d4

The "Restart brackets" button will be disabled if you select the current lang in the "Switch Language" dialog. Tested on Windows 8 with Brackets 0.32 master c05cfd5

Fixed indent

22d0c8d

ghost assigned JeffryBooher Sep 23, 2013

JeffryBooher reviewed Sep 25, 2013
View reviewed changes

Update main.js

b17c774

Thanks for the tip ;)

JeffryBooher added a commit that referenced this pull request Oct 4, 2013

Merge pull request #5287 from SAPlayer/patch-5

4f1f7c0

Remove the ability to switch language to the current language

JeffryBooher merged commit 4f1f7c0 into adobe:master Oct 4, 2013

marcelgerber deleted the patch-5 branch October 4, 2013 13:40

core-ai-bot mentioned this pull request Aug 29, 2021

[CLOSED] Remove the ability to switch language to the current language brackets-archive/bracketsIssues#4864

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Remove the ability to switch language to the current language #5287

Remove the ability to switch language to the current language #5287

Uh oh!

marcelgerber commented Sep 21, 2013

Uh oh!

WebsiteDeveloper commented Sep 21, 2013

Uh oh!

marcelgerber commented Sep 21, 2013

Uh oh!

WebsiteDeveloper commented Sep 21, 2013

Uh oh!

marcelgerber commented Sep 25, 2013

Uh oh!

WebsiteDeveloper commented Sep 25, 2013

Uh oh!

JeffryBooher Sep 25, 2013

Uh oh!

marcelgerber commented Oct 1, 2013

Uh oh!

JeffryBooher commented Oct 4, 2013

Uh oh!

Uh oh!

Remove the ability to switch language to the current language #5287

Remove the ability to switch language to the current language #5287

Uh oh!

Conversation

marcelgerber commented Sep 21, 2013

Uh oh!

WebsiteDeveloper commented Sep 21, 2013

Uh oh!

marcelgerber commented Sep 21, 2013

Uh oh!

WebsiteDeveloper commented Sep 21, 2013

Uh oh!

marcelgerber commented Sep 25, 2013

Uh oh!

WebsiteDeveloper commented Sep 25, 2013

Uh oh!

JeffryBooher Sep 25, 2013

Choose a reason for hiding this comment

Uh oh!

marcelgerber commented Oct 1, 2013

Uh oh!

JeffryBooher commented Oct 4, 2013

Uh oh!

Uh oh!