You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository was archived by the owner on Sep 6, 2021. It is now read-only.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I ended up adding in another method, Menus.getAllMenus(), because I needed it to iterate though all menus for issue #5078.
In order to run the unit tests for the HTML version of removeMenu(), a couple of temporary changes need to be made.
In src/utils/Global.js, set global.brackets.nativeMenus = false. This forces the HTML menus to turn on.
In test/spec/Menu-test.js, find the following code and comment it out:
if(!brackets.inBrowser){return;}
Doing this assures that the HTML menu unit tests are run. Note that the last five unit tests, which look at context menus, will still fail. Regardless, you can confirm that there are no failures in any of the other tests, including the new removeMenu tests.
I ran the unit tests for this with the dark shell and they all still passed. @lkcampbell you should build the dark shell and make sure it behaves as expected.
@JeffryBooher, agreed. I would like to test the functionality on the dark shell before we consider merging this PR. My schedule is a bit hectic this week so I'm not 100% sure I will have the time to do a build. If that is the case, I can test it on the next Sprint and we can merge this PR then.
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
None yet
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix issue #5210: Adding Menus.removeMenu() and Menus.getAllMenus()