You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository was archived by the owner on Sep 6, 2021. It is now read-only.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@erichstark quite a nice work ... but I don't know how the different plurals should be handled in the future ... you must agree the final result will sound a bit strange. Saying that, there's nothing you can do with it here.
@zaggino Yes, you are right. But I can't do it more with that problem. I think that base of Slovak translation is okay and some of strings can be fixed in future release to fit better.
Interesting...I know there are a number of languages with varying plurals for different numbers. I wonder if there's some special kind of substitution syntax we could make up to handle this generally, and augment StringUtils.format() to handle it. I can't think of anything simple...it would have to let you enumerate various numbers or number ranges and give an associated plural.
Seems like this problem must have been solved in other localization string table systems...wonder if there's any format we could use as a reference.
(BTW, I'm not saying we have to solve that before merging this :) - if you guys are comfortable with it for now, we can merge it and file a bug to solve that problem later.)
@njx I think it's good to merge and it's a good work from @erichstark . I just felt that it was important to mention the plural problem in Slovak language :-)
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
None yet
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.