| CARVIEW |
Select Language
HTTP/2 200
date: Thu, 17 Jul 2025 10:12:00 GMT
content-type: text/html; charset=utf-8
cache-control: no-cache
content-security-policy: default-src 'none'; base-uri 'self'; child-src github.githubassets.com github.com/assets-cdn/worker/ github.com/assets/ gist.github.com/assets-cdn/worker/; connect-src 'self' uploads.github.com www.githubstatus.com collector.github.com raw.githubusercontent.com api.github.com github-cloud.s3.amazonaws.com github-production-repository-file-5c1aeb.s3.amazonaws.com github-production-upload-manifest-file-7fdce7.s3.amazonaws.com github-production-user-asset-6210df.s3.amazonaws.com *.rel.tunnels.api.visualstudio.com wss://*.rel.tunnels.api.visualstudio.com objects-origin.githubusercontent.com copilot-proxy.githubusercontent.com proxy.individual.githubcopilot.com proxy.business.githubcopilot.com proxy.enterprise.githubcopilot.com *.actions.githubusercontent.com wss://*.actions.githubusercontent.com productionresultssa0.blob.core.windows.net/ productionresultssa1.blob.core.windows.net/ productionresultssa2.blob.core.windows.net/ productionresultssa3.blob.core.windows.net/ productionresultssa4.blob.core.windows.net/ productionresultssa5.blob.core.windows.net/ productionresultssa6.blob.core.windows.net/ productionresultssa7.blob.core.windows.net/ productionresultssa8.blob.core.windows.net/ productionresultssa9.blob.core.windows.net/ productionresultssa10.blob.core.windows.net/ productionresultssa11.blob.core.windows.net/ productionresultssa12.blob.core.windows.net/ productionresultssa13.blob.core.windows.net/ productionresultssa14.blob.core.windows.net/ productionresultssa15.blob.core.windows.net/ productionresultssa16.blob.core.windows.net/ productionresultssa17.blob.core.windows.net/ productionresultssa18.blob.core.windows.net/ productionresultssa19.blob.core.windows.net/ github-production-repository-image-32fea6.s3.amazonaws.com github-production-release-asset-2e65be.s3.amazonaws.com insights.github.com wss://alive.github.com api.githubcopilot.com api.individual.githubcopilot.com api.business.githubcopilot.com api.enterprise.githubcopilot.com; font-src github.githubassets.com; form-action 'self' github.com gist.github.com copilot-workspace.githubnext.com objects-origin.githubusercontent.com; frame-ancestors 'none'; frame-src viewscreen.githubusercontent.com notebooks.githubusercontent.com; img-src 'self' data: blob: github.githubassets.com media.githubusercontent.com camo.githubusercontent.com identicons.github.com avatars.githubusercontent.com private-avatars.githubusercontent.com github-cloud.s3.amazonaws.com objects.githubusercontent.com release-assets.githubusercontent.com secured-user-images.githubusercontent.com/ user-images.githubusercontent.com/ private-user-images.githubusercontent.com opengraph.githubassets.com copilotprodattachments.blob.core.windows.net/github-production-copilot-attachments/ github-production-user-asset-6210df.s3.amazonaws.com customer-stories-feed.github.com spotlights-feed.github.com objects-origin.githubusercontent.com *.githubusercontent.com; manifest-src 'self'; media-src github.com user-images.githubusercontent.com/ secured-user-images.githubusercontent.com/ private-user-images.githubusercontent.com github-production-user-asset-6210df.s3.amazonaws.com gist.github.com; script-src github.githubassets.com; style-src 'unsafe-inline' github.githubassets.com; upgrade-insecure-requests; worker-src github.githubassets.com github.com/assets-cdn/worker/ github.com/assets/ gist.github.com/assets-cdn/worker/
referrer-policy: no-referrer-when-downgrade
server-timing: pull_request_layout-fragment;desc="pull_request_layout fragment";dur=327.76379,conversation_content-fragment;desc="conversation_content fragment";dur=728.247102,conversation_sidebar-fragment;desc="conversation_sidebar fragment";dur=217.367453,nginx;desc="NGINX";dur=0.696045,glb;desc="GLB";dur=101.391003
strict-transport-security: max-age=31536000; includeSubdomains; preload
vary: X-PJAX, X-PJAX-Container, Turbo-Visit, Turbo-Frame, X-Requested-With,Accept-Encoding, Accept, X-Requested-With
x-content-type-options: nosniff
x-frame-options: deny
x-voltron-version: fd8fbbc
x-xss-protection: 0
server: github.com
content-encoding: gzip
accept-ranges: bytes
set-cookie: _gh_sess=TusnEytIIPNBHq30f2r0ku1toz9vq0zvy27TVdxGhocMC7b%2FauVu81MMRD2nnyo0US0BrcvnpW09rhDcxoP7x3pu%2F3PRoAorOdr2Sn6giwsuKdnXF9BH3XckouWc89T2TnuihWLwFyeOsQv%2FDw95Y%2FkgjqdqIuMsjGbWog9FtYxBJG6abkBkMyRo1WgL%2BwbHgCllMhGaJt9HC2pcMIrLILYjG6nASDfkDpwG2bPt2elvVTqH2%2BeIkJ3kC8zefK8hT%2FJN9FT%2FUpHjNSPG1gDnkw%3D%3D--mLYvQWsOOmLY10hT--yiwwPsADzXLH76VuSK3mew%3D%3D; Path=/; HttpOnly; Secure; SameSite=Lax
set-cookie: _octo=GH1.1.1382630922.1752747119; Path=/; Domain=github.com; Expires=Fri, 17 Jul 2026 10:11:59 GMT; Secure; SameSite=Lax
set-cookie: logged_in=no; Path=/; Domain=github.com; Expires=Fri, 17 Jul 2026 10:11:59 GMT; HttpOnly; Secure; SameSite=Lax
x-github-request-id: EBE8:A7B5F:17A5B:1A3FF:6878CC6F
Improvements to the Inline Editor Tests by TomMalbran · Pull Request #4598 · adobe/brackets · GitHub
Skip to content
Navigation Menu
{{ message }}
This repository was archived by the owner on Sep 6, 2021. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 7.6k
Improvements to the Inline Editor Tests #4598
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned
|
@TomMalbran I'm seeing a failure in |
|
@jasonsanjose Yes, I was able to reproduce it, but it got fixed with the use of runs when closing all the files, where using just 1 runs worked, but using 2 didn't. |
|
@TomMalbran I merged #4581. Can you update this branch to fix the conflicts? Thanks! |
|
@jasonsanjose PR updated. I was still able to get |
| var $dlg = _testWindow.$(".modal.instance"); | ||
| if ($dlg.length) { | ||
| clickDialogButton("dontsave"); | ||
| } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This could be replaced with Dialogs.cancelModalDialogIfOpen if it could receive an additional and optional button ID parameter.
|
Ok. Given the state of or build machine (integration tests run out of memory), I'd rather take this fix and the new failures and address those failures separately. |
jasonsanjose
added a commit
that referenced
this pull request
Aug 1, 2013
Improvements to the Inline Editor Tests
This was referenced Aug 1, 2013
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
None yet
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
You can’t perform that action at this time.
This commit basically joins all the
htmlToCSSProvidertests inside the Inline Editor Tests into the same window. These are lots of tests where each used a single window, so this makes it faster and nicer to test. There are 3 test left that check for the Inline editor priority were each use their own window since I wasn't sure how to best change those test to be handled inside the same window. But anyway the testing is a lot nicer.This branch is based on #4581, so is best to merge that one first.