| CARVIEW |
Select Language
HTTP/2 200
date: Mon, 14 Jul 2025 23:49:06 GMT
content-type: text/html; charset=utf-8
cache-control: no-cache
content-security-policy: default-src 'none'; base-uri 'self'; child-src github.githubassets.com github.com/assets-cdn/worker/ github.com/assets/ gist.github.com/assets-cdn/worker/; connect-src 'self' uploads.github.com www.githubstatus.com collector.github.com raw.githubusercontent.com api.github.com github-cloud.s3.amazonaws.com github-production-repository-file-5c1aeb.s3.amazonaws.com github-production-upload-manifest-file-7fdce7.s3.amazonaws.com github-production-user-asset-6210df.s3.amazonaws.com *.rel.tunnels.api.visualstudio.com wss://*.rel.tunnels.api.visualstudio.com objects-origin.githubusercontent.com copilot-proxy.githubusercontent.com proxy.individual.githubcopilot.com proxy.business.githubcopilot.com proxy.enterprise.githubcopilot.com *.actions.githubusercontent.com wss://*.actions.githubusercontent.com productionresultssa0.blob.core.windows.net/ productionresultssa1.blob.core.windows.net/ productionresultssa2.blob.core.windows.net/ productionresultssa3.blob.core.windows.net/ productionresultssa4.blob.core.windows.net/ productionresultssa5.blob.core.windows.net/ productionresultssa6.blob.core.windows.net/ productionresultssa7.blob.core.windows.net/ productionresultssa8.blob.core.windows.net/ productionresultssa9.blob.core.windows.net/ productionresultssa10.blob.core.windows.net/ productionresultssa11.blob.core.windows.net/ productionresultssa12.blob.core.windows.net/ productionresultssa13.blob.core.windows.net/ productionresultssa14.blob.core.windows.net/ productionresultssa15.blob.core.windows.net/ productionresultssa16.blob.core.windows.net/ productionresultssa17.blob.core.windows.net/ productionresultssa18.blob.core.windows.net/ productionresultssa19.blob.core.windows.net/ github-production-repository-image-32fea6.s3.amazonaws.com github-production-release-asset-2e65be.s3.amazonaws.com insights.github.com wss://alive.github.com api.githubcopilot.com api.individual.githubcopilot.com api.business.githubcopilot.com api.enterprise.githubcopilot.com; font-src github.githubassets.com; form-action 'self' github.com gist.github.com copilot-workspace.githubnext.com objects-origin.githubusercontent.com; frame-ancestors 'none'; frame-src viewscreen.githubusercontent.com notebooks.githubusercontent.com; img-src 'self' data: blob: github.githubassets.com media.githubusercontent.com camo.githubusercontent.com identicons.github.com avatars.githubusercontent.com private-avatars.githubusercontent.com github-cloud.s3.amazonaws.com objects.githubusercontent.com release-assets.githubusercontent.com secured-user-images.githubusercontent.com/ user-images.githubusercontent.com/ private-user-images.githubusercontent.com opengraph.githubassets.com copilotprodattachments.blob.core.windows.net/github-production-copilot-attachments/ github-production-user-asset-6210df.s3.amazonaws.com customer-stories-feed.github.com spotlights-feed.github.com objects-origin.githubusercontent.com *.githubusercontent.com; manifest-src 'self'; media-src github.com user-images.githubusercontent.com/ secured-user-images.githubusercontent.com/ private-user-images.githubusercontent.com github-production-user-asset-6210df.s3.amazonaws.com gist.github.com; script-src github.githubassets.com; style-src 'unsafe-inline' github.githubassets.com; upgrade-insecure-requests; worker-src github.githubassets.com github.com/assets-cdn/worker/ github.com/assets/ gist.github.com/assets-cdn/worker/
referrer-policy: no-referrer-when-downgrade
server-timing: pull_request_layout-fragment;desc="pull_request_layout fragment";dur=311.63984,conversation_content-fragment;desc="conversation_content fragment";dur=892.754057,conversation_sidebar-fragment;desc="conversation_sidebar fragment";dur=196.793512,nginx;desc="NGINX";dur=1.352801,glb;desc="GLB";dur=95.585778
strict-transport-security: max-age=31536000; includeSubdomains; preload
vary: X-PJAX, X-PJAX-Container, Turbo-Visit, Turbo-Frame, X-Requested-With,Accept-Encoding, Accept, X-Requested-With
x-content-type-options: nosniff
x-frame-options: deny
x-voltron-version: 6a3bf42
x-xss-protection: 0
server: github.com
content-encoding: gzip
accept-ranges: bytes
set-cookie: _gh_sess=murscQNqCbhcmK2wE8fHVK%2FIViH8j%2FqEs84TMfNWufRc2NAb4sKhD58%2Bc1lyK4kAPbaQ%2B4CABIzbpX3Pxt0%2BoeHGaxv%2F8u1X2w%2FKMjWJ5aPrwUqcpS%2FoUYj3t5GQkrS2xXwGNnJn5giALIV6XaIbbuuV0aVIallIdfcnGCGo7dbBog939ZlvXcvrxZbHSfssZKmpgsNEYPX3aOMD6039cpdR6p9DCrCvGXmSKMNElW9%2BwjZVHJ9OTBsEIBsXUqz7Z0RL6hEueviQ7E4leYjkGQ%3D%3D--poY%2B28%2Fo02BQtImu--%2Fatqw4NZb22NL9vE%2F06Pyw%3D%3D; Path=/; HttpOnly; Secure; SameSite=Lax
set-cookie: _octo=GH1.1.598100201.1752536945; Path=/; Domain=github.com; Expires=Tue, 14 Jul 2026 23:49:05 GMT; Secure; SameSite=Lax
set-cookie: logged_in=no; Path=/; Domain=github.com; Expires=Tue, 14 Jul 2026 23:49:05 GMT; HttpOnly; Secure; SameSite=Lax
x-github-request-id: E480:3210C2:F6A4C:1704D0:68759771
Confirm folder delete - fixes issue #4446 by gmp · Pull Request #4515 · adobe/brackets · GitHub
Skip to content
Navigation Menu
{{ message }}
This repository was archived by the owner on Sep 6, 2021. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 7.6k
Confirm folder delete - fixes issue #4446 #4515
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -103,6 +103,8 @@ define({ | |||
| "SAVE_CLOSE_MESSAGE" : "Do you want to save the changes you made in the document <span class='dialog-filename'>{0}</span>?", | |||
| "SAVE_CLOSE_MULTI_MESSAGE" : "Do you want to save your changes to the following files?", | |||
| "EXT_MODIFIED_TITLE" : "External Changes", | |||
| "CONFIRM_FOLDER_DELETE_TITLE" : "Confirm Delete", | |||
| "CONFIRM_FOLDER_DELETE" : "Are you sure you want to delete the folder?", | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To show the file, use Are you sure you want to delete the folder <span class='dialog-filename'>{0}</span>? or similar. After using StringUtils.format, the folder name will replace {0} in the string.
|
This works great. Thanks for your work in this. I added a few comments around. |
|
@TomMalbran Thanks for the quick feedback Tom! Made the requested changes. Let me know if there's anything else. Look forward to diving in deeper in the coming days! |
ghost
assigned
|
Assign to @TomMalbran |
| { | ||
| className : Dialogs.DIALOG_BTN_CLASS_PRIMARY, | ||
| id : Dialogs.DIALOG_BTN_OK, | ||
| text : Strings.CMD_FILE_DELETE |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actually I prefer if this was a new string. If we ever change the name of the Command, this button should still be delete. Could you add the new string? Place it close to CANCEL and OK, as is the name of the button.
|
@g-palmer Thanks for the updates. I have one final comment. After that, we can merge, but since this adds new strings and we are past the UI is freeze. Will have to wait till the start of the next Sprint, around the 25th. |
|
Made the change and added Strings.DELETE. I think this is what you were looking for. Thanks again! |
|
Yes. Thanks. Will have to wait for the next Sprint to merge as mentioned. |
|
Yep. No worries. Glad it worked. |
|
We are in Sprint 29, so we can merge this now :) |
TomMalbran
added a commit
that referenced
this pull request
Aug 1, 2013
Confirm folder delete - fixes issue #4446
|
Woohoo! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
None yet
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
You can’t perform that action at this time.
Added confirm delete modal dialog when user deletes folder (not file) - issue #4446.
Passes lint and all tests. Have not added new tests (doesn't look like tests for file delete are in the DocumentCommandHandlers-test.js), but I'd love to add some!
Signed CLA.
Let me know if there's anything else I can do!