You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository was archived by the owner on Sep 6, 2021. It is now read-only.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Code mirror's matchTags extension only highlight the other tag. In the above screenshot, i put cursor on start tag <form, but it only highlights the other tag </form>. If you want to to highlight both tags, i can rewrite this extension for brackets.
This is awesome @sathyamoorthi. I'm wondering if we could make it so that it highlights the end tag when the cursor is anywhere within > and < so that we don't have to consciously target the tag name when the start tag is long due to attributes. Thoughts?
@sathyamoorthi@larz0 can we highlight both tags? I find it a little unbalanced if we just highlight the one. We already highlight open and close brace and other editors highlight open and close tags.
@njx what do you think? Larz and I agree that it looks more balanced with both open and close tags highlighted but which option do we go with? I'm not as familiar with how code-mirror works and the politics around changing the code-mirror code base but it sounds like we may have to do the work ourselves. @sathyamoorthi already has some of the code done (sans the performance enhancement) it would be pretty straight forward to just take that change.
I guess the other option is that we fork the addon and create a new one with a different name and it's never committed back to code-mirror.
Maybe Marijnh would accept the change it was made as an option on the addon, and not active by default? Which would leave the behavior as it is by default and add the one we desire with an additional option. Might be worth asking him first.
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
None yet
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tag highlight functionality added.
_some tracks_
Google Group Discussion
Trello Card
#3069
Code mirror's matchTags extension only highlight the other tag. In the above screenshot, i put cursor on start tag <form, but it only highlights the other tag </form>. If you want to to highlight both tags, i can rewrite this extension for brackets.