| CARVIEW |
Select Language
HTTP/2 200
date: Wed, 16 Jul 2025 15:01:36 GMT
content-type: text/html; charset=utf-8
cache-control: no-cache
content-security-policy: default-src 'none'; base-uri 'self'; child-src github.githubassets.com github.com/assets-cdn/worker/ github.com/assets/ gist.github.com/assets-cdn/worker/; connect-src 'self' uploads.github.com www.githubstatus.com collector.github.com raw.githubusercontent.com api.github.com github-cloud.s3.amazonaws.com github-production-repository-file-5c1aeb.s3.amazonaws.com github-production-upload-manifest-file-7fdce7.s3.amazonaws.com github-production-user-asset-6210df.s3.amazonaws.com *.rel.tunnels.api.visualstudio.com wss://*.rel.tunnels.api.visualstudio.com objects-origin.githubusercontent.com copilot-proxy.githubusercontent.com proxy.individual.githubcopilot.com proxy.business.githubcopilot.com proxy.enterprise.githubcopilot.com *.actions.githubusercontent.com wss://*.actions.githubusercontent.com productionresultssa0.blob.core.windows.net/ productionresultssa1.blob.core.windows.net/ productionresultssa2.blob.core.windows.net/ productionresultssa3.blob.core.windows.net/ productionresultssa4.blob.core.windows.net/ productionresultssa5.blob.core.windows.net/ productionresultssa6.blob.core.windows.net/ productionresultssa7.blob.core.windows.net/ productionresultssa8.blob.core.windows.net/ productionresultssa9.blob.core.windows.net/ productionresultssa10.blob.core.windows.net/ productionresultssa11.blob.core.windows.net/ productionresultssa12.blob.core.windows.net/ productionresultssa13.blob.core.windows.net/ productionresultssa14.blob.core.windows.net/ productionresultssa15.blob.core.windows.net/ productionresultssa16.blob.core.windows.net/ productionresultssa17.blob.core.windows.net/ productionresultssa18.blob.core.windows.net/ productionresultssa19.blob.core.windows.net/ github-production-repository-image-32fea6.s3.amazonaws.com github-production-release-asset-2e65be.s3.amazonaws.com insights.github.com wss://alive.github.com api.githubcopilot.com api.individual.githubcopilot.com api.business.githubcopilot.com api.enterprise.githubcopilot.com; font-src github.githubassets.com; form-action 'self' github.com gist.github.com copilot-workspace.githubnext.com objects-origin.githubusercontent.com; frame-ancestors 'none'; frame-src viewscreen.githubusercontent.com notebooks.githubusercontent.com; img-src 'self' data: blob: github.githubassets.com media.githubusercontent.com camo.githubusercontent.com identicons.github.com avatars.githubusercontent.com private-avatars.githubusercontent.com github-cloud.s3.amazonaws.com objects.githubusercontent.com release-assets.githubusercontent.com secured-user-images.githubusercontent.com/ user-images.githubusercontent.com/ private-user-images.githubusercontent.com opengraph.githubassets.com copilotprodattachments.blob.core.windows.net/github-production-copilot-attachments/ github-production-user-asset-6210df.s3.amazonaws.com customer-stories-feed.github.com spotlights-feed.github.com objects-origin.githubusercontent.com *.githubusercontent.com; manifest-src 'self'; media-src github.com user-images.githubusercontent.com/ secured-user-images.githubusercontent.com/ private-user-images.githubusercontent.com github-production-user-asset-6210df.s3.amazonaws.com gist.github.com; script-src github.githubassets.com; style-src 'unsafe-inline' github.githubassets.com; upgrade-insecure-requests; worker-src github.githubassets.com github.com/assets-cdn/worker/ github.com/assets/ gist.github.com/assets-cdn/worker/
referrer-policy: no-referrer-when-downgrade
server-timing: pull_request_layout-fragment;desc="pull_request_layout fragment";dur=366.303339,conversation_content-fragment;desc="conversation_content fragment";dur=834.447708,conversation_sidebar-fragment;desc="conversation_sidebar fragment";dur=214.016554,nginx;desc="NGINX";dur=1.56528,glb;desc="GLB";dur=103.109281
strict-transport-security: max-age=31536000; includeSubdomains; preload
vary: X-PJAX, X-PJAX-Container, Turbo-Visit, Turbo-Frame, X-Requested-With,Accept-Encoding, Accept, X-Requested-With
x-content-type-options: nosniff
x-frame-options: deny
x-voltron-version: fd8fbbc
x-xss-protection: 0
server: github.com
content-encoding: gzip
accept-ranges: bytes
set-cookie: _gh_sess=rxEqCVSBEoArU2fQERjPL9tzEE5%2BeS6kENp2moWxGTUIwAexo8UfsI0dRBJZxxsDp9oXTcjMUICgPL7oVAX3Hackd%2Bqipo0UYZeV9IB1yJhYNSA2TftcPcrbVVgotTjkcCva%2FQnqw30IDqR%2FWbpgrJFzxegra9%2FmYZdvWWwUicCRL9ewmQ0gnJ8lkG6hPspvYjTT4iZcs8wSvBkNuCcWDx3DwmMy8Bx5xbmBGaNY4q6sCsYr7a%2FQ8QjbODxUYf6d8gSIXAIz2CYElXViLQh3vQ%3D%3D--uT0Qp%2BJyztCfvc%2F6--4cEpTb%2BWPv00ARTI33nGJA%3D%3D; Path=/; HttpOnly; Secure; SameSite=Lax
set-cookie: _octo=GH1.1.185549378.1752678095; Path=/; Domain=github.com; Expires=Thu, 16 Jul 2026 15:01:35 GMT; Secure; SameSite=Lax
set-cookie: logged_in=no; Path=/; Domain=github.com; Expires=Thu, 16 Jul 2026 15:01:35 GMT; HttpOnly; Secure; SameSite=Lax
x-github-request-id: D744:938B:D704A2:FEE217:6877BECF
Consolidate color matching regex and share across extensions by oslego · Pull Request #4079 · adobe/brackets · GitHub
Skip to content
Navigation Menu
{{ message }}
This repository was archived by the owner on Sep 6, 2021. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 7.6k
Consolidate color matching regex and share across extensions #4079
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned
|
Open to @RaymondLim |
|
@oslego Hey Razvan - @RaymondLim is out this week; is it okay if this waits till next week to get merged? Thanks. |
|
I'm ok to wait. On Tuesday, June 4, 2013, Narciso Jaramillo wrote:
|
| @@ -0,0 +1,44 @@ | |||
| /* | |||
| * Copyright (c) 2012 Adobe Systems Incorporated. All rights reserved. | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should be the year file was created, so change to 2013.
|
Added changes per @redmunds's requests. I'm an Adobe employee, but I've signed the CLA nonetheless. |
|
Yeah, even us Adobe employees need to sign it. Would be nice to be able to sign once for all Adobe open source projects. Anyway, are you sure you signed with this account: https://github.com/oslego ? It's not showing up for me. |
|
I might have forgotten the username. I signed again using the credentials I've used to push the commits |
|
Now I see it. Thanks. Merging. |
redmunds
added a commit
that referenced
this pull request
Jun 6, 2013
Consolidate color matching regex and share across extensions
|
Thank you! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
None yet
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
You can’t perform that action at this time.
Move color matching regex to new shared file in
/utils/, used by InlineColorPicker and QuickView extensions.Retry of the patch discussed in #3754.
Initial goal was to make InlineColorPicker match color names. Re-used existing regex found in
QuickView/main.jswhich accomplished that goal.