| CARVIEW |
Select Language
HTTP/2 200
date: Mon, 14 Jul 2025 18:52:24 GMT
content-type: text/html; charset=utf-8
cache-control: no-cache
content-security-policy: default-src 'none'; base-uri 'self'; child-src github.githubassets.com github.com/assets-cdn/worker/ github.com/assets/ gist.github.com/assets-cdn/worker/; connect-src 'self' uploads.github.com www.githubstatus.com collector.github.com raw.githubusercontent.com api.github.com github-cloud.s3.amazonaws.com github-production-repository-file-5c1aeb.s3.amazonaws.com github-production-upload-manifest-file-7fdce7.s3.amazonaws.com github-production-user-asset-6210df.s3.amazonaws.com *.rel.tunnels.api.visualstudio.com wss://*.rel.tunnels.api.visualstudio.com objects-origin.githubusercontent.com copilot-proxy.githubusercontent.com proxy.individual.githubcopilot.com proxy.business.githubcopilot.com proxy.enterprise.githubcopilot.com *.actions.githubusercontent.com wss://*.actions.githubusercontent.com productionresultssa0.blob.core.windows.net/ productionresultssa1.blob.core.windows.net/ productionresultssa2.blob.core.windows.net/ productionresultssa3.blob.core.windows.net/ productionresultssa4.blob.core.windows.net/ productionresultssa5.blob.core.windows.net/ productionresultssa6.blob.core.windows.net/ productionresultssa7.blob.core.windows.net/ productionresultssa8.blob.core.windows.net/ productionresultssa9.blob.core.windows.net/ productionresultssa10.blob.core.windows.net/ productionresultssa11.blob.core.windows.net/ productionresultssa12.blob.core.windows.net/ productionresultssa13.blob.core.windows.net/ productionresultssa14.blob.core.windows.net/ productionresultssa15.blob.core.windows.net/ productionresultssa16.blob.core.windows.net/ productionresultssa17.blob.core.windows.net/ productionresultssa18.blob.core.windows.net/ productionresultssa19.blob.core.windows.net/ github-production-repository-image-32fea6.s3.amazonaws.com github-production-release-asset-2e65be.s3.amazonaws.com insights.github.com wss://alive.github.com api.githubcopilot.com api.individual.githubcopilot.com api.business.githubcopilot.com api.enterprise.githubcopilot.com; font-src github.githubassets.com; form-action 'self' github.com gist.github.com copilot-workspace.githubnext.com objects-origin.githubusercontent.com; frame-ancestors 'none'; frame-src viewscreen.githubusercontent.com notebooks.githubusercontent.com; img-src 'self' data: blob: github.githubassets.com media.githubusercontent.com camo.githubusercontent.com identicons.github.com avatars.githubusercontent.com private-avatars.githubusercontent.com github-cloud.s3.amazonaws.com objects.githubusercontent.com release-assets.githubusercontent.com secured-user-images.githubusercontent.com/ user-images.githubusercontent.com/ private-user-images.githubusercontent.com opengraph.githubassets.com copilotprodattachments.blob.core.windows.net/github-production-copilot-attachments/ github-production-user-asset-6210df.s3.amazonaws.com customer-stories-feed.github.com spotlights-feed.github.com objects-origin.githubusercontent.com *.githubusercontent.com; manifest-src 'self'; media-src github.com user-images.githubusercontent.com/ secured-user-images.githubusercontent.com/ private-user-images.githubusercontent.com github-production-user-asset-6210df.s3.amazonaws.com gist.github.com; script-src github.githubassets.com; style-src 'unsafe-inline' github.githubassets.com; upgrade-insecure-requests; worker-src github.githubassets.com github.com/assets-cdn/worker/ github.com/assets/ gist.github.com/assets-cdn/worker/
referrer-policy: no-referrer-when-downgrade
server-timing: pull_request_layout-fragment;desc="pull_request_layout fragment";dur=332.460164,conversation_content-fragment;desc="conversation_content fragment";dur=1134.36083,conversation_sidebar-fragment;desc="conversation_sidebar fragment";dur=269.445828,nginx;desc="NGINX";dur=1.504069,glb;desc="GLB";dur=96.440179
strict-transport-security: max-age=31536000; includeSubdomains; preload
vary: X-PJAX, X-PJAX-Container, Turbo-Visit, Turbo-Frame, X-Requested-With,Accept-Encoding, Accept, X-Requested-With
x-content-type-options: nosniff
x-frame-options: deny
x-voltron-version: 6a3bf42
x-xss-protection: 0
server: github.com
content-encoding: gzip
accept-ranges: bytes
set-cookie: _gh_sess=ODuiFS%2Fc%2F97rc8Gt7lHu7ih4xnUMO%2BXzsoWBZDWwHU7TRQ5YfjzozdxhaYEFGJHh%2FMZ4liRN%2FX%2BdveZFcNayeriT3aniRklw6urU4FqlWXwh9PGS61VTHyRn4vAZxAuDCa27xVj%2Bt8syhKAztbGZfDG3QSsVV%2FaNh6%2B2wY14bZA0DNYKMeKxu686e8xfINy928F6lZ%2BnLjOWbwbUoMBAIQdCyjbb9Qdt4yUnCVls8GlWUbouWapMNSI5DrFGaAr%2FhtmbQ0jSGRH%2FRmPcUa5JrQ%3D%3D--3BNJ62ws4QSgrhzz--KPCSwxsHNYoz0XVrCpk9rA%3D%3D; Path=/; HttpOnly; Secure; SameSite=Lax
set-cookie: _octo=GH1.1.954284732.1752519142; Path=/; Domain=github.com; Expires=Tue, 14 Jul 2026 18:52:22 GMT; Secure; SameSite=Lax
set-cookie: logged_in=no; Path=/; Domain=github.com; Expires=Tue, 14 Jul 2026 18:52:22 GMT; HttpOnly; Secure; SameSite=Lax
x-github-request-id: DA2C:3E190C:7A7957:8C7152:687551E6
Move file or folder to the trash by gruehle · Pull Request #3879 · adobe/brackets · GitHub
Skip to content
Navigation Menu
{{ message }}
This repository was archived by the owner on Sep 6, 2021. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 7.6k
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… bracket-shell)
…ete on windows accepted
|
@redmunds would you mind reviewing? I can rebase/squash once the review is complete. |
ghost
assigned
|
Cool, delete was an obvious omission - glad we're addressing this! |
| */ | ||
| function notifyFileDeleted(file) { | ||
| function notifyFileDeleted(file, skipAutoSelect) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
skipAutoSelect parameter is unused.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yep, that should have been passed to closeFullEditor(). Fixed.
|
Bug: Find in Files is not updated after a file is deleted. A reference to deleted file is still in list and displays an error if you click on it. |
|
Bug: If you display an image in Quick View, delete the image, then go back and hover of the image reference again, the image is still displayed. Need to clear a cache somewhere? |
|
Done with initial review |
|
Re Find in Files: does a similar bug exist with rename? If so the delete case seems puntable & the fixes should be lumped together... |
@peterflynn No, Find in Files results are correctly updated after a file is renamed. |
|
Changes pushed:
I couldn't find a reliable fix for the Quick View issue. CEF must be caching the image, and there is no way to clear the cache (short of a full refresh of Brackets, which seems excessive). |
|
Looks good. Squash away! |
|
Ugh. Rebasing 6 month old code is a pain... It would require fixing a ton of manual merge conflicts. I could do a squashed commit, but then there would be a single commit from me, and I want to make sure @leonuh gets credit for his changes. Let's just merge as-is for now. In the future, I'll make sure to do the rebase first if the changes are really old. |
|
Merging. |
redmunds
added a commit
that referenced
this pull request
May 17, 2013
Move file or folder to the trash
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
None yet
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
You can’t perform that action at this time.
Supersedes #2203
Add a "Delete" context menu item that moves the selected item (file or folder) to the trash/recycle bin.
The "move to trash" part is easy. The complicated parts are updating the tree and notifying the world that the file has been deleted.