You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository was archived by the owner on Sep 6, 2021. It is now read-only.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fixes issue #3773. minor fix to only show dialog "Error Indexing Files" "The maximum number of files have been indexed. Actions that look up files in the index may function incorrectly." The problem is if your current project has > 10k files you see this error every time you save an edit and dirty the cache. The fix is to show to error the first infraction and use console.log subsequent times.
It seems like _maxFileDialogDisplayed should get reset whenever a new project is loaded. If you split the "projectOpen projectFilesChange" listener at bottom in two then you can do it there on "projectOpen".
peterflynn: Thanks for reviewing the pull request. I signed the Brackets Contributor agreement and updated branch with your suggestions.
split "projectOpen projectFilesChange", reset _maxFileDialogDisplayed on "projectOpen", tested this by triggering max files indexing, add new file to project = verify warning to console, open new project = verify dialog appears
I have several projects where I am leveraging 'bower.io' to manage my web dependencies and run into the limit frequently. Additionally, I do nodejs projects with the node_modules directory full of dependencies. I run into the limit constantly. It makes Brackets Quick Open feature unusable.
Would it be possible to ignore certain directories like app/bower_components and node_modules or give us the option to ignore them?
agreed, something should be done to limit the number of files being indexed. right now, since brackets starts up in my home directory (with a godawful number of .hidden directories), it'll freeze up almost every time to the point where i have to force kill brackets.
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
None yet
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes issue #3773. minor fix to only show dialog "Error Indexing Files" "The maximum number of files have been indexed. Actions that look up files in the index may function incorrectly." The problem is if your current project has > 10k files you see this error every time you save an edit and dirty the cache. The fix is to show to error the first infraction and use console.log subsequent times.