You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository was archived by the owner on Sep 6, 2021. It is now read-only.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@jbalsas to be honest I did't realize that people was using that extension ??? hbs is so sort and good looking, byt if many people is using the longer extension version, when yes it should be added
I was just curious, since I've seen it mentioned in some tutorials, mostly in reference to precompiling templates. (https://handlebarsjs.com/precompilation.html) This is just a convention, so we may well ignore it, but it would look weird if we support one but not the other.
@tcarlsen This looks good, but it breaks one test in test/spec/LanguageManager-test.js. It should be fairly easy to fix, and then we're good to go :)
Btw, new commits do not trigger the email notifications, so make sure to ping whoever's reviewing your pull requests to let him know that there's new stuff to look into.
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
None yet
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.